Re: [PATCH] duplicate selected text when inserting floats

2007-02-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Bernhard Roider wrote: >> Hello, >> >> as nobody replied to this mail - did somebody have a look at the >> attached patch? For me it is very useful if the contents of a float >> is centered. Am i alone with this opini

Re: [PATCH] duplicate selected text when inserting floats

2007-02-16 Thread Abdelrazak Younes
Bernhard Roider wrote: Hello, as nobody replied to this mail - did somebody have a look at the attached patch? For me it is very useful if the contents of a float is centered. Am i alone with this opinion? FYI, there is a discussion going on in the user list about this. Paul Smith suggested

Re: [PATCH] duplicate selected text when inserting floats

2007-02-16 Thread Abdelrazak Younes
Bernhard Roider wrote: Hello, as nobody replied to this mail - did somebody have a look at the attached patch? For me it is very useful if the contents of a float is centered. Am i alone with this opinion? I am with you on this. As I know nothing about this field I'll let JMarc gives his op

Re: [PATCH] duplicate selected text when inserting floats

2007-02-15 Thread Bernhard Roider
Hello, as nobody replied to this mail - did somebody have a look at the attached patch? For me it is very useful if the contents of a float is centered. Am i alone with this opinion? Another idea concerning the two empty paragraphs: maybe a configuration entry whether the empty paragraph should

Re: [PATCH] duplicate selected text when inserting floats

2007-02-11 Thread Bernhard Roider
Michael Gerz wrote: Jean-Marc Lasgouttes schrieb: Other than that, I am not sure that I like all this automatic centering business. If the user has already provided some contents, it is very surprising that inserting a float around it would modify its alignment. JMarc JMarc, Bernhard, I co

Re: [PATCH] duplicate selected text when inserting floats

2007-02-09 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: Other than that, I am not sure that I like all this automatic centering business. If the user has already provided some contents, it is very surprising that inserting a float around it would modify its alignment. JMarc JMarc, Bernhard, I committed a slightly

Re: [PATCH] duplicate selected text when inserting floats

2007-02-09 Thread Jean-Marc Lasgouttes
> "Bernhard" == Bernhard Roider <[EMAIL PROTECTED]> writes: Bernhard> Michael Gerz wrote: >> how about the attached patch? I think it captures a few more cases Bernhard> Hi Michael, Bernhard> you mean that the user rather first creates the contents of Bernhard> the float and then inserts the

Re: [PATCH] duplicate selected text when inserting floats

2007-02-08 Thread Bernhard Roider
Michael Gerz wrote: how about the attached patch? I think it captures a few more cases Hi Michael, you mean that the user rather first creates the contents of the float and then inserts the float than write the caption and then insert the float? Thats imho a better solution. I added the cen

Re: [PATCH] duplicate selected text when inserting floats

2007-02-08 Thread Michael Gerz
Bernhard Roider schrieb: Hello! Another minor issue (i did not find a bugzilla entry): If you select text and insert a float then all three paragraphs that are created are filled with the text and in the middle paragraph the caption inset is displayed left of the text. With this patch the ab

Re: [PATCH] duplicate selected text when inserting floats

2007-02-07 Thread Abdelrazak Younes
Bernhard Roider wrote: Hello! Another minor issue (i did not find a bugzilla entry): If you select text and insert a float then all three paragraphs that are created are filled with the text and in the middle paragraph the caption inset is displayed left of the text. With this patch the abov