Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Andre Poenitz
On Wed, Aug 21, 2002 at 04:58:03PM +0100, John Levon wrote: > On Wed, Aug 21, 2002 at 05:47:03PM +0200, Lars Gullik Bjønnes wrote: > > > Yes, but for all the intermediate versions we will not have > > converters... (or should not have.) > > We will have to have this conversion code anyway ! Som

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Aug 21, 2002 at 06:27:26PM +0200, Lars Gullik Bjønnes wrote: > >> >> | We will have to have this conversion code anyway ! >> >> >> >> No we won't. >> > >> | You've lost me >> >> temporary changes within the development cycle. > | Rob's change

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread John Levon
On Wed, Aug 21, 2002 at 06:27:26PM +0200, Lars Gullik Bjønnes wrote: > >> | We will have to have this conversion code anyway ! > >> > >> No we won't. > > > | You've lost me > > temporary changes within the development cycle. Rob's changes are permanent. regards john -- "Way back at the b

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Aug 21, 2002 at 06:07:00PM +0200, Lars Gullik Bjønnes wrote: > >> | We will have to have this conversion code anyway ! >> >> No we won't. > | You've lost me temporary changes within the development cycle. -- Lgb

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread John Levon
On Wed, Aug 21, 2002 at 06:07:00PM +0200, Lars Gullik Bjønnes wrote: > | We will have to have this conversion code anyway ! > > No we won't. You've lost me regards john -- "Way back at the beginning of time around 1970 the first man page was handed down from on high. Every one since is a

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Aug 21, 2002 at 05:47:03PM +0200, Lars Gullik Bjønnes wrote: > >> Yes, but for all the intermediate versions we will not have >> converters... (or should not have.) > | We will have to have this conversion code anyway ! No we won't. -- L

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread John Levon
On Wed, Aug 21, 2002 at 04:54:47PM +0100, José Abílio Oliveira Matos wrote: > IMHO, please, don't. > Anyone that uses the dev version should know better. > > Make it possible for the next stable version to be able to correct any > anomalies it found. This should take care of those files.

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread John Levon
On Wed, Aug 21, 2002 at 05:47:03PM +0200, Lars Gullik Bjønnes wrote: > Yes, but for all the intermediate versions we will not have > converters... (or should not have.) We will have to have this conversion code anyway ! john -- "Way back at the beginning of time around 1970 the first man page

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread José Abílio Oliveira Matos
On Wednesday 21 August 2002 16:40, John Levon wrote: > > Seeing we've had numerous problems with documents from testers that are > in intermediate formats, and the format is the major way that lyx2lyx > works, I suggest bumping the number on ANY format change. Why would this > be a problem ? IM

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Wed, Aug 21, 2002 at 09:45:56AM +0200, Lars Gullik Bjønnes wrote: > >> | the old from new format. That should come with my patch! But where in the code >does >> | that happen? And what are the rules for incrementing the format version? >> >> Whenever

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread John Levon
On Wed, Aug 21, 2002 at 09:45:56AM +0200, Lars Gullik Bjønnes wrote: > | the old from new format. That should come with my patch! But where in the code does > | that happen? And what are the rules for incrementing the format version? > > Whenever you change the .lyx format increase the format ve

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Rob Lahaye
Rob Lahaye wrote: > > Thanks Dekel! > > (*) same applies to "size_type 0" > (**) same applies to "size_type 1" > (***) same applies to "lyxsize_type 0" These three lines should have been erased before sending. Please ignore.

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Lars Gullik Bjønnes
Rob Lahaye <[EMAIL PROTECTED]> writes: | Dekel Tsur wrote: | > On Tue, Aug 20, 2002 at 10:22:58AM +0100, Angus Leeming wrote: | > The code for compatibility read should not be in the lyx sources. | > It is quite easy to do in lyx2lyx. If you don't know how, | > write the differences between the o

Re: [PATCH] New Xforms Graphics Dialog

2002-08-21 Thread Rob Lahaye
Dekel Tsur wrote: > On Tue, Aug 20, 2002 at 10:22:58AM +0100, Angus Leeming wrote: > > The code for compatibility read should not be in the lyx sources. > It is quite easy to do in lyx2lyx. If you don't know how, > write the differences between the old & new formats and I'll do it. Thanks Dekel

Re: [PATCH] New Xforms Graphics Dialog

2002-08-20 Thread Dekel Tsur
On Tue, Aug 20, 2002 at 10:22:58AM +0100, Angus Leeming wrote: > > I may think of this a little more, but I believe some backward > > compatibility loss is unavoidable, with all these old keywords > > disappearing. But keep in mind: only odd input will break, e.g. choose > > "Original size", but a

Re: [PATCH] New Xforms Graphics Dialog

2002-08-20 Thread Angus Leeming
On Tuesday 20 August 2002 4:11 am, Rob Lahaye wrote: > Angus Leeming wrote: > > I'm worried however by this > > > > +Backward compatibility from 1.2.0 to 1.3.0 is mostly all right. > > +Compatibility problems arise when (lyx)size_kind is original_size > > +and also values for (lyx)scale and/or (ly

Re: [PATCH] New Xforms Graphics Dialog

2002-08-19 Thread Rob Lahaye
Angus Leeming wrote: > > This is looking good Rob. Any patch that has more lines starting with "-" > thatn with "+" is probably doing the right thing ;-) In your case you have > 1731 '-'s and 673 '+'s. And you reckon functionality is unchanged? Excellent. Lots of stuff concerning size_kind/typ

Re: [PATCH] New Xforms Graphics Dialog

2002-08-19 Thread Angus Leeming
On Monday 19 August 2002 12:55 pm, Rob Lahaye wrote: > Rob Lahaye wrote: > > Hi, > > > > Attached is the patch that implements the new layout for the graphics > > dialog with xforms. > > Thanks for the feed back. This is a new patch that deals with the image > scaling only locally in FormGraphics.

Re: [PATCH] New Xforms Graphics Dialog

2002-08-19 Thread Rob Lahaye
Rob Lahaye wrote: > > Hi, > > Attached is the patch that implements the new layout for the graphics > dialog with xforms. Thanks for the feed back. This is a new patch that deals with the image scaling only locally in FormGraphics. None of the unit lists elsewhere are touched. New Patch for t

Re: [PATCH] New Xforms Graphics Dialog

2002-08-19 Thread Dekel Tsur
On Mon, Aug 19, 2002 at 05:11:33PM +0900, Rob Lahaye wrote: > > readFigInset() can be erased. > > figinset insets are converted by lyx2lyx to insetgraphics. > > Double check: You mean the whole routine can be deleted right away. > It's of no use anymore? Yes.

Re: [PATCH] New Xforms Graphics Dialog

2002-08-19 Thread Rob Lahaye
Dekel Tsur wrote: > On Mon, Aug 19, 2002 at 02:51:50PM +0900, Rob Lahaye wrote: > >>3) What is this strange setting of defaultUnit in FormGraphics: >>if (lyxrc.default_papersize < 3) defaultUnit = "in"; >>(? what is this magic "3" ?). > > > This should be changed to > if (l

Re: [PATCH] New Xforms Graphics Dialog

2002-08-19 Thread Dekel Tsur
On Mon, Aug 19, 2002 at 02:51:50PM +0900, Rob Lahaye wrote: > 3) What is this strange setting of defaultUnit in FormGraphics: > if (lyxrc.default_papersize < 3) defaultUnit = "in"; > (? what is this magic "3" ?). This should be changed to if (lyxrc.default_papersize <= Buffer