Dekel Tsur wrote: > On Mon, Aug 19, 2002 at 02:51:50PM +0900, Rob Lahaye wrote: > >>3) What is this strange setting of defaultUnit in FormGraphics: >> if (lyxrc.default_papersize < 3) defaultUnit = "in"; >> (? what is this magic "3" ?). > > > This should be changed to > if (lyxrc.default_papersize <= BufferParams::PAPER_EXECUTIVEPAPER) > or > if (lyxrc.default_papersize < BufferParams::PAPER_A3PAPER) > > But shouldn't the default unit (for width) be line% or something similar ?
Thanks, I have a look at these PAPER_A3PAPER etc. things. The default for width is "scale%"-unit and value 100, so that the dialog defaults to original-image-size. This "scale%" is a new size-unit, introduced in my patch. So after all, the "defaultUnit" setting is not that relevant anymore. May be its use in FormGraphics can go altogether. Let me think of that. >>4) insetgraphics.C::InsetGraphics::readFigInset() >> I commented out the keywords that do not exist anymore, but I >> don't know if I have done the right thing here (and in general >> in this file). Things seem to work here at my side, though. > > > readFigInset() can be erased. > figinset insets are converted by lyx2lyx to insetgraphics. Double check: You mean the whole routine can be deleted right away. It's of no use anymore? Say yes, and it's gone with my next NewGraphicsDialog-patch :). (Is there more that can go in this file?) Rob.
