Re: [PATCH] Help wanted with FormPara

2002-01-09 Thread John Levon
On Wed, Jan 09, 2002 at 10:41:39AM +, Angus Leeming wrote: > Actually, this looks suspicious. par_ is the pointer to the paragraph whose > parameters originally filled the dialog. It should be reset only on a > restore. I think you want: > Paragraph const * p = getCurrentParagraph();

Re: [PATCH] Help wanted with FormPara

2002-01-09 Thread Angus Leeming
On Tuesday 08 January 2002 6:03 pm, John Levon wrote: > Try the below patch. The ehaviour seems totally random: sometimes a fixed-width > cell allows the dialog, sometimes it doesn't. I have NO idea why. Juergen, Angus, > can you look please ? > > thanks > john > > > Index: FormParagraph.C >

Re: [PATCH] Help wanted with FormPara

2002-01-09 Thread Angus Leeming
On Tuesday 08 January 2002 7:42 pm, John Levon wrote: > On Tue, Jan 08, 2002 at 07:31:23PM +, Angus Leeming wrote: [snip future ways forward] > Again, what is /actually/ wrong with the current code + my patch ? I can't > see the problem; it seems getCurrentParagraph is returning different pa

Re: [PATCH] Help wanted with FormPara

2002-01-08 Thread John Levon
On Tue, Jan 08, 2002 at 07:31:23PM +, Angus Leeming wrote: > > can you look please ? > > It seems to me that the fundamental problem here is that we store a pointer > to a paragraph in this dialog as our unit of comparison. Really we should be > storing a paragraphParameters instance. wel

Re: [PATCH] Help wanted with FormPara

2002-01-08 Thread Angus Leeming
On Tuesday 08 January 2002 6:03 pm, John Levon wrote: > Try the below patch. The ehaviour seems totally random: sometimes a fixed-width > cell allows the dialog, sometimes it doesn't. I have NO idea why. Juergen, Angus, > can you look please ? > > thanks > john It seems to me that the fundamen