On Tue, Jan 08, 2002 at 07:31:23PM +0000, Angus Leeming wrote:
> > can you look please ?
>
> It seems to me that the fundamental problem here is that we store a pointer
> to a paragraph in this dialog as our unit of comparison. Really we should be
> storing a paragraphParameters instance.
well, that's obviously true (plus the thing that the params must hold a forceDefault
bool, which is an aspect of /where/ the para is), but I'm thinking about 1.2.0
here. Obviously when this get MVCed we want to fix its behaviour, but that's
not happening soon.
Again, what is /actually/ wrong with the current code + my patch ? I can't
see the problem; it seems getCurrentParagraph is returning different paras
under different situations with the same para !
> > + // if we don't change par_ here, moving back to the original
> > + // paragraph won't re-enable apply(). However, if we DO, then
> > + // restore will restore the current paragraph's options. Which
> > + // do we want ?
> > +
> > + // we should somehow permanently disable the ok/apply instead !
these are two things we worry about when it gets MVCed, I just want the patch
to basically work now.
regards
john
--
"I went to set up a Yahoo ID for my dog. (Don't ask, but the DOG'S email was
cluttering my inbox)."
- Ruthless Advisorette
