Re: [PATCH] Don't make everything checkable in menus

> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> What happens is that you set all menu entries as checkable. Jean-Marc> With the style I use (plastik), this means that one gets a Jean-Marc> small checkbox near to each menu item. So the basis of the Jean-Marc> patch

Re: [PATCH] Don't make everything checkable in menus

Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Don't set your hopes too high. I just wanted to see what is so fantastic about qt4. Abdelrazak> Man, I never claimed that it is fantastic, I just said it Abdelrazak> is better than qt3 right now. So

Re: [PATCH] Don't make everything checkable in menus

> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Don't set your hopes too high. I just wanted to see what is so >> fantastic about qt4. Abdelrazak> Man, I never claimed that it is fantastic, I just said it Abdelrazak> is better than qt3 right now. Sorry, I was teasing you

Re: [PATCH] Don't make everything checkable in menus

Edwin Leuven wrote: Abdelrazak Younes wrote: The changes look good but is this a cleanup or a bug fix? I don't see all toobar buttons and menu items as checkable here... there is a checkable "compressed" menu item iirc... Yes and the Change Tracking one and they both work correctly I think.

Re: [PATCH] Don't make everything checkable in menus

Abdelrazak Younes wrote: The changes look good but is this a cleanup or a bug fix? I don't see all toobar buttons and menu items as checkable here... there is a checkable "compressed" menu item iirc...

Re: [PATCH] Don't make everything checkable in menus

Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: This patch tries to sanitize a bit the way menus are generated on qt4. Actions are not made checkable for no reason, and the code to set action features is moved to

Re: [PATCH] Don't make everything checkable in menus

> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >> This patch tries to sanitize a bit the way menus are generated on >> qt4. Actions are not made checkable for no reason, and the code to >> set action features is moved to Action::update.

Re: [PATCH] Don't make everything checkable in menus

Jean-Marc Lasgouttes wrote: This patch tries to sanitize a bit the way menus are generated on qt4. Actions are not made checkable for no reason, and the code to set action features is moved to Action::update. I am impressed! Welcome Jean-Marc :-) Abdel.