Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Don't set your hopes too high. I just wanted to see what is so
fantastic about qt4.
Abdelrazak> Man, I never claimed that it is fantastic, I just said it
Abdelrazak> is better than qt3 right now.
Sorry, I was teasing you :)
No PB :)
Does this mean I should apply?
Abdelrazak> The changes look good but is this a cleanup or a bug fix?
Abdelrazak> I don't see all toobar buttons and menu items as checkable
Abdelrazak> here...
What happens is that you set all menu entries as checkable. With the
style I use (plastik), this means that one gets a small checkbox near
to each menu item. So the basis of the patch is to set checkable only
when the entry is a toggle, and then set checked to true or false as
needed.
This is made less evident by the fact that I move this code to
Action::update (it was duplicated before).
So the log would look like:
* src/frontends/qt4/Action.C (Action): do not set entry to
checkable by default; invoke update() to set it up.
(update): only set checkable property if needed.
* src/frontends/qt4/QLPopupMenu.C (populate): in the case of
a Command menu item, let Action set itself up.
Clearer now?
Yes, please apply.
Abdel.
