Re: [LyX/master] Fix typo (thanks to Salvatore Falco for the fix).

2019-11-06 Thread José Abílio Matos
On Wednesday, 6 November 2019 15.23.46 WET Pavel Sanda wrote: > On Mon, Nov 04, 2019 at 12:58:42PM +0100, JosĂŠ Matos wrote: > > commit 668aa17ad7567b5969796b9a7a8f57f57a646e92 > > Author: José Matos > > Date: Mon Nov 4 12:12:23 2019 + > > > > Fix typo (thanks to Salvatore Falco for the

Re: [LyX/master] Fix typo (thanks to Salvatore Falco for the fix).

2019-11-06 Thread Pavel Sanda
On Mon, Nov 04, 2019 at 12:58:42PM +0100, JosĂŠ Matos wrote: > commit 668aa17ad7567b5969796b9a7a8f57f57a646e92 > Author: José Matos > Date: Mon Nov 4 12:12:23 2019 + > > Fix typo (thanks to Salvatore Falco for the fix). Shouldn't this go to branch as well? P -- lyx-devel mailing list

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Richard Heck
On 03/14/2017 09:28 AM, Jean-Marc Lasgouttes wrote: > Le 14/03/2017 à 04:41, Richard Heck a écrit : >> On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: >>> Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes, a

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 04:41, Richard Heck a écrit : On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes, and should be painless? I think it should be a bit long, but painl

Re: [LyX/master] Fix typo found by coverity

2017-03-14 Thread Jean-Marc Lasgouttes
Le 14/03/2017 à 04:41, Richard Heck a écrit : Done. Not too long, but definitely painless. Thanks. JMarc

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Richard Heck
On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: > Le 13/03/2017 à 16:18, Richard Heck a écrit : >> I'll move the formats variable to the singleton, too. That seems worth >> doing, yes, and should be painless? > > I think it should be a bit long, but painless. Done. Not too long, but definitely

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Jean-Marc Lasgouttes
Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes, and should be painless? I think it should be a bit long, but painless. JMarc

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Richard Heck
On 03/13/2017 06:43 AM, Jean-Marc Lasgouttes wrote: > Le 07/03/2017 à 21:14, Richard Heck a écrit : >>> Actually there are other uses of the variable `formats' in >>> Formats.cpp, and I think that they are all incorrect (should be >>> formatlist). This will not matter in most cases, fortunately. >>

Re: [LyX/master] Fix typo found by coverity

2017-03-13 Thread Jean-Marc Lasgouttes
Le 07/03/2017 à 21:14, Richard Heck a écrit : Actually there are other uses of the variable `formats' in Formats.cpp, and I think that they are all incorrect (should be formatlist). This will not matter in most cases, fortunately. I will try to have a look at this. I did that at a2bfe0042d. P

Re: [LyX/master] Fix typo found by coverity

2017-03-07 Thread Richard Heck
On 03/07/2017 06:16 AM, Jean-Marc Lasgouttes wrote: > Le 07/03/2017 à 12:08, Jean-Marc Lasgouttes a écrit : >> commit dc126bad0441eb8721043e597657d5c18bdf6c90 >> Author: Jean-Marc Lasgouttes >> Date: Tue Mar 7 12:02:54 2017 +0100 >> >> Fix typo found by coverity >> >> We were not testing

Re: [LyX/master] Fix typo found by coverity

2017-03-07 Thread Jean-Marc Lasgouttes
Le 07/03/2017 à 12:08, Jean-Marc Lasgouttes a écrit : commit dc126bad0441eb8721043e597657d5c18bdf6c90 Author: Jean-Marc Lasgouttes Date: Tue Mar 7 12:02:54 2017 +0100 Fix typo found by coverity We were not testing for the right end(), although it is not sure that an actual bug co

Re: [LyX/master] Fix typo

2015-10-13 Thread Vincent van Ravesteijn
On Tue, Oct 13, 2015 at 8:45 AM, Jean-Marc Lasgouttes wrote: > Le 13/10/15 02:08, Scott Kostyshak a écrit : >> >> On Mon, Oct 12, 2015 at 11:49:42AM +0200, Jean-Marc Lasgouttes wrote: >>> >>> Le 12/10/2015 11:16, Stephan Witt a écrit : Am 12.10.2015 um 11:04 schrieb Jean-Marc Lasgouttes

Re: [LyX/master] Fix typo

2015-10-12 Thread Jean-Marc Lasgouttes
Le 13/10/15 02:08, Scott Kostyshak a écrit : On Mon, Oct 12, 2015 at 11:49:42AM +0200, Jean-Marc Lasgouttes wrote: Le 12/10/2015 11:16, Stephan Witt a écrit : Am 12.10.2015 um 11:04 schrieb Jean-Marc Lasgouttes : Le 10/10/2015 21:31, Stephan Witt a écrit : Another question with "dead store"

Re: [LyX/master] Fix typo

2015-10-12 Thread Scott Kostyshak
On Mon, Oct 12, 2015 at 11:49:42AM +0200, Jean-Marc Lasgouttes wrote: > Le 12/10/2015 11:16, Stephan Witt a écrit : > >Am 12.10.2015 um 11:04 schrieb Jean-Marc Lasgouttes : > > > >>Le 10/10/2015 21:31, Stephan Witt a écrit : > >>>Another question with "dead store" code is in RowPainter::paintFirst:

Re: [LyX/master] Fix typo

2015-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2015 11:16, Stephan Witt a écrit : Am 12.10.2015 um 11:04 schrieb Jean-Marc Lasgouttes : Le 10/10/2015 21:31, Stephan Witt a écrit : Another question with "dead store" code is in RowPainter::paintFirst: The y_top assignments are not used. JMarc, do you know if the code block simply c

Re: [LyX/master] Fix typo

2015-10-12 Thread Stephan Witt
Am 12.10.2015 um 11:04 schrieb Jean-Marc Lasgouttes : > Le 10/10/2015 21:31, Stephan Witt a écrit : >> Another question with "dead store" code is in RowPainter::paintFirst: >> >> The y_top assignments are not used. >> JMarc, do you know if the code block simply can be removed? > > The code was a

Re: [LyX/master] Fix typo

2015-10-12 Thread Jean-Marc Lasgouttes
Le 10/10/2015 21:31, Stephan Witt a écrit : Another question with "dead store" code is in RowPainter::paintFirst: The y_top assignments are not used. JMarc, do you know if the code block simply can be removed? The code was already like that in 2.1. I will try to remove the variable and see wh

Re: [LyX/master] Fix typo

2015-10-10 Thread Stephan Witt
Am 09.10.2015 um 21:38 schrieb Georg Baum : > commit 3602baa40c283f32fea3dcfde08b12306afe3dab > Author: Georg Baum > Date: Fri Oct 9 21:37:43 2015 +0200 > >Fix typo > >Found by gcc: operation on 'preview_ptr' may be undefined > [-Wsequence-point] > > diff --git a/src/insets/InsetExt

Re: [LyX/master] Fix typo spotted by cppcheck

2014-07-06 Thread Richard Heck
On 07/05/2014 05:39 PM, Jean-Marc Lasgouttes wrote: Le 05/07/14 18:02, Jean-Marc a écrit : commit 8715bab65cc87272dd0d701e31b37363d43d6e95 Author: Jean-Marc Date: Sat Jul 5 18:01:19 2014 +0200 Fix typo spotted by cppcheck Richard, I am not sure that this code is used (how do we check

Re: [LyX/master] Fix typo spotted by cppcheck

2014-07-05 Thread Jean-Marc Lasgouttes
Le 05/07/14 18:02, Jean-Marc a écrit : commit 8715bab65cc87272dd0d701e31b37363d43d6e95 Author: Jean-Marc Date: Sat Jul 5 18:01:19 2014 +0200 Fix typo spotted by cppcheck Richard, I am not sure that this code is used (how do we check for that?), but in any case it is candidate for 2.1.