Re: [LyX/master] Fix typo spotted by cppcheck

[Jean-Marc Lasgouttes]

Le 05/07/14 18:02, Jean-Marc a écrit :
commit 8715bab65cc87272dd0d701e31b37363d43d6e95
Author: Jean-Marc <lasgout...@lyx.org>
Date:   Sat Jul 5 18:01:19 2014 +0200
     Fix typo spotted by cppcheck

Richard, I am not sure that this code is used (how do we check for 
that?), but in any case it is candidate for 2.1.2.

JMarc


diff --git a/src/support/lstrings.cpp b/src/support/lstrings.cpp
index 8508e4e..ea1ba59 100644
--- a/src/support/lstrings.cpp
+++ b/src/support/lstrings.cpp
@@ -1458,7 +1458,7 @@ docstring bformat(docstring const & fmt, char const * 
arg1, docstring arg2)
        LATTEST(contains(fmt, from_ascii("%1$s")));
        LATTEST(contains(fmt, from_ascii("%2$s")));
        docstring str = subst(fmt, from_ascii("%1$s"), from_ascii(arg1));
-       str = subst(fmt, from_ascii("%2$s"), arg2);
+       str = subst(str, from_ascii("%2$s"), arg2);
        return subst(str, from_ascii("%%"), from_ascii("%"));
  }