Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-06 Thread Andre Poenitz
On Tue, Nov 06, 2007 at 01:39:40AM +0200, Dov Feldstern wrote: > Martin Vermeer wrote: >> On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: >>> >>> Martin Vermeer wrote: On Mon, 05 Nov 2007 15:49:22 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Jean-Marc

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-06 Thread Enrico Forestieri
On Tue, Nov 06, 2007 at 01:09:01PM +0200, Martin Vermeer wrote: > On Tue, 06 Nov 2007 11:33:23 +0100 > Abdelrazak Younes <[EMAIL PROTECTED]> wrote: [...] > > Still, I maintain that detecting the text direction automatically based > > on the Unicode code point would simplify things. > > Yes, why n

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-06 Thread Martin Vermeer
On Tue, 06 Nov 2007 11:33:23 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > On Tue, 06 Nov 2007 08:47:44 +0100 > > Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > > > >> Martin Vermeer wrote: > >>> On Tue, Nov 06, 2007 at 01:39:40AM +0200, Dov Feldstern wrote: > >>>

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-06 Thread Abdelrazak Younes
Martin Vermeer wrote: On Tue, 06 Nov 2007 08:47:44 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Martin Vermeer wrote: On Tue, Nov 06, 2007 at 01:39:40AM +0200, Dov Feldstern wrote: Martin Vermeer wrote: On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: ... Actually I t

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-06 Thread Martin Vermeer
On Tue, 06 Nov 2007 08:47:44 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > On Tue, Nov 06, 2007 at 01:39:40AM +0200, Dov Feldstern wrote: > >> Martin Vermeer wrote: > >>> On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: ... > > Actually I think you

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Abdelrazak Younes
Martin Vermeer wrote: On Tue, Nov 06, 2007 at 01:39:40AM +0200, Dov Feldstern wrote: Martin Vermeer wrote: On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: This is not accurate. It's true for URL, for example, but not for ERT. I agree with Abdel that ideally, in ERT we should a

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > Apart from that it would also make Jean-Marc happy... Yes. Everytime an explicit xxx_CODE test gets added to the source, a baby seal is murdered. You do not want that, do you? JMarc

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Martin Vermeer
On Tue, Nov 06, 2007 at 01:39:40AM +0200, Dov Feldstern wrote: > Martin Vermeer wrote: > >On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: > >>This is not accurate. It's true for URL, for example, but not for ERT. I > >>agree with Abdel that ideally, in ERT we should allow any encod

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Dov Feldstern
Martin Vermeer wrote: On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: Martin Vermeer wrote: On Mon, 05 Nov 2007 15:49:22 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Jean-Marc Lasgouttes wrote: Martin Vermeer writes: But I am not sure I understand. Why is forceLTR tr

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Andre Poenitz
On Mon, Nov 05, 2007 at 11:50:31PM +0200, Dov Feldstern wrote: > > > Andre Poenitz wrote: >> On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: >>> Martin Vermeer wrote: On Mon, 05 Nov 2007 15:49:22 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Jean-Marc Lasgouttes

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Martin Vermeer
On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: > > > Martin Vermeer wrote: > >On Mon, 05 Nov 2007 15:49:22 +0100 > >Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > > > >>Jean-Marc Lasgouttes wrote: > >>>Martin Vermeer writes: > >>> > >But I am not sure I understand. Why is for

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Dov Feldstern
Andre Poenitz wrote: On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: Martin Vermeer wrote: On Mon, 05 Nov 2007 15:49:22 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Jean-Marc Lasgouttes wrote: Martin Vermeer writes: But I am not sure I understand. Why is forceLTR tru

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Andre Poenitz
On Mon, Nov 05, 2007 at 11:13:34PM +0200, Dov Feldstern wrote: > Martin Vermeer wrote: >> On Mon, 05 Nov 2007 15:49:22 +0100 >> Abdelrazak Younes <[EMAIL PROTECTED]> wrote: >>> Jean-Marc Lasgouttes wrote: Martin Vermeer writes: >> But I am not sure I understand. Why is forceLTR true

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Dov Feldstern
Martin Vermeer wrote: On Mon, 05 Nov 2007 15:49:22 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Jean-Marc Lasgouttes wrote: Martin Vermeer writes: But I am not sure I understand. Why is forceLTR true for ERT? Just for display purpose? The truth is, it shouldn't be. We're overloading

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Andre Poenitz
On Mon, Nov 05, 2007 at 10:40:51PM +0200, Dov Feldstern wrote: > Andre Poenitz wrote: >> On Mon, Nov 05, 2007 at 02:16:52PM +0100, Jean-Marc Lasgouttes wrote: >>> [EMAIL PROTECTED] writes: >>> Modified: lyx-devel/trunk/src/Paragraph.cpp URL: http://www.lyx.org/trac/file/lyx-devel/tr

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Dov Feldstern
Andre Poenitz wrote: On Mon, Nov 05, 2007 at 02:16:52PM +0100, Jean-Marc Lasgouttes wrote: [EMAIL PROTECTED] writes: Modified: lyx-devel/trunk/src/Paragraph.cpp URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/Paragraph.cpp?rev=21407 ===

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Dov Feldstern
Martin Vermeer wrote: On Mon, 05 Nov 2007 14:16:52 +0100 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: What about declaring forceLTR in the Inset class (returning false by default) and overriding it for graphics, math and hyperlink? This would simplify this code and avoid the cast to insetco

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Andre Poenitz
On Mon, Nov 05, 2007 at 02:16:52PM +0100, Jean-Marc Lasgouttes wrote: > [EMAIL PROTECTED] writes: > > > Modified: lyx-devel/trunk/src/Paragraph.cpp > > URL: > > http://www.lyx.org/trac/file/lyx-devel/trunk/src/Paragraph.cpp?rev=21407 > > ===

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Martin Vermeer
On Mon, 05 Nov 2007 15:49:22 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Jean-Marc Lasgouttes wrote: > > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > >>> But I am not sure I understand. Why is forceLTR true for ERT? Just for > >>> display purpose? > >> Hmmm. It is to force the langua

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Martin Vermeer
On Mon, 05 Nov 2007 15:38:20 +0100 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> But I am not sure I understand. Why is forceLTR true for ERT? Just for > >> display purpose? > > > > Hmmm. It is to force the language, and thus the encoding, to

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: But I am not sure I understand. Why is forceLTR true for ERT? Just for display purpose? Hmmm. It is to force the language, and thus the encoding, to Latin1. LaTeX needs that; LyX display would be happy with Unicode, but isn

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> But I am not sure I understand. Why is forceLTR true for ERT? Just for >> display purpose? > > Hmmm. It is to force the language, and thus the encoding, to Latin1. > LaTeX needs that; LyX display would be happy with Unicode, but isn't > smart enough to

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Martin Vermeer
On Mon, 05 Nov 2007 15:07:32 +0100 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Also, why exactly is ERT a special case? > > > > At least that I can answer ;-) Because we want ERT output to be > > "naked". In any locale. No \L stuff or the l

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> Also, why exactly is ERT a special case? > > At least that I can answer ;-) Because we want ERT output to be > "naked". In any locale. No \L stuff or the like around it. Hmm, could we use noFontChange for that? /** * Is this inset a

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Martin Vermeer
On Mon, 05 Nov 2007 14:16:52 +0100 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] writes: > > > Modified: lyx-devel/trunk/src/Paragraph.cpp > > URL: > > http://www.lyx.org/trac/file/lyx-devel/trunk/src/Paragraph.cpp?rev=21407 > > =

Re: [Cvslog] r21407 - in /lyx-devel/trunk/src: Paragraph.cpp insets/In...

2007-11-05 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > Modified: lyx-devel/trunk/src/Paragraph.cpp > URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/Paragraph.cpp?rev=21407 > == > --- lyx-devel/trunk/src/Paragraph.cpp (original) > +++ lyx-deve