On Mon, Feb 06, 2006 at 09:46:10AM +1030, Beck, Andrew Thomas - BECAT001 wrote:
>
> >I just had a thought.
> >
> >Why not give the template a fixed numerb of cells gain.
> >
> >A LaTeX macro can have at most nine 'regular' arguments, so something
> >like eleven fixed cells should do...
> >
> >An
Beck, Andrew Thomas - BECAT001 wrote:
> I had thought about this, but that would mean that nargs() returned 11
> rather than the actual number of valid arguments. Since one would only
> draw the valid arguments, I suspect we would see bugs similar to
> issues with the original patch for bug 2060.
>I just had a thought.
>
>Why not give the template a fixed numerb of cells gain.
>
>A LaTeX macro can have at most nine 'regular' arguments, so something
>like eleven fixed cells should do...
>
>Andre'
I had thought about this, but that would mean that nargs() returned 11
rather than the actua
On Sat, Jan 28, 2006 at 01:59:56PM +0100, Georg Baum wrote:
> Am Freitag, 27. Januar 2006 03:20 schrieb Beck, Andrew Thomas - BECAT001:
> > OK, here is a better formatted patch, preserving encoding etc. Thanks
> > for the feedback. The update is still being done in metrics() in the
> > same way tha
Am Montag, 30. Januar 2006 03:49 schrieb Beck, Andrew Thomas - BECAT001:
> >> --- text3.C 31 Dec 2005 11:40:32 - 1.323
> >> +++ text3.C 27 Jan 2006 02:06:30 -
> >> @@ -1254,10 +1254,10 @@
> >> else {
> >> string s = cmd.argument;
> >>
>> --- text3.C 31 Dec 2005 11:40:32 - 1.323
>> +++ text3.C 27 Jan 2006 02:06:30 -
>> @@ -1254,10 +1254,10 @@
>> else {
>> string s = cmd.argument;
>> string const s1 = token(s, ' ', 1);
>> - i
Am Freitag, 27. Januar 2006 03:20 schrieb Beck, Andrew Thomas - BECAT001:
> OK, here is a better formatted patch, preserving encoding etc. Thanks
> for the feedback. The update is still being done in metrics() in the
> same way that the macro expansion was being done previously. I have
> changed it
Title: RE: Renaming macros
OK, here is a better formatted patch, preserving encoding etc. Thanks
for the feedback. The update is still being done in metrics() in the
same way that the macro expansion was being done previously. I have
changed it to cast away the const-ness rather than make
On Thu, Jan 26, 2006 at 07:10:00AM +1030, Beck, Andrew Thomas - BECAT001 wrote:
> > Not in metrics. metrics is only there to compute and cache the size of
> > an inset.
> >
> > Provide some 'changeArgs' function or something like that.
> >
> > Andre'
>
> I agree metrics is not the place. However
Beck, Andrew Thomas - BECAT001 wrote:
> How do I know when these things have changed? I have essentially added
> more cells for the name & number of args to the macrotemplate class,
> allowing them to be edited directly, just like the expansion or display
> fields of the macro. In my mind, changin
Andrew> I agree metrics is not the place. However, at some point you
Andrew> need to go cycling through all insets to find the macro
Andrew> instantiations and call changeArgs(). You need to do this on
Andrew> the same kind of basis as updating the expansion - since both
Andrew> reflect changes in
> "Andrew" == "Beck, Andrew Thomas <- BECAT001" <[EMAIL PROTECTED]>> writes:
Andrew> I agree metrics is not the place. However, at some point you
Andrew> need to go cycling through all insets to find the macro
Andrew> instantiations and call changeArgs(). You need to do this on
Andrew> the sam
Beck, Andrew Thomas - BECAT001 wrote:
> Here is the patch as it stands. I'd be interested in comments.
OK, here you get some. The next time you send a patch please create a
unified diff with function names (write diff -up in your .cvsrc)
> One issue is that I've made cells_ mutable, which seems
Title: RE: Renaming macros
Here is the patch as it stands. I'd be interested in comments.
One issue is that I've made cells_ mutable, which seems dodgy.
Another is that the name & numArgs cells in macrotemplate are
just normal cells. I think they should be something th
> Not in metrics. metrics is only there to compute and cache the size of
> an inset.
>
> Provide some 'changeArgs' function or something like that.
>
> Andre'
I agree metrics is not the place. However, at some point you need to go
cycling through all insets to find the macro instantiations and c
On Wed, Jan 25, 2006 at 12:53:50PM +1030, Beck, Andrew Thomas - BECAT001
wrote:
> I am working on a patch for 1.4pre to allow renaming of macro
> templates and modifying the number of arguments. It all works, except
> the case that a macro template has already been instantiated within
> the text. S
16 matches
Mail list logo
