Beck, Andrew Thomas - BECAT001 wrote: > Here is the patch as it stands. I'd be interested in comments.
OK, here you get some. The next time you send a patch please create a unified diff with function names (write diff -up in your .cvsrc) > One issue is that I've made cells_ mutable, which seems dodgy. That is a bad hack, you could as well cast the constness away. This will create problems later, so you should find a solution without the need for this. > Another is that the name & numArgs cells in macrotemplate are > just normal cells. I think they should be something that only > allows macroargs & string text or numbers to guarantee a legal > value is entered. math macros have several design problems (search bugzilla for "macro" to see some reports). Since you seem to use them a lot you could maybe propose something better? > Index: text3.C > =================================================================== > RCS file: /var/cvs/lyx/lyx-devel/src/text3.C,v > retrieving revision 1.323 > diff -r1.323 text3.C > 7c7 > < * \author Lars Gullik Bjønnes > --- >> * \author Lars Gullik Bjnnes Please adjust your editor so that it does not change the encoding of the file. I don't have the time now to decipher the rest of the patch, so it would be nice if you could send an updated one without mutable cells in unified diff format. Georg
