Re: Questions regarding compiler warnings

2020-02-15 Thread Pavel Sanda
On Thu, Feb 13, 2020 at 06:28:05PM +0100, Jean-Marc Lasgouttes wrote: > >I can replace asserts with explicit checks if you agree. > >Or completely delete those checks because for most of them getStatus won't > >let > >you in without buffer anyway. > > Either solution will be OK. And do not forget

Re: Questions regarding compiler warnings

2020-02-13 Thread Scott Kostyshak
On Thu, Feb 13, 2020 at 10:39:29PM +0100, Stephan Witt wrote: > Am 13.02.2020 um 19:05 schrieb Scott Kostyshak : > > > > On Wed, Feb 12, 2020 at 08:45:56PM +0100, Stephan Witt wrote: > > > >> See the attached nice picture… > > > > This picture is great! Did you create it manually or is there som

Re: Questions regarding compiler warnings

2020-02-13 Thread Stephan Witt
Am 13.02.2020 um 19:05 schrieb Scott Kostyshak : > > On Wed, Feb 12, 2020 at 08:45:56PM +0100, Stephan Witt wrote: > >> See the attached nice picture… > > This picture is great! Did you create it manually or is there some sort > of magical static analysis tool that does this? It’s the result of

Re: Questions regarding compiler warnings

2020-02-13 Thread Scott Kostyshak
On Wed, Feb 12, 2020 at 08:45:56PM +0100, Stephan Witt wrote: > See the attached nice picture… This picture is great! Did you create it manually or is there some sort of magical static analysis tool that does this? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-d

Re: Questions regarding compiler warnings

2020-02-13 Thread Jean-Marc Lasgouttes
Le 13/02/2020 à 18:16, Pavel Sanda a écrit : On Wed, Feb 12, 2020 at 08:53:14PM +0100, Jean-Marc Lasgouttes wrote: 3. NULL pointer usage In GuiView::dispatchVC are different buffer pointer variables used. Sometimes there is an explicit check for NULL value. Sometimes there is an assertion with

Re: Questions regarding compiler warnings

2020-02-13 Thread Pavel Sanda
On Wed, Feb 12, 2020 at 08:53:14PM +0100, Jean-Marc Lasgouttes wrote: > >3. NULL pointer usage > > > >In GuiView::dispatchVC are different buffer pointer variables used. > >Sometimes there is an explicit check for NULL value. > >Sometimes there is an assertion with break or return for release build

Re: Questions regarding compiler warnings

2020-02-12 Thread Jean-Marc Lasgouttes
Le 12/02/2020 à 21:17, Stephan Witt a écrit : I don’t know what I’m talking about either. But, perhaps std::mem_fn is a possible replacement? https://en.cppreference.com/w/cpp/utility/functional/mem_fn I tried it, but it does not seems to work with std::not1. JMarc 2. various memory leak w

Re: Questions regarding compiler warnings

2020-02-12 Thread Stephan Witt
Am 12.02.2020 um 20:53 schrieb Jean-Marc Lasgouttes : > > Le 12/02/2020 à 20:45, Stephan Witt a écrit : >> Hi all, >> I've recently upgraded some parts of my tool box. I’m seeing new warnings >> now. >> 1. deprecated warning (removed with C++17?) >> lyx/src/insets/InsetCommandParams.cpp:596:9: wa

Re: Questions regarding compiler warnings

2020-02-12 Thread Jean-Marc Lasgouttes
Le 12/02/2020 à 20:45, Stephan Witt a écrit : Hi all, I've recently upgraded some parts of my tool box. I’m seeing new warnings now. 1. deprecated warning (removed with C++17?) lyx/src/insets/InsetCommandParams.cpp:596:9: warning: 'mem_fun_ref' is deprecated I already answered this one :)