Re: [PATCH] small qtabular fix

2005-09-27 Thread Jean-Marc Lasgouttes
>>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> this patch disables a widget in the qtabular dialog when Juergen> necessary. I'm just committing since this is obvious. OK. JMarc

[PATCH] small qtabular fix

2005-09-26 Thread Juergen Spitzmueller
this patch disables a widget in the qtabular dialog when necessary. I'm just committing since this is obvious. Jürgen Index: QTabular.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/qt2/QTabular.C,v retri

Re: [PATCH] QTabular

2002-11-28 Thread John Levon
On Thu, Nov 28, 2002 at 08:29:56PM +0100, Juergen Spitzmueller wrote: > So, without my color change, you would never ever see the grey color, because probably explains why it didn't seem to do much for me :) > I don't know. I have found this on qt-interest as a hint for similar cases. I > have

Re: [PATCH] QTabular

2002-11-28 Thread Juergen Spitzmueller
John Levon wrote: > but now they can't see which borders are actually set, regardless of > whether they can change them. A minor thing ... It is only inside a multicolumn. And there is no border to set/unset in the cases the widget is disabled (apart from column borders which can be toggled from

Re: [PATCH] QTabular

2002-11-28 Thread John Levon
hether they can change them. A minor thing ... > I have also managed to fix the setborder update problem (a repaint() call was > needed) I think this is wrong, perhaps qsetborder should be calling update() on itself. Explicit repaints shouldn't be needed... > So, qtabular c

Re: [PATCH] QTabular

2002-11-28 Thread Juergen Spitzmueller
int() call was needed) and added the readonly stuff. So, qtabular can be considered FINISHED :-) Regards, Jürgen Index: src/frontends/qt2/ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/ChangeLog,v retrieving revision 1.

Re: [PATCH] QTabular

2002-11-27 Thread John Levon
On Wed, Nov 27, 2002 at 10:01:52PM +0100, Juergen Spitzmueller wrote: > attached applying you should be able to dig the setEnabled stuff out of the attached regards john -- "Millions of fingers! Millions of thumbs! Millions of monkeys Drumming on drums!" Index: qsetborder.C ==

Re: [PATCH] QTabular

2002-11-27 Thread Juergen Spitzmueller
John Levon wrote: > please re diff (sorry) attached (note that I have also modified one of your changes) Jürgen. Index: src/frontends/qt2/ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/ChangeLog,v retrieving revision 1.

Re: Qtabular

2002-11-27 Thread Juergen Spitzmueller
ck my cleanups I'll do (but they look o.k. at first view) > is anything left to do with qtabular ? If my second patch (which I'll rediff now) is in: the qsetborder update problem. Thanks, Jürgen. > regards > john

Re: [PATCH] QTabular

2002-11-27 Thread John Levon
On Wed, Nov 27, 2002 at 09:07:07PM +0100, Juergen Spitzmueller wrote: > fixed. please re diff (sorry) john -- "Millions of fingers! Millions of thumbs! Millions of monkeys Drumming on drums!"

Qtabular

2002-11-27 Thread John Levon
ved, if we need it also can you please double check my cleanups is anything left to do with qtabular ? regards john -- "Millions of fingers! Millions of thumbs! Millions of monkeys Drumming on drums!"

Re: [PATCH] QTabular

2002-11-27 Thread Juergen Spitzmueller
19:52:11 @@ -1,6 +1,12 @@ 2002-11-27 Juergen Spitzmueller <[EMAIL PROTECTED]> * ui/TabularDialog.ui + * QTabular.C + * QTabularDialog.C: ui fixes. + +2002-11-27 Juergen Spitzmueller <[EMAIL PROTECTED]> + + * ui/TabularDialog.ui * QTabular.[Ch] * QTabularDialog.[Ch]: impleme

[PATCH] QTabular

2002-11-27 Thread Juergen Spitzmueller
I have implemented all functions. Please apply. A few problems are still there. I need help here: 1.) qsetborder: we need some kind of setEnabled method here, because in multicolumn cells, left and right borders are only allowed in some places (see FIXMEs). Edwin, any idea? 2.) qsetborder is

Re: qtabular does not differentiate between cell/selection

2002-11-16 Thread John Levon
On Fri, Nov 15, 2002 at 08:57:21PM +0100, Edwin Leuven wrote: > > There are two sets of things for stuff like borders and alignment, > > which behave differently. Edwin what were you planning here ? > > you mean with QTabularDialog.ui? Write the controller in such a way that it > can work on t

Re: qtabular does not differentiate between cell/selection

2002-11-15 Thread Edwin Leuven
> There are two sets of things for stuff like borders and alignment, > which behave differently. Edwin what were you planning here ? you mean with QTabularDialog.ui? Write the controller in such a way that it can work on the selection or in case of no selection the active cell. f.e. when setLe

qtabular does not differentiate between cell/selection

2002-11-14 Thread John Levon
There are two sets of things for stuff like borders and alignment, which behave differently. Edwin what were you planning here ? btw, the widget names are very inconsistent: LongtabularCB vs. rotateCellCB etc. Can you fix this please. regards john -- Khendon's Law: If the same point is made t