Re: QProcess::startCommand deprecation

2021-05-21 Thread Jürgen Spitzmüller
Am Freitag, dem 21.05.2021 um 10:31 +0200 schrieb Jean-Marc Lasgouttes: > The code is still here, so the question is relevant. It is not a bug > though, it just seems to me that the code is needlessly complicated. I cannot remember why I did that. I would need to investigate as well. Should have

Re: QProcess::startCommand deprecation

2021-05-21 Thread Jean-Marc Lasgouttes
Le 21/05/2021 à 08:13, Jürgen Spitzmüller a écrit : Am Donnerstag, dem 20.05.2021 um 12:44 +0200 schrieb Jean-Marc Lasgouttes: The new code seems safe enough. I just have a question. Why the test for size == 1 below: if (arguments.size() == 1) arguments.clear();   

Re: QProcess::startCommand deprecation

2021-05-20 Thread Jürgen Spitzmüller
Am Donnerstag, dem 20.05.2021 um 12:44 +0200 schrieb Jean-Marc Lasgouttes: > The new code seems safe enough. I just have a question. Why the test > for > size == 1 below: > if (arguments.size() == 1) > arguments.clear(); > else if (!arguments.empty()) >

Re: QProcess::startCommand deprecation

2021-05-20 Thread Jean-Marc Lasgouttes
Le 18/05/2021 à 11:02, Jean-Marc Lasgouttes a écrit : Hi, I have been looking at backporting the following commit to stble (the last warning I see): commit 9f92fc92bdd41c367b0975454a01c15403d51a60 Author: Juergen Spitzmueller Date:   Fri Mar 12 12:14:42 2021 +0100     Yet another deprecati

Re: QProcess::startCommand deprecation

2021-05-20 Thread Jean-Marc Lasgouttes
Le 18/05/2021 à 15:57, Jürgen Spitzmüller a écrit : Am Dienstag, dem 18.05.2021 um 15:48 +0200 schrieb Jean-Marc Lasgouttes: Both versions of QProcess::startDetached, depending on wherther Qt>= 5.15 or not (I can see that we can get rid of it when we are limited to Qt >= 5.15, but you see my poi

Re: QProcess::startCommand deprecation

2021-05-18 Thread Richard Kimberly Heck
On 5/18/21 9:49 AM, Jean-Marc Lasgouttes wrote: > Le 18/05/2021 à 15:25, Jürgen Spitzmüller a écrit : >> Am Dienstag, dem 18.05.2021 um 14:27 +0200 schrieb Jean-Marc >> Lasgouttes: >>> In this case, having a single code path is a good thing IMO. Do we >>> want >>> to keep both versions until Qt5 su

Re: QProcess::startCommand deprecation

2021-05-18 Thread Jean-Marc Lasgouttes
Le 18/05/2021 à 15:25, Jürgen Spitzmüller a écrit : Am Dienstag, dem 18.05.2021 um 14:27 +0200 schrieb Jean-Marc Lasgouttes: In this case, having a single code path is a good thing IMO. Do we want to keep both versions until Qt5 support is deleted? What do you mean by "both versions"? Before

Re: QProcess::startCommand deprecation

2021-05-18 Thread Jürgen Spitzmüller
Am Dienstag, dem 18.05.2021 um 14:27 +0200 schrieb Jean-Marc Lasgouttes: > In this case, having a single code path is a good thing IMO. Do we > want > to keep both versions until Qt5 support is deleted? What do you mean by "both versions"? Jürgen signature.asc Description: This is a digitally

Re: QProcess::startCommand deprecation

2021-05-18 Thread Jean-Marc Lasgouttes
Le 18/05/2021 à 13:52, Jürgen Spitzmüller a écrit : I think that having the correct bounds will help us in the long term. I think my rationale was to play safe and keep the deprecated function until it was marked deprecated. In this case, having a single code path is a good thing IMO. Do we w

Re: QProcess::startCommand deprecation

2021-05-18 Thread Jürgen Spitzmüller
Am Dienstag, dem 18.05.2021 um 11:02 +0200 schrieb Jean-Marc Lasgouttes: > I have been looking at backporting the following commit to stble (the > last warning I see): > > commit 9f92fc92bdd41c367b0975454a01c15403d51a60 > Author: Juergen Spitzmueller > Date:   Fri Mar 12 12:14:42 2021 +0100 > >

QProcess::startCommand deprecation

2021-05-18 Thread Jean-Marc Lasgouttes
Hi, I have been looking at backporting the following commit to stble (the last warning I see): commit 9f92fc92bdd41c367b0975454a01c15403d51a60 Author: Juergen Spitzmueller Date: Fri Mar 12 12:14:42 2021 +0100 Yet another deprecation fix (this is the last one I am aware of) This uses