Le 18/05/2021 à 15:57, Jürgen Spitzmüller a écrit :
Am Dienstag, dem 18.05.2021 um 15:48 +0200 schrieb Jean-Marc
Lasgouttes:
Both versions of QProcess::startDetached, depending on wherther Qt>=
5.15 or not (I can see that we can get rid of it when we are limited
to
Qt >= 5.15, but you see my point).

I am fine with using QProcess::startDetached(cmd, args) only. I was
just extra-cautious not to change more than needed.

Please go ahead with that. I don't have the time currently do dig into
this myself.

The new code seems safe enough. I just have a question. Why the test for size == 1 below:
        if (arguments.size() == 1)
                arguments.clear();
        else if (!arguments.empty())
                arguments.removeFirst();

I would just do:
        if (!arguments.empty())
                arguments.removeFirst();

Would it be wrong? Is there some QStringList peculiarity I do not know about?

JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to