Re: Playing with insettabular

2001-01-29 Thread Jean-Marc Lasgouttes
> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: Dekel> I used 'relatively' because any change can potentially create Dekel> new bugs, but I'm quite sure that this is not the case here. Dekel> The patch really simplifies the use of insettabular, so maybe Dekel> we should put it in 1.1.6 (w

Re: Playing with insettabular

2001-01-27 Thread Dekel Tsur
On Fri, Jan 26, 2001 at 09:16:07AM +0100, Juergen Vigna wrote: > > On 25-Jan-2001 Dekel Tsur wrote: > > > > I think it is relatively safe. > > Well relatively? I think we should left it for 1.2.0 only! I used 'relatively' because any change can potentially create new bugs, but I'm quite sure t

Re: Playing with insettabular

2001-01-26 Thread Juergen Vigna
On 25-Jan-2001 Dekel Tsur wrote: > > I think it is relatively safe. > Well relatively? I think we should left it for 1.2.0 only! > Also, what about changing LyXTabular::Write to output only the attributes > whose value is not the default value (and so reducing the file size) ? No I don't thi

Re: Playing with insettabular

2001-01-25 Thread Jean-Marc Lasgouttes
> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: Dekel> Also, what about changing LyXTabular::Write to output only the Dekel> attributes whose value is not the default value (and so Dekel> reducing the file size) ? This is OK if we are sure the default values will not change later. JMarc

Re: Playing with insettabular

2001-01-25 Thread Dekel Tsur
On Wed, Jan 24, 2001 at 12:52:05PM +0100, Juergen Vigna wrote: > > On 24-Jan-2001 Jean-Marc Lasgouttes wrote: > > > > I do not have it anymore, but please only apply it if it is safe and > > straightforward enough... In an ideal world, I'd only apply one-liners > >:) [in fact, the two important

Re: Playing with insettabular

2001-01-24 Thread Juergen Vigna
On 24-Jan-2001 Jean-Marc Lasgouttes wrote: > > I do not have it anymore, but please only apply it if it is safe and > straightforward enough... In an ideal world, I'd only apply one-liners >:) [in fact, the two important bug fixes we have are one-liners] Well it surely is no oneliner :), but De

Re: Playing with insettabular

2001-01-24 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> Well it's a change of behaviour, but IMO we could also apply Juergen> the patch for the 1_1_6 branch. Do you still have the file Juergen> Dekel sent? Or should I download the 1_1_6 branch and apply Juergen> it there? I do not

Re: Playing with insettabular

2001-01-24 Thread Juergen Vigna
On 24-Jan-2001 Jean-Marc Lasgouttes wrote: >> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: > > Juergen> I did apply the patch and it seems to work good. I'll commit > Juergen> this as I see that it simplifies the code and that is > Juergen> neccessary if we later go for an speed op

Re: Playing with insettabular

2001-01-24 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: Juergen> I did apply the patch and it seems to work good. I'll commit Juergen> this as I see that it simplifies the code and that is Juergen> neccessary if we later go for an speed optimizing. Juergen, do you have simple and straightfo

Re: Playing with insettabular

2001-01-24 Thread Juergen Vigna
On 12-Jan-2001 Dekel Tsur wrote: > > A little more playing, and I got the following improvement: > If the cursor is in an insettext in a cell of a tabular, and the user presses > down, the cursor will enter the insettext of the cell below, keeping the x > position as it had before (as much as po

Re: Playing with insettabular

2001-01-12 Thread Dekel Tsur
On Fri, Jan 12, 2001 at 11:38:02PM +0200, Dekel Tsur wrote: > I got annoyed by the cursor handling in insettabular, i.e. the two dummy > position in each cell, one before the insettext and one after. > So I decided to change that and use only one dummy position. > I think that the result is more i

Playing with insettabular

2001-01-12 Thread Dekel Tsur
I got annoyed by the cursor handling in insettabular, i.e. the two dummy position in each cell, one before the insettext and one after. So I decided to change that and use only one dummy position. I think that the result is more intuitive to the user. What do other think ? Of course, this patch s