Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 05:13:56PM +0100, Lars Gullik Bjønnes wrote: > Especially not for stuff that is main tasks for the next development > round. hmm. This would mean you would have to accept patches that are not perfect. I've tried to look for ways to do the Andre thing of small gradual cha

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | So perhaps we should make a branch now yes. Especially as I appear to | have exhausted my supply of 1.2 bugfixes... > | I expect the branch will last 6 months or so before the interfaces are | good enough to hit the main tree but I suppose that depends on

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 03:59:11PM +, Angus Leeming wrote: > Sure it is. This stuff _should_ go in a branch. Then we can hack away > happily. Yeah but I don't want to spend ages merging. You had enough trouble with that during MVC branch, from the sounds of it. Of course the branch will h

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 3:41 pm, John Levon wrote: > On Wed, Mar 13, 2002 at 02:50:41PM +, Angus Leeming wrote: > > > Along the same lines, can you try my BufferView_pimpl.C patch in your tree > > "proposed cursor patch try 2". Presumably those fl_set_cursor calls should > > become cal

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 02:50:41PM +, Angus Leeming wrote: > Along the same lines, can you try my BufferView_pimpl.C patch in your tree > "proposed cursor patch try 2". Presumably those fl_set_cursor calls should > become calls to a new WorkArea method? I suspect so, but I'm not sure what

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 03:47:33PM +0100, Lars Gullik Bjønnes wrote: > Yup. OK -- I am a complete moron for forgetting about endianness. May I be forever marked as such.

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 2:42 pm, John Levon wrote: > On Wed, Mar 13, 2002 at 01:25:14PM +0100, Lars Gullik Bjønnes wrote: > > > These are the changes I have in my tree now: > > > > Index: PainterBase.C > > I can't help but think that you committed this thoroughly > cosmetic patch just to mak

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | I can't help but think that you committed this thoroughly | cosmetic patch just to make my life harder. Yup. -- Lgb

Re: Painter diff

2002-03-13 Thread John Levon
On Wed, Mar 13, 2002 at 01:25:14PM +0100, Lars Gullik Bjønnes wrote: > These are the changes I have in my tree now: > > Index: PainterBase.C I can't help but think that you committed this thoroughly cosmetic patch just to make my life harder. john -- I am a complete moron for forgetting abou

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Yes. In this case I think that the helper function isn't a help. I have yet another patch for you too look at, the thing missing now is to get rid of the XChar2b stuff. We want to use wchar_t in interfaces. (and if wchar_t is not supported, then we sho

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 12:55 pm, Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > > | Angus Leeming <[EMAIL PROTECTED]> writes: > > > | | On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: > >> > >>> Index: Painter.h > >>> ===

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Angus Leeming <[EMAIL PROTECTED]> writes: > | | On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: >> >>> Index: Painter.h >>> === >>> private: >>> + /// For the figin

Re: Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: > >> Index: Painter.h >> === >> private: >> +/// For the figinset >> +PainterBase & pixmap(int x, int y, int w, int

Re: Painter diff

2002-03-13 Thread Angus Leeming
On Wednesday 13 March 2002 12:25 pm, Lars Gullik Bjønnes wrote: > Index: Painter.h > === > private: > + /// For the figinset > + PainterBase & pixmap(int x, int y, int w, int h, Pixmap bitmap); > + Errr, why? Helper fu

Painter diff

2002-03-13 Thread Lars Gullik Bjønnes
These are the changes I have in my tree now: Index: PainterBase.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/PainterBase.C,v retrieving revision 1.10 diff -u -p -r1.10 PainterBase.C --- PainterBase.C 30 Jul 2001 11:55: