Re: 1.5 features (was Re: [Patches] Re: Outlining for 1.4)

2006-04-28 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: > - Juergen's optimisation work on Natbib (is it in yet?) It's in trunk, yes. Not yet in 1.4.x, though. Jürgen

1.5 features (was Re: [Patches] Re: Outlining for 1.4)

2006-04-28 Thread Abdelrazak Younes
Georg Baum a écrit : Andre Poenitz wrote: I thought there had been file format changes which we want to avoid in subminor releases. No file format changes have happened yet. So what about listing some of the 1.5svn new feature/optimization and see if there's enough to justify a release, of

Re: [Patches] Re: Outlining for 1.4

2006-04-28 Thread Georg Baum
Andre Poenitz wrote: > I thought there had been file format changes which we want to avoid in > subminor releases. No file format changes have happened yet. Georg

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Martin Vermeer
On Thu, 2006-04-27 at 20:51 +0200, Michael Gerz wrote: > Abdelrazak Younes wrote: > > >> I noticed that the 1.4 environment has already diverged quite a lot from > >> 1.5, so this needs to get some thorough testing of its own. E.g., > >> non-numbered headers are _not_ part of the ToC here. > > > >

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Michael Gerz
Abdelrazak Younes wrote: I noticed that the 1.4 environment has already diverged quite a lot from 1.5, so this needs to get some thorough testing of its own. E.g., non-numbered headers are _not_ part of the ToC here. IMHO, 1.5 has diverged too much already and have some additional features al

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | Same here. But Lars has a personal tree on this, which looks sort-of | impressive. Why not just put this into trunk after 1.4.2 is out? How | functional is it? Huh? Have you had a look at it? Far from impressive... -- Lgb

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, Apr 27, 2006 at 09:35:16AM +0200, Abdelrazak Younes wrote: | > IMHO, 1.5 has diverged too much already and have some additional | > features already so we should keep this feature as 1.5 and release it | > sooner than later. As far as I know, 1

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Andre Poenitz
On Thu, Apr 27, 2006 at 09:35:16AM +0200, Abdelrazak Younes wrote: > IMHO, 1.5 has diverged too much already and have some additional > features already so we should keep this feature as 1.5 and release it > sooner than later. As far as I know, 1.5 is as stable as 1.4 if not > stabler. But we c

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Andre Poenitz
On Thu, Apr 27, 2006 at 10:26:28AM +0200, Abdelrazak Younes wrote: > Well, we could well decide to do unicode in 1.6 as I don't see anything > happening in trunk as of now. My point is that 1.5 is very nice as it is > and users deserves it. It unicode is going to destabilize trunk for a > year o

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Andre Poenitz
On Thu, Apr 27, 2006 at 12:28:18PM +0300, Martin Vermeer wrote: > > Well, we could well decide to do unicode in 1.6 as I don't see anything > > happening in trunk as of now. My point is that 1.5 is very nice as it is > > and users deserves it. > > If that is really the case, it should be releas

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Georg Baum
Martin Vermeer wrote: > On Thu, 2006-04-27 at 10:26 +0200, Abdelrazak Younes wrote: >> Well, we could well decide to do unicode in 1.6 as I don't see anything >> happening in trunk as of now. My point is that 1.5 is very nice as it is >> and users deserves it. > > If that is really the case, it s

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Martin Vermeer
On Thu, 2006-04-27 at 10:26 +0200, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes a écrit : > >> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > > Abdelrazak> IMHO, 1.5 has diverged too much already and have some > > Abdelrazak> additional features already so we should kee

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMHO, 1.5 has diverged too much already and have some Abdelrazak> additional features already so we should keep this feature Abdelrazak> as 1.5 and release it sooner than later. As far as I know, Abdelrazak> 1.5 is as

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Thu, Apr 27, 2006 at 07:49:45AM +0300, Martin Vermeer wrote: On Wed, Apr 26, 2006 at 11:19:02PM +0200, Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Committed to trunk: Martin> Outlining improvements/fixes Do you t

Re: [Patches] Re: Outlining for 1.4

2006-04-27 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> IMHO, 1.5 has diverged too much already and have some Abdelrazak> additional features already so we should keep this feature Abdelrazak> as 1.5 and release it sooner than later. As far as I

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Martin Vermeer
On Thu, Apr 27, 2006 at 07:49:45AM +0300, Martin Vermeer wrote: > On Wed, Apr 26, 2006 at 11:19:02PM +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> Committed to trunk: > > > > Martin> Outlining improvements/fixes > > > > Do

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Martin Vermeer
On Wed, Apr 26, 2006 at 11:19:02PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Committed to trunk: > > Martin> Outlining improvements/fixes > > Do you think the corresponding 1.4 patch could go in for 1.4.2? I would have t

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Committed to trunk: Martin> Outlining improvements/fixes Do you think the corresponding 1.4 patch could go in for 1.4.2? Or are there things that are not ready for public consumption? JMarc

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Wed, Apr 26, 2006 at 03:49:20PM +0200, Abdelrazak Younes wrote: Georg Baum a écrit : Abdelrazak Younes wrote: I'll do that. Georg, maybe it's a good idea to set the svn-eol thing on this file or is it something I can do myself? You can do that yourself (and should

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Andre Poenitz
On Wed, Apr 26, 2006 at 03:49:20PM +0200, Abdelrazak Younes wrote: > Georg Baum a écrit : > >Abdelrazak Younes wrote: > > > >>I'll do that. Georg, maybe it's a good idea to set the svn-eol thing on > >>this file or is it something I can do myself? > > > >You can do that yourself (and should have do

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Martin Vermeer
On Wed, Apr 26, 2006 at 03:28:28PM +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : ... > >Attached. This will go in soon unless somebody spots a problem. > > It looks good to me. Good job. Committed to trunk: Outlining improvements/fixes * LyXAction.C (LyXAc

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Georg Baum a écrit : You can do that yourself (and should have done when you added it): Sorry boss. I am fortunately not the boss :-) In case I sounded rude: That was not intended at all, it should have been just a friendly reminder. No PB, I

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum a écrit : >> You can do that yourself (and should have done when you added it): > > Sorry boss. I am fortunately not the boss :-) In case I sounded rude: That was not intended at all, it should have been just a friendly reminder. Georg

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Angus Leeming a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: I'll do that. Georg, maybe it's a good idea to set the svn-eol thing on this file or is it something I can do myself? Why not write a little script to clean up line endings before you commit and just get used to using it?

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > I'll do that. Georg, maybe it's a good idea to set the svn-eol thing on > this file or is it something I can do myself? Why not write a little script to clean up line endings before you commit and just get used to using it? dos2unix.sed: /^M$// u

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: I'll do that. Georg, maybe it's a good idea to set the svn-eol thing on this file or is it something I can do myself? You can do that yourself (and should have done when you added it): Sorry boss. svn propset svn:eol-style native TocBackend.h

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Georg Baum
Abdelrazak Younes wrote: > I'll do that. Georg, maybe it's a good idea to set the svn-eol thing on > this file or is it something I can do myself? You can do that yourself (and should have done when you added it): svn propset svn:eol-style native TocBackend.h TocBackend.C svn commit TocBackend.h

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : PS will somebody please get rid of the ^M in TocBackend.h! I'll do that. done in TocBackend.[Ch] Georg, maybe it's a good idea to set the svn-eol thing on this file or is it something I can do myself? Abdel.

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Wed, 2006-04-26 at 13:56 +0300, Martin Vermeer wrote: On Wed, 2006-04-26 at 11:07 +0200, Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> 1) unnumbered sections will be transformed into a numbered Abdelrazak> sect

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Martin Vermeer
On Wed, 2006-04-26 at 13:56 +0300, Martin Vermeer wrote: > On Wed, 2006-04-26 at 11:07 +0200, Jean-Marc Lasgouttes wrote: > > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > > Abdelrazak> 1) unnumbered sections will be transformed into a numbered > > Abdelrazak> section i

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Martin Vermeer
On Wed, 2006-04-26 at 11:07 +0200, Jean-Marc Lasgouttes wrote: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> 1) unnumbered sections will be transformed into a numbered > Abdelrazak> section if you use IN and OUT. > > This is probably a consequence of a cha

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Yes we should do that. I propose that Martin commit his Abdelrazak> patch (maybe minus the nested switch in LFUN_etc) and I'll Abdelrazak> see what I can do if Martin does not have time to do it. Yes. JMarc

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> 1) unnumbered sections will be transformed into a numbered Abdelrazak> section if you use IN and OUT. This is probably a consequence of a change we did to layout files recently. Now unnum

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Martin Vermeer
On Wed, 2006-04-26 at 10:47 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > Martin> Should be strai

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> 1) unnumbered sections will be transformed into a numbered Abdelrazak> section if you use IN and OUT. This is probably a consequence of a change we did to layout files recently. Now unnumbered sections in many layout

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Tue, Apr 25, 2006 at 12:46:42PM +0300, Martin Vermeer wrote: On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Should be straightforward. What about Martin> LFUN_OUTLINE_{UP|DOWN|IN|OUT}? Fo

Re: [Patches] Re: Outlining for 1.4

2006-04-26 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Martin> Should be straightforward. What about Martin> LFUN_OUTLINE_{UP|DOWN|IN|OUT}? For now. >>

Re: [Patches] Re: Outlining for 1.4

2006-04-25 Thread Martin Vermeer
On Tue, Apr 25, 2006 at 12:46:42PM +0300, Martin Vermeer wrote: > On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> Should be straightforward. What about > > Martin> LFUN_OUTLINE_{UP|DOWN|IN|OUT}? For now

Re: [Patches] Re: Outlining for 1.4

2006-04-25 Thread Abdelrazak Younes
hum... Abdelrazak Younes a écrit : But that would lead to quite some duplication of code. Are you sure? The switch cases in toc::outline() seems pretty self-contained for me. The switch cases _seem_ pretty self-contained _to_ me. Sure but I not am sure "outline" is the correct name for man

Re: [Patches] Re: Outlining for 1.4

2006-04-25 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Tue, 2006-04-25 at 12:04 +0200, Abdelrazak Younes wrote: Martin Vermeer a écrit : On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Should be straightforward. What about Martin> LFUN_OUTLIN

Re: [Patches] Re: Outlining for 1.4

2006-04-25 Thread Martin Vermeer
On Tue, 2006-04-25 at 12:04 +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > > On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: > >>> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> Martin> Should be straightforward. What about > >> Martin> LFUN_OUTLINE_{UP

Re: [Patches] Re: Outlining for 1.4

2006-04-25 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Should be straightforward. What about Martin> LFUN_OUTLINE_{UP|DOWN|IN|OUT}? For now. Sure why not. Martin> To make sure we have a valid curso

[Patches] Re: Outlining for 1.4

2006-04-25 Thread Martin Vermeer
On Tue, 2006-04-25 at 10:40 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Should be straightforward. What about > Martin> LFUN_OUTLINE_{UP|DOWN|IN|OUT}? For now. > > Sure why not. > > Martin> To make sure we have a valid cursor afte

Re: Outlining for 1.4

2006-04-25 Thread Abdelrazak Younes
Martin Vermeer a écrit : On Mon, Apr 24, 2006 at 05:35:36PM +0200, Abdelrazak Younes wrote: Jean-Marc Lasgouttes a écrit : [...] +void outline(OutlineOp mode, Buffer * buf, pit_type & pit) +{ + ParagraphList & pars = buf->text().paragraphs(); Why not pass a cursor directly? What is th

Re: Outlining for 1.4

2006-04-25 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Should be straightforward. What about Martin> LFUN_OUTLINE_{UP|DOWN|IN|OUT}? For now. Sure why not. Martin> To make sure we have a valid cursor after the doc change? That is probably true indeed. >> IMHO, at least the last po

Re: Outlining for 1.4

2006-04-24 Thread Martin Vermeer
On Mon, Apr 24, 2006 at 05:35:36PM +0200, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes a écrit : > >>"Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > [...] > > + case LFUN_OUTLINE: { > > + lyx::toc::OutlineOp const op = > > + > > static_cast(convert(cmd.ar

Re: Outlining for 1.4

2006-04-24 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: [...] + case LFUN_OUTLINE: { + lyx::toc::OutlineOp const op = + static_cast(convert(cmd.argument)); + lyx::toc::outline(op, buffer_, cursor_.pit()); So thi

Re: Outlining for 1.4

2006-04-24 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Then you want this patch. Has the inside-inset crash fixed and Martin> outlining buttons disabled for non-ToC. Abdel claims that Martin> there should still be a crash in this (related to "illegal" Martin> counters like 1.0.5). T

Re: Outlining for 1.4 (was: ...)

2006-04-24 Thread Martin Vermeer
On Mon, Apr 24, 2006 at 10:07:43AM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> No it isn't. I suppose you can take all outline-related > Martin> patches with my name on it, plus lower-case some occurrences > Martin> of Outline. > >

Re: [Patch] Outlining for 1.4.x

2006-04-19 Thread Martin Vermeer
On Wed, 2006-04-19 at 10:28 +0200, Abdelrazak Younes wrote: > Martin Vermeer a écrit : > > Attached, trying to take into account discussions since. > > > > OK to commit? No document format change, and I don't expect the user > > base will want to wait until 1.5 ;-) > > Martin, please have a look

Re: [Patch] Outlining for 1.4.x

2006-04-19 Thread Abdelrazak Younes
Martin Vermeer a écrit : Attached, trying to take into account discussions since. OK to commit? No document format change, and I don't expect the user base will want to wait until 1.5 ;-) Martin, please have a look at the new ControlToc::canOutline() method. Im 1.5svn you get a crash if you t

Re: [Patch] Outlining for 1.4.x

2006-04-18 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | Attached, trying to take into account discussions since. | | OK to commit? No document format change, and I don't expect the user | base will want to wait until 1.5 ;-) Applying things to 1.4.x does not depend on the user base. IMHO it should wait.

[Patch] Outlining for 1.4.x

2006-04-18 Thread Martin Vermeer
Attached, trying to take into account discussions since. OK to commit? No document format change, and I don't expect the user base will want to wait until 1.5 ;-) - Martin Index: LyXAction.C === --- LyXAction.C (revision 13690) +++