Re: Metrics-related crashes in branch

2025-02-20 Thread Jean-Marc Lasgouttes
Le 29/01/2025 à 14:18, Pavel Sanda a écrit : JMarc, unless you have some other fix in mind we should perhaps backport? I have backported the two patches now. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Metrics-related crashes in branch

2025-02-10 Thread Jean-Marc Lasgouttes
Le 10/02/2025 à 22:41, Pavel Sanda a écrit : On Mon, Feb 10, 2025 at 12:42:05AM +0100, Jean-Marc Lasgouttes wrote: I mean try it on 8a181862d. I suspect this is the core reason for the crashes. If this is the case, the patch could be applied in addition to the others. I can confirm that with y

Re: Metrics-related crashes in branch

2025-02-10 Thread Pavel Sanda
On Mon, Feb 10, 2025 at 12:42:05AM +0100, Jean-Marc Lasgouttes wrote: > I mean try it on 8a181862d. I suspect this is the core reason for the > crashes. If this is the case, the patch could be applied in addition to the > others. I can confirm that with your posted patch, 8a181862d does not crash

Re: Metrics-related crashes in branch

2025-02-09 Thread Pavel Sanda
On Sat, Feb 08, 2025 at 09:21:33PM +0100, Jean-Marc Lasgouttes wrote: > Le 11/01/2025 ?? 23:53, Pavel Sanda a écrit : > > checkout the commit 8a181862d > > 0) load the file I sent you earlier > > 1) set cursor on line 1.4 > > 2) scroll 1.4 it to be the last line of the screen > > 3) close lyx > > 4

Re: Metrics-related crashes in branch

2025-02-08 Thread Jean-Marc Lasgouttes
Le 11/01/2025 à 23:53, Pavel Sanda a écrit : checkout the commit 8a181862d 0) load the file I sent you earlier 1) set cursor on line 1.4 2) scroll 1.4 it to be the last line of the screen 3) close lyx 4) remove figure cache 5) relaunch lyx & wait for figures on screen to load if not crash got

Re: Metrics-related crashes in branch

2025-01-29 Thread Pavel Sanda
On Thu, Jan 09, 2025 at 03:22:34PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/12/2024 ?? 19:15, Pavel Sanda a écrit : > > Actually you are right, once the figures are loaded, the caret tends to > > stay on similar position of the screen. But not initially, it probably > > gets shifted by the onload

Re: Metrics-related crashes in branch

2025-01-11 Thread Pavel Sanda
On Fri, Jan 10, 2025 at 11:23:09AM +0100, Pavel Sanda wrote: > As it happens I have troubles to get my own recipy reliably working in > (unupdated) > master (mainly due to the fact that I can't get the pg-down to jump to first > line > of 1.4 anymore. Ok, I could find new recipy for the crash in

Re: Metrics-related crashes in branch

2025-01-10 Thread Pavel Sanda
On Thu, Jan 09, 2025 at 03:22:34PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/12/2024 ?? 19:15, Pavel Sanda a écrit : > > Actually you are right, once the figures are loaded, the caret tends to > > stay on similar position of the screen. But not initially, it probably > > gets shifted by the onload

Re: Metrics-related crashes in branch

2025-01-09 Thread Jean-Marc Lasgouttes
Le 21/12/2024 à 19:15, Pavel Sanda a écrit : Actually you are right, once the figures are loaded, the caret tends to stay on similar position of the screen. But not initially, it probably gets shifted by the onloading of images above. I pushed a solution to master at 0fa3aba5c6e, if it works we

Re: Metrics-related crashes in branch

2024-12-21 Thread Pavel Sanda
On Sat, Dec 21, 2024 at 06:38:52PM +0100, Pavel Sanda wrote: > On Sat, Dec 21, 2024 at 03:06:25PM +0100, Jean-Marc Lasgouttes wrote: > > Le 20/12/2024 ?? 21:42, Pavel Sanda a écrit : > > > Not with our docs, but see the archive I sent you privately. > > > > > > 0) unpack the archive > > > 1) open

Re: Metrics-related crashes in branch

2024-12-21 Thread Pavel Sanda
On Sat, Dec 21, 2024 at 03:06:25PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/12/2024 ?? 21:42, Pavel Sanda a écrit : > > Not with our docs, but see the archive I sent you privately. > > > > 0) unpack the archive > > 1) open the lyx file > > 2) the geometry of the window has to be so that first li

Re: Metrics-related crashes in branch

2024-12-21 Thread Jean-Marc Lasgouttes
Le 20/12/2024 à 21:42, Pavel Sanda a écrit : Not with our docs, but see the archive I sent you privately. 0) unpack the archive 1) open the lyx file 2) the geometry of the window has to be so that first line of section 1.1.1 is approx at the bottom of the window. see cursor.jpg screenshot. 2) c

Re: Metrics-related crashes in branch

2024-12-20 Thread Pavel Sanda
On Fri, Dec 20, 2024 at 11:12:13PM +0100, Jean-Marc Lasgouttes wrote: > What I want is to find where the missing update is. Thanks :) > But it is on branch too, right? I removed less updates there, it should be > less fragile than master. Right, I originally got the problem in the branch. The or

Re: Metrics-related crashes in branch

2024-12-20 Thread Jean-Marc Lasgouttes
Le 20/12/2024 à 21:42, Pavel Sanda a écrit : On Fri, Dec 20, 2024 at 04:07:03PM +0100, Jean-Marc Lasgouttes wrote: Does this new patch help? It contains the previous one. Yes, I can confirm that this patch "fixes" the assertion. Can you give me a recipe using one of our documentation files,

Re: Metrics-related crashes in branch

2024-12-20 Thread Pavel Sanda
On Fri, Dec 20, 2024 at 04:07:03PM +0100, Jean-Marc Lasgouttes wrote: > Does this new patch help? It contains the previous one. Yes, I can confirm that this patch "fixes" the assertion. > Can you give me a recipe using one of our documentation files, for example? Not with our docs, but see the a

Re: Metrics-related crashes in branch

2024-12-20 Thread Jean-Marc Lasgouttes
Le 20/12/2024 à 01:25, Pavel Sanda a écrit : On Wed, Dec 18, 2024 at 02:08:13PM +0100, Jean-Marc Lasgouttes wrote: Thanks for the backtrace. So is it only a thing in branch? Note that the assertion in ParagraphMetrics::position() is new, so this might be an old problem that we detect only now.

Re: Metrics-related crashes in branch

2024-12-19 Thread Pavel Sanda
On Wed, Dec 18, 2024 at 02:08:13PM +0100, Jean-Marc Lasgouttes wrote: > > Thanks for the backtrace. So is it only a thing in branch? Note that the > > assertion in ParagraphMetrics::position() is new, so this might be an > > old problem that we detect only now. > > The patch below should fix the s

Re: Metrics-related crashes in branch

2024-12-18 Thread Jean-Marc Lasgouttes
Le 18/12/2024 à 17:07, Pavel Sanda a écrit : Could you also confirm whether this is branch-only ? This would be surprising and point to a missing update somewhere, requiring a different approach. It's difficult to make some reliable statement for both questions. I'll try to come up with somethi

Re: Metrics-related crashes in branch

2024-12-18 Thread Pavel Sanda
On Wed, Dec 18, 2024 at 02:08:13PM +0100, Jean-Marc Lasgouttes wrote: > Le 17/12/2024 ?? 23:07, Jean-Marc Lasgouttes a écrit : > > Le 17/12/2024 ?? 23:01, Pavel Sanda a écrit : > > > On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: > > > > Hi, > > > > > > > > this happened couple times

Re: Metrics-related crashes in branch

2024-12-18 Thread Jean-Marc Lasgouttes
Le 17/12/2024 à 23:07, Jean-Marc Lasgouttes a écrit : Le 17/12/2024 à 23:01, Pavel Sanda a écrit : On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: Hi, this happened couple times today in the particular document, which loads ton of pdf images, somewhere in the middle of initial lo

Re: Metrics-related crashes in branch

2024-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2024 à 23:01, Pavel Sanda a écrit : On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: Hi, this happened couple times today in the particular document, which loads ton of pdf images, somewhere in the middle of initial loading and scrolling (at the same time). I'll try to co

Re: Metrics-related crashes in branch

2024-12-17 Thread Pavel Sanda
On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: > Hi, > > this happened couple times today in the particular document, which loads ton > of pdf images, > somewhere in the middle of initial loading and scrolling (at the same time). > > I'll try to come up with some recipe, but it see

Metrics-related crashes in branch

2024-12-17 Thread Pavel Sanda
Hi, this happened couple times today in the particular document, which loads ton of pdf images, somewhere in the middle of initial loading and scrolling (at the same time). I'll try to come up with some recipe, but it seems very hard to reproduce on demand, I need to load it like 20x to get it