Re: New patch for native spell checker on mac os (was Re: Looking for Spellcheckers Name)

2010-07-06 Thread Stephan Witt
Am 07.07.2010 um 01:19 schrieb Joost Verburg: > On 7/6/2010 5:43 PM, Pavel Sanda wrote: >> Stephan what is the plan about the dictionaries? do you plan to include them >> all into the installer? 0.5 GB for each release looks quite big... This I currently don't know. Since I reached a "milestone"

Re: New patch for native spell checker on mac os (was Re: Looking for Spellcheckers Name)

2010-07-06 Thread Joost Verburg
On 7/6/2010 5:43 PM, Pavel Sanda wrote: Stephan what is the plan about the dictionaries? do you plan to include them all into the installer? 0.5 GB for each release looks quite big... Is this dmg uncompressed? A zip with Hunspell dictionaries for all supported languages is only about 30 MB.

Re: New patch for native spell checker on mac os (was Re: Looking for Spellcheckers Name)

2010-07-06 Thread Pavel Sanda
Stephan Witt wrote: > Index: development/LyX-Mac-binary-release.sh > === > --- development/LyX-Mac-binary-release.sh (Revision 34745) > +++ development/LyX-Mac-binary-release.sh (Arbeitskopie) > @@ -199,7 +199,7 @@ > QtLibrari

New patch for native spell checker on mac os (was Re: Looking for Spellcheckers Name)

2010-07-06 Thread Stephan Witt
Am 06.07.2010 um 10:00 schrieb Jean-Marc Lasgouttes: > Le 5 juil. 10 à 23:32, Stephan Witt a écrit : >> Am 05.07.2010 um 23:08 schrieb Jean-Marc Lasgouttes: >> >>> Sorry. Try AppleSpellChecker.mm. .m is ObjC and .mm is objC++, I think. >> >> It doesn't work out of the box... autoconf didn't dete

Re: Looking for Spellcheckers Name

2010-07-06 Thread Stephan Witt
Am 06.07.2010 um 10:00 schrieb Jean-Marc Lasgouttes: > Le 5 juil. 10 à 23:32, Stephan Witt a écrit : >> Am 05.07.2010 um 23:08 schrieb Jean-Marc Lasgouttes: >> >>> Sorry. Try AppleSpellChecker.mm. .m is ObjC and .mm is objC++, I think. >> >> It doesn't work out of the box... autoconf didn't dete

Re: Looking for Spellcheckers Name

2010-07-06 Thread Jean-Marc Lasgouttes
Le 5 juil. 10 à 23:32, Stephan Witt a écrit : Am 05.07.2010 um 23:08 schrieb Jean-Marc Lasgouttes: Sorry. Try AppleSpellChecker.mm. .m is ObjC and .mm is objC++, I think. It doesn't work out of the box... autoconf didn't detect the .mm extension. I'll continue tomorrow. In case you have a

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 23:08 schrieb Jean-Marc Lasgouttes: > Le 5 juil. 10 à 21:26, Stephan Witt a écrit : >> Another one: I couldn't manage to compile the "unified" >> AppleSpellChecker.m... > > Sorry. Try AppleSpellChecker.mm. .m is ObjC and .mm is objC++, I think. It doesn't work out of the box...

Re: Looking for Spellcheckers Name

2010-07-05 Thread Jean-Marc Lasgouttes
Le 5 juil. 10 à 21:26, Stephan Witt a écrit : Another one: I couldn't manage to compile the "unified" AppleSpellChecker.m... Sorry. Try AppleSpellChecker.mm. .m is ObjC and .mm is objC++, I think. JMarc

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 18:02 schrieb Jean-Marc LASGOUTTES: > Stephan Witt writes: >> BTW, regarding USE_MACOSX_PACKAGING... >> >> in lyx-devel/src/support/Package.cpp I can find: >> >> #if defined (USE_WINDOWS_PACKAGING) >> # include "support/os_win32.h" >> #endif >> ... >> #if defined (USE_MACOSX_PA

Re: Looking for Spellcheckers Name

2010-07-05 Thread Jean-Marc LASGOUTTES
Abdelrazak Younes writes: >> That would introduce an AppleSpellChecker.m file directly in directory >> lyx-devel/src. > That's good to know. > >> I had the impression they should live in lyx-devel/src/support only. >> > I would rather move all the spellers to src/support. This could be a goo

Re: Looking for Spellcheckers Name

2010-07-05 Thread Jean-Marc LASGOUTTES
Stephan Witt writes: > BTW, regarding USE_MACOSX_PACKAGING... > > in lyx-devel/src/support/Package.cpp I can find: > > #if defined (USE_WINDOWS_PACKAGING) > # include "support/os_win32.h" > #endif > ... > #if defined (USE_MACOSX_PACKAGING) > # include // FSFindFolder, FSRefMakePath > #endif > > T

Re: Looking for Spellcheckers Name

2010-07-05 Thread Abdelrazak Younes
On 07/05/2010 05:32 PM, Stephan Witt wrote: Am 05.07.2010 um 15:53 schrieb Jean-Marc LASGOUTTES: Abdelrazak Younes writes: Great. Is there a reason why the code is split in two files? It would be better to have a single AppleSpellChecker.m file implementing the speller object IMO.

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 15:53 schrieb Jean-Marc LASGOUTTES: > Abdelrazak Younes writes: >>> Great. Is there a reason why the code is split in two files? It would be >>> better to have a single AppleSpellChecker.m file implementing the speller >>> object IMO. >> >> Well, you still need to implement the

Re: Looking for Spellcheckers Name

2010-07-05 Thread Jean-Marc LASGOUTTES
Abdelrazak Younes writes: >> Great. Is there a reason why the code is split in two files? It would be >> better to have a single AppleSpellChecker.m file implementing the speller >> object IMO. > > Well, you still need to implement the SpellChecker virtual interface > in a C++ file. And AFAIU, App

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 15:56 schrieb Jean-Marc LASGOUTTES: > Stephan Witt writes: >>> Why not, but it is a bit fragile IMO. That would be like the Linkback >>> support, right? >> >> Why would that be fragile? >> Do you mean if USE_MACOSX_PACKAGING is true and it is not Mac OS X >= >> 10.4? > > Packa

Re: Looking for Spellcheckers Name

2010-07-05 Thread Jean-Marc LASGOUTTES
Stephan Witt writes: >> Why not, but it is a bit fragile IMO. That would be like the Linkback >> support, right? > > Why would that be fragile? > Do you mean if USE_MACOSX_PACKAGING is true and it is not Mac OS X >= > 10.4? Packaging is just packaging. If we had a gnustep port, it would use this

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 13:54 schrieb Jean-Marc LASGOUTTES: > Stephan Witt writes: >>> Keep this name (AppleSpell with proper casing maybe), but make sure it >>> is the default on the mac. >> >> I have an idea myself for a name: "native". I don't know when it makes >> sense for other platforms too. >

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 14:10 schrieb Pavel Sanda: > Stephan Witt wrote: >> Index: src/support/AppleSpeller.m >> === >> --- src/support/AppleSpeller.m (Revision 0) >> +++ src/support/AppleSpeller.m (Revision 0) > > why has this

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 14:18 schrieb Abdelrazak Younes: > On 07/05/2010 01:59 PM, Jean-Marc LASGOUTTES wrote: >> Stephan Witt writes: >> >>> I plan to avoid additional configure checks. I think I can rely on the >>> macro USE_MACOSX_PACKAGING. >>> >>> Attached is a patch to implement the feature

Re: Looking for Spellcheckers Name

2010-07-05 Thread Abdelrazak Younes
On 07/05/2010 01:59 PM, Jean-Marc LASGOUTTES wrote: Stephan Witt writes: I plan to avoid additional configure checks. I think I can rely on the macro USE_MACOSX_PACKAGING. Attached is a patch to implement the feature for Mac OS X. Great. Is there a reason why the code is split in t

Re: Looking for Spellcheckers Name

2010-07-05 Thread Pavel Sanda
Stephan Witt wrote: > Index: src/support/AppleSpeller.m > === > --- src/support/AppleSpeller.m(Revision 0) > +++ src/support/AppleSpeller.m(Revision 0) why has this file "m" extension? > @@ -0,0 +1,184 @@ > +/** > + *

Re: Looking for Spellcheckers Name

2010-07-05 Thread Jean-Marc LASGOUTTES
Stephan Witt writes: > I plan to avoid additional configure checks. I think I can rely on the macro > USE_MACOSX_PACKAGING. > > Attached is a patch to implement the feature for Mac OS X. Great. Is there a reason why the code is split in two files? It would be better to have a single AppleSpellCh

Re: Looking for Spellcheckers Name

2010-07-05 Thread Stephan Witt
Am 05.07.2010 um 12:19 schrieb Jean-Marc LASGOUTTES: > Stephan Witt writes: > >> I've made some progress with the integration of Apples spell checking engine >> in LyX. > > Great! > >> Basically it works here. Now I have to choose a name for it to the user. >> "applespell" seems to similar to

Re: Looking for Spellcheckers Name

2010-07-05 Thread Jean-Marc LASGOUTTES
Stephan Witt writes: > I've made some progress with the integration of Apples spell checking engine > in LyX. Great! > Basically it works here. Now I have to choose a name for it to the user. > "applespell" seems to similar to "aspell" and may be the source for some > confusion. > Has anybody

Looking for Spellcheckers Name

2010-07-04 Thread Stephan Witt
I've made some progress with the integration of Apples spell checking engine in LyX. Basically it works here. Now I have to choose a name for it to the user. "applespell" seems to similar to "aspell" and may be the source for some confusion. Has anybody an opinion? I couldn't come up with a bette