Re: Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-04-04 Thread Scott Kostyshak
On Wed, Apr 04, 2018 at 10:33:47AM +, Jean-Marc Lasgouttes wrote: > Le 04/04/2018 à 04:17, Scott Kostyshak a écrit : > > On Fri, Feb 23, 2018 at 09:42:07AM +, Jean-Marc Lasgouttes wrote: > > > > > What refusing to do something if the selection is longer than, say, 50 > > > paragraphs? We c

Re: Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-04-04 Thread Jean-Marc Lasgouttes
Le 04/04/2018 à 04:17, Scott Kostyshak a écrit : On Fri, Feb 23, 2018 at 09:42:07AM +, Jean-Marc Lasgouttes wrote: What refusing to do something if the selection is longer than, say, 50 paragraphs? We could count characters too, of course, but do we want to transform a full document to a do

Re: Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-04-03 Thread Scott Kostyshak
On Fri, Feb 23, 2018 at 09:42:07AM +, Jean-Marc Lasgouttes wrote: > What refusing to do something if the selection is longer than, say, 50 > paragraphs? We could count characters too, of course, but do we want to > transform a full document to a docstring just to be able to decide that it > is

Re: Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-02-24 Thread Jean-Marc Lasgouttes
Le 23 février 2018 19:32:06 GMT+01:00, Guenter Milde a écrit : >> Is the problem the length or is the problem that the selection >contains >> insets of a type that have no natural conversion to math? > >Checking for insets that cannot be converted to math should also solve >most >real-life cases

Re: Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-02-23 Thread Guenter Milde
On 2018-02-23, Scott Kostyshak wrote: > [-- Type: text/plain, Encoding: quoted-printable --] > On Fri, Feb 23, 2018 at 09:42:07AM +, Jean-Marc Lasgouttes wrote: >> Le 12/01/2018 à 23:28, Scott Kostyshak a écrit : >> > I'm not sure what the desired behavior is. Perhaps if the selection >> > c

Re: Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-02-23 Thread Scott Kostyshak
On Fri, Feb 23, 2018 at 09:42:07AM +, Jean-Marc Lasgouttes wrote: > Le 12/01/2018 à 23:28, Scott Kostyshak a écrit : > > I'm not sure what the desired behavior is. Perhaps if the selection > > contains insets of a certain type (e.g. a float), the LFUN should just > > abort with a relevant mess

Re: Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-02-23 Thread Jean-Marc Lasgouttes
Le 12/01/2018 à 23:28, Scott Kostyshak a écrit : I don't imagine any user actually does this, but if I select all and do ctrl+m, LyX often has problems (e.g. my RAM goes from 1GB to my max of 8GB). I've found this with Embedded Objects and with User Guide. Yes, I can imagine that the result is

Applying LFUN_MATH_MODE to big help docs causes memory problems

2018-01-12 Thread Scott Kostyshak
I don't imagine any user actually does this, but if I select all and do ctrl+m, LyX often has problems (e.g. my RAM goes from 1GB to my max of 8GB). I've found this with Embedded Objects and with User Guide. If I do the above with LyX 2.1.0, there are no memory problems. Instead, LyX just replaces

Re: LFUN_MATH_MODE

2005-01-03 Thread Andre Poenitz
vision 1.274 diff -u -r1.274 text3.C --- text3.C 6 Dec 2004 13:03:38 - 1.274 +++ text3.C 26 Dec 2004 14:40:05 - @@ -1318,7 +1318,11 @@ case LFUN_MATH_IMPORT_SELECTION: case LFUN

Re: LFUN_MATH_MODE

2004-12-27 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: Fix attached. OK to commit? >> I am not sure why we want to enable something like "math-mode >> ". Juergen> That's how it always used to be (at least in 1.3 and 1.4cvs). Juergen> And this is

Re: LFUN_MATH_MODE

2004-12-27 Thread Juergen Spitzmueller
it just swallow any argument ("on" will be recognized anyway in math_nestinset), or should LFUN_MATH_MODE do something like case LFUN_MATH_MODE: if (cmd.argument.empty()) mathDispatch(cur, cmd, false); else if (cmd

Re: LFUN_MATH_MODE

2004-12-27 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Andre Poenitz wrote: >> There is also a check for the argument "on" in math_nestinset.C. I >> >> > guess André forgot to check for that argument in other places >> (text3.C et > al.). >> >> Indeed. Would be nice if you

Re: LFUN_MATH_MODE

2004-12-26 Thread Juergen Spitzmueller
case LFUN_MATH_IMPORT_SELECTION: case LFUN_MATH_MODE: - mathDispatch(cur, cmd, false); + if (cmd.argument == "on") + // don't pass "on" as argument + mathDispatch(cur, FuncRequest(LFUN_MATH_MODE), false); + else + mathDispatch(cur, cmd, false); break; case LFUN_MATH_MACRO:

Re: LFUN_MATH_MODE

2004-12-23 Thread Andre Poenitz
On Tue, Dec 21, 2004 at 11:51:39AM +0100, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > >> I see. There is also a check for the argument "on" in math_nestinset.C. I > >> guess André forgot to check for that argument in other places (text3.C et > >> al.). > > > > Indeed. Would be nice if

Re: LFUN_MATH_MODE

2004-12-21 Thread Juergen Spitzmueller
Andre Poenitz wrote: >> I see. There is also a check for the argument "on" in math_nestinset.C. I >> guess André forgot to check for that argument in other places (text3.C et >> al.). > > Indeed. Would be nice if you could fix that. If you tell me how to handle the argument. Is it that the user

Re: LFUN_MATH_MODE

2004-12-21 Thread Andre Poenitz
On Mon, Dec 20, 2004 at 12:36:25PM +0100, Juergen Spitzmueller wrote: > Alfredo Braunstein wrote: > > Note that Andre did the opposite change recently, maybe he had some reason > > to do it. ;-) (cvs says: "fix  #1736"). But I have no idea. > > > > http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/l

Re: LFUN_MATH_MODE

2004-12-20 Thread Juergen Spitzmueller
Alfredo Braunstein wrote: > Note that Andre did the opposite change recently, maybe he had some reason > to do it. ;-) (cvs says: "fix Â#1736"). But I have no idea. > > http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/lib/ui/stdmenus.ui.diff?r1 >=1.35&r2=1.36 I see. There is also a check for the a

Re: LFUN_MATH_MODE

2004-12-20 Thread Alfredo Braunstein
Juergen Spitzmueller wrote: > Inserting an inline formula via the menu currently inserts a formula with > the content "on". This is because the menu calls "math-mode on" instead of > "math-mode" (like in 1.3). Is this a typo? > > (The attached patch fixes it) > > JÃrgen Note that Andre did the

LFUN_MATH_MODE

2004-12-20 Thread Juergen Spitzmueller
Inserting an inline formula via the menu currently inserts a formula with the content "on". This is because the menu calls "math-mode on" instead of "math-mode" (like in 1.3). Is this a typo? (The attached patch fixes it) Jürgen Index: stdmenus.ui ===