Jean-Marc Lasgouttes wrote: > Juergen> Fix attached. OK to commit? > > I am not sure why we want to enable something like "math-mode > <content>".
That's how it always used to be (at least in 1.3 and 1.4cvs). And this is also the reason for the bug I'm fixing. > Actually, when Andre posted > http://marc.theaimsgroup.com/?l=lyx-devel&m=110379007315837&w=2 > I read it as saying that math-mode should not do the work of > math-insert. > However, if your patch is really what Andre' meant, go ahead. I am not sure. Should it just swallow any argument ("on" will be recognized anyway in math_nestinset), or should LFUN_MATH_MODE do something like case LFUN_MATH_MODE: if (cmd.argument.empty()) mathDispatch(cur, cmd, false); else if (cmd.argument == "on") // don't pass "on" as argument mathDispatch(cur, FuncRequest(LFUN_MATH_MODE), false); else { mathDispatch(cur, FuncRequest(LFUN_MATH_MODE), false); mathDispatch(cur, FuncRequest(LFUN_INSERT_MATH, cmd.argument), false); } break; OTOH I thought that this is what mathDispatch does anyway (using LFUN_INSERT_MATH), so it should be functionally equivalent to my patch. Jürgen
