Abdelrazak Younes ha scritto:
What about the buffer().isInternal() or buffer().internal() method ?
Afterward, implementation may be changed as appropriate.
OK for the new buffer().isInternal() but this method should be used in
the same commit. I guess this is in TocBackend.cpp:
- buffer_-
Jean-Marc Lasgouttes wrote:
Le 28/08/2009 08:40, Abdelrazak Younes a écrit :
Vincent van Ravesteijn wrote:
Most of all, I don't like the randomness with which this is done. All
LFUNs handled in LyXFunc should relate to the documentBuffer(). Now
some LFUNs are corrected and others are not. At le
Tommaso Cucinotta wrote:
Vincent van Ravesteijn ha scritto:
The comment was about r31219. I really don't like that commit because:
1) I don't want to spoil the code with an infinite amount of
if (buffer().fileName().extension() == "internal")
Absolutely agree. At least, it should be "if (buff
Vincent van Ravesteijn ha scritto:
The comment was about r31219. I really don't like that commit because:
1) I don't want to spoil the code with an infinite amount of
if (buffer().fileName().extension() == "internal")
Absolutely agree. At least, it should be "if (buffer().isInternal())".
2) th
Le 28/08/2009 08:40, Abdelrazak Younes a écrit :
Vincent van Ravesteijn wrote:
Most of all, I don't like the randomness with which this is done. All
LFUNs handled in LyXFunc should relate to the documentBuffer(). Now
some LFUNs are corrected and others are not. At least the following
should all
Vincent van Ravesteijn wrote:
My guess is that you wanted to refer to the LyXView.{h,cpp} patch
which introduces
LyXView::documentBufferView()
where I actually violated the protocol, apologies.
Actually, I was probably mislead by a comment from Vincent, I thought
he was talking about thi
My guess is that you wanted to refer to the LyXView.{h,cpp} patch
which introduces
LyXView::documentBufferView()
where I actually violated the protocol, apologies.
Actually, I was probably mislead by a comment from Vincent, I thought
he was talking about this GuiRef patch.
The comment w
On 27/08/2009 23:07, Abdelrazak Younes wrote:
On 27/08/2009 22:08, Tommaso Cucinotta wrote:
On a related note, I just wanted to "complete" (but not commit) the
patch by:
-) renaming the LyXView::view() method to LyXView::currentBufferView()
[ or LyXView::selectedBufferView() might constitute
On 27/08/2009 22:08, Tommaso Cucinotta wrote:
Abdelrazak Younes ha scritto:
Tommaso Cucinotta wrote:
when clicking on a broken reference to label, the current reference
is shown as BROKEN: also in the GuiRef.cpp dialog, but when clicking
on it (i.e., confirming its value -- for example, becaus
Abdelrazak Younes ha scritto:
Tommaso Cucinotta wrote:
when clicking on a broken reference to label, the current reference
is shown as BROKEN: also in the GuiRef.cpp dialog, but when clicking
on it (i.e., confirming its value -- for example, because I'm going
Hello Tommaso,
Even if you are a
Tommaso Cucinotta wrote:
Hello,
when clicking on a broken reference to label, the current reference is
shown as BROKEN: also in the GuiRef.cpp dialog, but when clicking on
it (i.e., confirming its value -- for example, because I'm going to
add the label just a few seconds afterward), the "BRO
Hello,
when clicking on a broken reference to label, the current reference is
shown as BROKEN: also in the GuiRef.cpp dialog, but when clicking on it
(i.e., confirming its value -- for example, because I'm going to add the
label just a few seconds afterward), the "BROKEN: Ref: " label is
ente
12 matches
Mail list logo