Abdelrazak Younes ha scritto:
Tommaso Cucinotta wrote:
when clicking on a broken reference to label, the current reference
is shown as BROKEN: also in the GuiRef.cpp dialog, but when clicking
on it (i.e., confirming its value -- for example, because I'm going
Hello Tommaso,
Even if you are asking for comments (which is good) I see that you
already committed this patch.
Hello, I didn't commit this patch. I just updated and the changes are
still on my laptop (and the Trac history doesn't show commits by myself
on GuiRef.cpp).
My guess is that you wanted to refer to the LyXView.{h,cpp} patch which
introduces
LyXView::documentBufferView()
where I actually violated the protocol, apologies.
Things like GUI or something exclusively located on one of your own
code (egg findadv) are OK for example. Things that touches core
interfaces or functions are not OK.
Ok.
In the mean time, please revert.
Can you confirm, please, if you want me to revert Changeset 31203 ?
http://www.lyx.org/trac/changeset/31203/lyx-devel/trunk/src/frontends/LyXView.h
On a related note, I just wanted to "complete" (but not commit) the
patch by:
-) renaming the LyXView::view() method to LyXView::currentBufferView()
[ or LyXView::selectedBufferView() might constitute an alternative ]
-) renaming the LyXView::currentMainWorkArea() method to
LyXView::currentDocumentWorkArea()
(somebody suggested that the "main" keyword here is misleading, and I
share this viewpoint, as it confuses with the "master" concept).
Bye,
T.
