Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-06-02 Thread Stephan Witt
Am 02.06.2010 um 19:31 schrieb Joost Verburg: > On 5/28/2010 4:31 PM, Stephan Witt wrote: >> 3. system support directory - there will the shipped data files live. > > Is this the LyX library directory? So the dictionaries / thesaurus lists > could be stored in e.g. "Resources\dict" and "Resource

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-06-02 Thread Joost Verburg
On 5/28/2010 4:31 PM, Stephan Witt wrote: 3. system support directory - there will the shipped data files live. Is this the LyX library directory? So the dictionaries / thesaurus lists could be stored in e.g. "Resources\dict" and "Resources\thes" on Windows? Joost

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-06-02 Thread Jean-Marc LASGOUTTES
Stephan Witt writes: >>> Please refrain from using #defines. I do not think this particular one >>> is useful. >> >> I know that defines are bad. But here I don't know how to make the used >> location clear. >> The alternative is a local const string in method >> pair Thesaurus::Private::getThe

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-05-31 Thread Stephan Witt
Am 31.05.2010 um 14:37 schrieb Stephan Witt: > Am 31.05.2010 um 13:00 schrieb Jean-Marc LASGOUTTES: > > Thanks for commenting! > >> Stephan Witt writes: >>> I've prepared a patch to change hunspell and myThes wrappers to be ready >>> for included dictionaries. >>> Please have a look at the pat

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-05-31 Thread Stephan Witt
Am 31.05.2010 um 12:36 schrieb Jean-Marc LASGOUTTES: > Stephan Witt writes: >> The dictionaries are arch independent AFAIK. So the question is where to >> store and how to install them. >> The logical place would be lyx-devel/lib/dict and lyx-devel/lib/thes. But >> this is in SVN-tree... > > I

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-05-31 Thread Jean-Marc LASGOUTTES
Stephan Witt writes: > I've prepared a patch to change hunspell and myThes wrappers to be ready for > included dictionaries. > Please have a look at the patch and point me to typos and thinkos. > With the changes the binary searches the data files in this order: > 1. user path from configuration

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-05-31 Thread Jean-Marc LASGOUTTES
Stephan Witt writes: > The dictionaries are arch independent AFAIK. So the question is where to > store and how to install them. > The logical place would be lyx-devel/lib/dict and lyx-devel/lib/thes. But > this is in SVN-tree... Installing them at this place does not mean that we have to have

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-05-29 Thread Stephan Witt
Am 29.05.2010 um 02:02 schrieb Pavel Sanda: > Stephan Witt wrote: >> The next steps on my agenda are >> * dictionary collection > > this is mac only thing or other archs need something similar? The dictionaries are arch independent AFAIK. So the question is where to store and how to install the

Re: Code Review: Next step to provide spellchecker with dictionaries included

2010-05-28 Thread Pavel Sanda
Stephan Witt wrote: > The next steps on my agenda are > * dictionary collection this is mac only thing or other archs need something similar? > +#define MAX_SELECTOR 3 > +string dictPath(int selector) > +{ > + switch (selector) { > + case 2: return > addName(lyx::support::package().syste

Code Review: Next step to provide spellchecker with dictionaries included

2010-05-28 Thread Stephan Witt
Dear LyX developers, I've prepared a patch to change hunspell and myThes wrappers to be ready for included dictionaries. Please have a look at the patch and point me to typos and thinkos. With the changes the binary searches the data files in this order: 1. user path from configuration 2. user su