Stephan Witt <st.w...@gmx.net> writes: >>> Please refrain from using #defines. I do not think this particular one >>> is useful. >> >> I know that defines are bad. But here I don't know how to make the used >> location clear. >> The alternative is a local const string in method >> pair<string,string> Thesaurus::Private::getThesaurus(docstring const & lang) >> around line 120 of src/Thesaurus.cpp >> That's pretty far away of the beginning of the file. >> >> Any idea? > > Is something like the attached patch better?
Personally, I think that having the thesaurus location definition near the point where it is used is a good thing. I would even get rid of the variable/method altogether and just use "thes" twice. JMarc
