On Mon, Mar 24, 2008 at 09:18:43AM -0500, Bo Peng wrote:
> On Mon, Mar 24, 2008 at 9:13 AM, Jürgen Spitzmüller
> <[EMAIL PROTECTED]> wrote:
> > rgheck wrote:
> > > > Open a document with a listings inset, right click, settings. Most of
> > > > the time, lyx will crash here (Linux, RHEL4, gcc 4.1,
> This should be fixed now. "whateverCO->currentIndex()" is returning -1
> if there's no current index yet. this can't be used to access an
> array...
Thank you very much! I was confused because lyx did not always crash.
Bo
On Mon, Mar 24, 2008 at 09:18:43AM -0500, Bo Peng wrote:
> On Mon, Mar 24, 2008 at 9:13 AM, Jürgen Spitzmüller
> <[EMAIL PROTECTED]> wrote:
> > rgheck wrote:
> > > > Open a document with a listings inset, right click, settings. Most of
> > > > the time, lyx will crash here (Linux, RHEL4, gcc 4.1,
> When I traced it, gdb reported it elsewhere, in a totally unhelpful way.
> Could it be some initialization problem with qt_() itself?
I also suspected this, maybe we can change qt_() (no translation, for
example) and test.
Bo
Bo Peng wrote:
On Mon, Mar 24, 2008 at 9:13 AM, Jürgen Spitzmüller
<[EMAIL PROTECTED]> wrote:
rgheck wrote:
> > Open a document with a listings inset, right click, settings. Most of
> > the time, lyx will crash here (Linux, RHEL4, gcc 4.1, qt 4.22)
FWIW, I see this too:
http://bugzilla.l
On Mon, Mar 24, 2008 at 9:13 AM, Jürgen Spitzmüller
<[EMAIL PROTECTED]> wrote:
> rgheck wrote:
> > > Open a document with a listings inset, right click, settings. Most of
> > > the time, lyx will crash here (Linux, RHEL4, gcc 4.1, qt 4.22)
>
> FWIW, I see this too:
> http://bugzilla.lyx.org/sho
rgheck wrote:
> > Open a document with a listings inset, right click, settings. Most of
> > the time, lyx will crash here (Linux, RHEL4, gcc 4.1, qt 4.22)
> >
> >
>
> Weird.
FWIW, I see this too:
http://bugzilla.lyx.org/show_bug.cgi?id=4607
Jürgen
Bo Peng wrote:
On Mon, Mar 24, 2008 at 7:21 AM, rgheck <[EMAIL PROTECTED]> wrote:
Bo Peng wrote:
> Note that the mysterious listings setting crash is still there
>
>
Can you remind me how to reproduce this?
Open a document with a listings inset, right click, settings. Most of
On Mon, Mar 24, 2008 at 7:21 AM, rgheck <[EMAIL PROTECTED]> wrote:
> Bo Peng wrote:
> > Note that the mysterious listings setting crash is still there
> >
> >
> Can you remind me how to reproduce this?
>
Open a document with a listings inset, right click, settings. Most of
the time, lyx wi
Bo Peng wrote:
Note that the mysterious listings setting crash is still there
Can you remind me how to reproduce this?
rh
> As shown in the attached patch, I tent to remove the use of a
> temporary InsetGraphics by moving the lfun implementation to
> BufferView.cpp.
>
I have committed this part, and this is the only part that makes
sense. All others were trying to re-implement next-inset-toggle. :-(
Bo
> It certainly feels like a
> kludge that we're creating a temporary InsetGraphics just so we can call
> one of its methods. But I don't know this code well enough to have any
> more of an opinion than that...except to say, if we commit this, let's
> do the context menu and see what Andre thin
Bo Peng wrote:
I tried starting to do this, but I think we'd probably have to do it all
in one go, due to how the factory works: the inset Buffer gets set in
createInset, not at creation time in createInsetHelper. So we'd at least
have to pass the Buffer to createInsetHelper; but then most in
> > Just to make sure, did you apply my patch?
>
> Well, I think yes. But now that you're asking I am not sure. I checked
> out the latest revision from SVN (now r23907) and it's still like I
> said.
I meant the patch attached to my email. It may not apply clearly now though.
Bo
On Sun, Mar 23, 2008 at 4:53 PM, Bo Peng <[EMAIL PROTECTED]> wrote:
> > Fyi: that doesn't work on my LyX (WinXP) as a right click on the
> > graphic opens the graphics settings dialog. Right click on the figure
> > float inset opens a context menu and the float placement dialog. But
> > in
> I tried starting to do this, but I think we'd probably have to do it all
> in one go, due to how the factory works: the inset Buffer gets set in
> createInset, not at creation time in createInsetHelper. So we'd at least
> have to pass the Buffer to createInsetHelper; but then most insets woul
> > This patch also adds a context menu to InsetGraphics, with 'Edit' as
> > the first item. However, when I try to implement the 'settings' menu
> > using LFUN_INSET_SETTINGS, I find that cur.inset() returns InsetText
> > when I right click on an InsetGraphics. Even if I can enable
> > '
On Sun, Mar 23, 2008 at 10:43:20AM -0400, rgheck wrote:
> Andre Poenitz wrote:
>>> Should we permit inset creation without a buffer, anyway?
>>>
>>
>> In the long run probably not. Right now it's a too long shot.
>>
>> You could try to "convert" individual insets, though, by allowing
>> only c
Andre Poenitz wrote:
Should we permit inset creation without a buffer, anyway?
In the long run probably not. Right now it's a too long shot.
You could try to "convert" individual insets, though, by allowing
only constructors taking a Buffer argument.
I tried starting to do this, but I
Bo Peng wrote:
Fixed (r23899).
That worked, but it's the wrong fix. Part of the point of Andre's inset
buffer patch was to stop us from having to access the buffer that way.
The right fix is to make sure the Inset has its buffer set. I've
committed that.
We can still make the othe
On Sat, Mar 22, 2008 at 09:15:08PM -0400, rgheck wrote:
> Andre Poenitz wrote:
>>> Looks like the problem is here:
>>> case LFUN_GRAPHICS_EDIT: {
>>> FuncRequest fr(action, argument);
>>> InsetGraphics().dispatch(view()->cursor(), fr);
>>> break;
>>> }
>>> This creates a null InsetGraphics on which
On Sun, Mar 23, 2008 at 5:50 AM, Bo Peng <[EMAIL PROTECTED]> wrote:
> > Fixed (r23899).
Yes, editing a figure works now as expected, thank you.
> This patch also adds a context menu to InsetGraphics, with 'Edit' as
> the first item. However, when I try to implement the 'settings' menu
> using
> Fixed (r23899).
A proper fix, IMHO, would be moving GRAPHICS_EDIT from LyXFunc.h/cpp
to BufferView.h/cpp, and dispatch GRAPHICS_EDIT from a real inset. The
attached patch does this.
This patch also adds a context menu to InsetGraphics, with 'Edit' as
the first item. However, when I try to impl
On Sat, Mar 22, 2008 at 10:48 PM, Bo Peng <[EMAIL PROTECTED]> wrote:
> > OK. I can certainly do this.
> >
> > Should we permit inset creation without a buffer, anyway?
>
> 1.5.x uses *cur.bv().buffer(), 1.6.x changed this to plain buffer().
Fixed (r23899).
Bo
> OK. I can certainly do this.
>
> Should we permit inset creation without a buffer, anyway?
1.5.x uses *cur.bv().buffer(), 1.6.x changed this to plain buffer().
Bo
Andre Poenitz wrote:
Looks like the problem is here:
case LFUN_GRAPHICS_EDIT: {
FuncRequest fr(action, argument);
InsetGraphics().dispatch(view()->cursor(), fr);
break;
}
This creates a null InsetGraphics on which to call dispatch(), and the
buffer isn't set. This is likely also to be a problem
On Sat, Mar 22, 2008 at 06:07:40PM -0400, rgheck wrote:
> Stefan Schimanski wrote:
>> Another buffer pointer crash:
>>
>> * insert graphics
>> * open graphics dialog for new inset
>> * click edit
>> * => segfault/assert
>>
> Looks
Stefan Schimanski wrote:
Another buffer pointer crash:
* insert graphics
* open graphics dialog for new inset
* click edit
* => segfault/assert
Looks like the problem is here:
case LFUN_GRAPHICS_EDIT: {
FuncRequest fr(action, argument);
InsetGraphics().dispatch(view()->cursor(), fr);
Another buffer pointer crash:
* insert graphics
* open graphics dialog for new inset
* click edit
* => segfault/assert
Stefan
29 matches
Mail list logo
