On Sun, Mar 23, 2008 at 10:43:20AM -0400, rgheck wrote: > Andre Poenitz wrote: >>> Should we permit inset creation without a buffer, anyway? >>> >> >> In the long run probably not. Right now it's a too long shot. >> >> You could try to "convert" individual insets, though, by allowing >> only constructors taking a Buffer argument. >> >> > I tried starting to do this, but I think we'd probably have to do it all in > one go, due to how the factory works: the inset Buffer gets set in > createInset, not at creation time in createInsetHelper. So we'd at least > have to pass the Buffer to createInsetHelper; but then most insets would > ignore it. I guess we could do: > if (inset && !inset.buffer()) > inset->setBuffer(buf); > as a temporary measure?
Just if (inset) inset->setBuffer(buf); would do no harm. At worst, we set the buffer twice. Andre'