Re: Advanced find changes of behavior in master

2021-03-30 Thread Scott Kostyshak
On Tue, Mar 30, 2021 at 06:04:21PM +0200, Jean-Marc Lasgouttes wrote: > Le 30/03/2021 à 16:34, Scott Kostyshak a écrit : > > If I remember correctly, (1) is because of the multiple calls to update > > layouts; > > This will not happen for release, but still it is pretty annoying. It's not annoyin

Re: Advanced find changes of behavior in master

2021-03-30 Thread Jean-Marc Lasgouttes
Le 30/03/2021 à 16:34, Scott Kostyshak a écrit : If I remember correctly, (1) is because of the multiple calls to update layouts; This will not happen for release, but still it is pretty annoying. and (2) I think was improved (by you I think) so that the toolbar icons do not change. The work

Re: Advanced find changes of behavior in master

2021-03-30 Thread Scott Kostyshak
On Mon, Mar 29, 2021 at 11:11:33AM +0200, Jean-Marc Lasgouttes wrote: > Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : > > I see a couple of changes in behavior in advanced find that can be > > reproduced with the Welcome.lyx file (I attached it for convenience). > > > > 1. In advanced find, put

Re: Advanced find changes of behavior in master

2021-03-29 Thread Jean-Marc Lasgouttes
Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : I see a couple of changes in behavior in advanced find that can be reproduced with the Welcome.lyx file (I attached it for convenience). 1. In advanced find, put "a" in the find area and "c" in the replace area and do "Replace all". It takes a

Re: Advanced find changes of behavior in master

2020-12-22 Thread Scott Kostyshak
On Tue, Dec 22, 2020 at 04:58:27PM +0100, Kornel Benko wrote: > Am Mon, 21 Dec 2020 19:40:21 +0100 > schrieb Jean-Marc Lasgouttes : > > > Try again, I updated the layout files, it seems to make a big difference > > to me. Then we have to know why Adv F&R has to read the class files at > > all (u

Re: Advanced find changes of behavior in master

2020-12-22 Thread Scott Kostyshak
On Mon, Dec 21, 2020 at 07:40:21PM +0100, Jean-Marc Lasgouttes wrote: > Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : > > I see a couple of changes in behavior in advanced find that can be > > reproduced with the Welcome.lyx file (I attached it for convenience). > > > > 1. In advanced find, put

Re: Advanced find changes of behavior in master

2020-12-22 Thread Jean-Marc Lasgouttes
Le 22/12/2020 à 16:58, Kornel Benko a écrit : Am Mon, 21 Dec 2020 19:40:21 +0100 schrieb Jean-Marc Lasgouttes : Try again, I updated the layout files, it seems to make a big difference to me. Then we have to know why Adv F&R has to read the class files at all (using cut and paste, maybe?) I s

Re: Advanced find changes of behavior in master

2020-12-22 Thread Kornel Benko
Am Mon, 21 Dec 2020 19:40:21 +0100 schrieb Jean-Marc Lasgouttes : > Try again, I updated the layout files, it seems to make a big difference > to me. Then we have to know why Adv F&R has to read the class files at > all (using cut and paste, maybe?) I suppose it is because we are using latex-ou

Re: Advanced find changes of behavior in master

2020-12-22 Thread Jean-Marc Lasgouttes
Le 21/12/2020 à 19:40, Jean-Marc Lasgouttes a écrit : Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : I see a couple of changes in behavior in advanced find that can be reproduced with the Welcome.lyx file (I attached it for convenience). 1. In advanced find, put "a" in the find area and "c" i

Re: Advanced find changes of behavior in master

2020-12-21 Thread Jean-Marc Lasgouttes
Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : I see a couple of changes in behavior in advanced find that can be reproduced with the Welcome.lyx file (I attached it for convenience). 1. In advanced find, put "a" in the find area and "c" in the replace area and do "Replace all". It takes a

Re: Advanced find changes of behavior in master

2020-12-11 Thread Scott Kostyshak
On Thu, Nov 26, 2020 at 12:42:53PM -0500, Scott Kostyshak wrote: > On Thu, Nov 26, 2020 at 06:26:49PM +0100, Kornel Benko wrote: > > Am Thu, 26 Nov 2020 12:01:20 -0500 > > schrieb Scott Kostyshak : > > > > > On Thu, Nov 26, 2020 at 10:35:35AM +0100, Kornel Benko wrote: > > > > Am Thu, 26 Nov 2020

Re: Advanced find changes of behavior in master

2020-12-11 Thread Scott Kostyshak
On Mon, Nov 30, 2020 at 09:28:13PM -0500, Scott Kostyshak wrote: > On Mon, Nov 30, 2020 at 12:01:02AM -0500, Scott Kostyshak wrote: > > On Sun, Nov 29, 2020 at 11:23:10PM -0500, Scott Kostyshak wrote: > > > On Sun, Nov 29, 2020 at 11:04:59PM +0100, Jean-Marc Lasgouttes wrote: > > > > Le 25/11/2020

Re: Advanced find changes of behavior in master

2020-12-04 Thread Kornel Benko
Am Fri, 4 Dec 2020 15:28:51 +0100 schrieb Jean-Marc Lasgouttes : > Le 04/12/2020 à 13:19, Kornel Benko a écrit : > >> Note also that the 'replace' parts are disabled when the string to > >> search is empty. > > > > I cannot reproduce either. In fact, maybe because of empty search string as > >

Re: Advanced find changes of behavior in master

2020-12-04 Thread Jean-Marc Lasgouttes
Le 04/12/2020 à 13:19, Kornel Benko a écrit : Note also that the 'replace' parts are disabled when the string to search is empty. I cannot reproduce either. In fact, maybe because of empty search string as you suspected. Does that mean that this disabling is confusing? It was there before,

Re: Advanced find changes of behavior in master

2020-12-04 Thread Kornel Benko
Am Fri, 4 Dec 2020 11:43:27 +0100 schrieb Jean-Marc Lasgouttes : > Le 04/12/2020 à 11:42, Jean-Marc Lasgouttes a écrit : > > Le 03/12/2020 à 21:55, Kornel Benko a écrit : > >> There is a glitch though. > >> > >> Open a document. > >> Select ADV-Find > >> Change the document to read only, the rep

Re: Advanced find changes of behavior in master

2020-12-04 Thread Jean-Marc Lasgouttes
Le 04/12/2020 à 11:42, Jean-Marc Lasgouttes a écrit : Le 03/12/2020 à 21:55, Kornel Benko a écrit : There is a glitch though. Open a document. Select ADV-Find Change the document to read only, the replace buffer is greyed out, OK Close ADV-Find Change the document to read-write Select ADV-Find,

Re: Advanced find changes of behavior in master

2020-12-04 Thread Jean-Marc Lasgouttes
Le 03/12/2020 à 21:55, Kornel Benko a écrit : There is a glitch though. Open a document. Select ADV-Find Change the document to read only, the replace buffer is greyed out, OK Close ADV-Find Change the document to read-write Select ADV-Find, the replace buffer is still greyed out, not OK. Weir

Re: Advanced find changes of behavior in master

2020-12-03 Thread Kornel Benko
Am Thu, 3 Dec 2020 14:20:43 -0500 schrieb Scott Kostyshak : > On Thu, Dec 03, 2020 at 06:44:44PM +0100, Jean-Marc Lasgouttes wrote: > > Le 01/12/2020 à 12:30, Kornel Benko a écrit : > > > > Kornel, it would be nice if the "Replace with" label was greyed out when > > > > the document is read-only

Re: Advanced find changes of behavior in master

2020-12-03 Thread Kornel Benko
Am Thu, 3 Dec 2020 18:44:44 +0100 schrieb Jean-Marc Lasgouttes : > Le 01/12/2020 à 12:30, Kornel Benko a écrit : > >> Kornel, it would be nice if the "Replace with" label was greyed out when > >> the document is read-only, in order to help slow people like me. > > > > Would be nice, if would kn

Re: Advanced find changes of behavior in master

2020-12-03 Thread Scott Kostyshak
On Thu, Dec 03, 2020 at 06:44:44PM +0100, Jean-Marc Lasgouttes wrote: > Le 01/12/2020 à 12:30, Kornel Benko a écrit : > > > Kornel, it would be nice if the "Replace with" label was greyed out when > > > the document is read-only, in order to help slow people like me. > > > > Would be nice, if woul

Re: Advanced find changes of behavior in master

2020-12-03 Thread Jean-Marc Lasgouttes
Le 01/12/2020 à 12:30, Kornel Benko a écrit : Kornel, it would be nice if the "Replace with" label was greyed out when the document is read-only, in order to help slow people like me. Would be nice, if would know how :( (My work was only the execution, did not touch the GUI.) I tried somethin

Re: Advanced find changes of behavior in master

2020-12-01 Thread Kornel Benko
Am Tue, 1 Dec 2020 11:10:38 +0100 schrieb Jean-Marc Lasgouttes : > Le 30/11/2020 à 02:28, Kornel Benko a écrit : > >> I tried to have a look, but I cannot set focus in the replace workarea. > >> I click and nothing happens. Am I the only one? > >> > >> ubuntu groovy 20.10, qt 5.14.2. > > > > Yo

Re: Advanced find changes of behavior in master

2020-12-01 Thread Jean-Marc Lasgouttes
Le 30/11/2020 à 02:28, Kornel Benko a écrit : I tried to have a look, but I cannot set focus in the replace workarea. I click and nothing happens. Am I the only one? ubuntu groovy 20.10, qt 5.14.2. You may see that you have focus if you use code-preview. Ot I could check that my document is

Re: Advanced find changes of behavior in master

2020-11-30 Thread Scott Kostyshak
On Mon, Nov 30, 2020 at 12:01:02AM -0500, Scott Kostyshak wrote: > On Sun, Nov 29, 2020 at 11:23:10PM -0500, Scott Kostyshak wrote: > > On Sun, Nov 29, 2020 at 11:04:59PM +0100, Jean-Marc Lasgouttes wrote: > > > Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : > > > > I see a couple of changes in b

Re: Advanced find changes of behavior in master

2020-11-29 Thread Scott Kostyshak
On Sun, Nov 29, 2020 at 11:23:10PM -0500, Scott Kostyshak wrote: > On Sun, Nov 29, 2020 at 11:04:59PM +0100, Jean-Marc Lasgouttes wrote: > > Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : > > > I see a couple of changes in behavior in advanced find that can be > > > reproduced with the Welcome.ly

Re: Advanced find changes of behavior in master

2020-11-29 Thread Scott Kostyshak
On Sun, Nov 29, 2020 at 11:04:59PM +0100, Jean-Marc Lasgouttes wrote: > Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : > > I see a couple of changes in behavior in advanced find that can be > > reproduced with the Welcome.lyx file (I attached it for convenience). > > > > 1. In advanced find, put

Re: Advanced find changes of behavior in master

2020-11-29 Thread Kornel Benko
Am Sun, 29 Nov 2020 23:04:59 +0100 schrieb Jean-Marc Lasgouttes : > Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : > > I see a couple of changes in behavior in advanced find that can be > > reproduced with the Welcome.lyx file (I attached it for convenience). > > > > 1. In advanced find, put "a

Re: Advanced find changes of behavior in master

2020-11-29 Thread Jean-Marc Lasgouttes
Le 25/11/2020 à 15:35, Scott Kostyshak a écrit : I see a couple of changes in behavior in advanced find that can be reproduced with the Welcome.lyx file (I attached it for convenience). 1. In advanced find, put "a" in the find area and "c" in the replace area and do "Replace all". It takes a

Re: Advanced find changes of behavior in master

2020-11-26 Thread Scott Kostyshak
On Thu, Nov 26, 2020 at 06:26:49PM +0100, Kornel Benko wrote: > Am Thu, 26 Nov 2020 12:01:20 -0500 > schrieb Scott Kostyshak : > > > On Thu, Nov 26, 2020 at 10:35:35AM +0100, Kornel Benko wrote: > > > Am Thu, 26 Nov 2020 10:28:29 +0100 > > > schrieb Kornel Benko : > > > > > > > > 2. In 2.3.0, t

Re: Advanced find changes of behavior in master

2020-11-26 Thread Kornel Benko
Am Thu, 26 Nov 2020 12:01:20 -0500 schrieb Scott Kostyshak : > On Thu, Nov 26, 2020 at 10:35:35AM +0100, Kornel Benko wrote: > > Am Thu, 26 Nov 2020 10:28:29 +0100 > > schrieb Kornel Benko : > > > > > > 2. In 2.3.0, there are more workarea updates. This way, the user can see > > > >what is

Re: Advanced find changes of behavior in master

2020-11-26 Thread Scott Kostyshak
On Thu, Nov 26, 2020 at 10:35:35AM +0100, Kornel Benko wrote: > Am Thu, 26 Nov 2020 10:28:29 +0100 > schrieb Kornel Benko : > > > > 2. In 2.3.0, there are more workarea updates. This way, the user can see > > >what is being replaced and where. In master, there is only one work > > >area up

Re: Advanced find changes of behavior in master

2020-11-26 Thread Scott Kostyshak
On Thu, Nov 26, 2020 at 10:28:29AM +0100, Kornel Benko wrote: > Am Wed, 25 Nov 2020 09:35:31 -0500 > schrieb Scott Kostyshak : > > > I see a couple of changes in behavior in advanced find that can be > > reproduced with the Welcome.lyx file (I attached it for convenience). > > > > 1. In advanced

Re: Advanced find changes of behavior in master

2020-11-26 Thread Kornel Benko
Am Thu, 26 Nov 2020 10:28:29 +0100 schrieb Kornel Benko : > > 2. In 2.3.0, there are more workarea updates. This way, the user can see > >what is being replaced and where. In master, there is only one work > >area update at the end. This seems like an improvement in theory, but > >sinc

Re: Advanced find changes of behavior in master

2020-11-26 Thread Kornel Benko
Am Wed, 25 Nov 2020 09:35:31 -0500 schrieb Scott Kostyshak : > I see a couple of changes in behavior in advanced find that can be > reproduced with the Welcome.lyx file (I attached it for convenience). > > 1. In advanced find, put "a" in the find area and "c" in the replace >area and do "Repl

Advanced find changes of behavior in master

2020-11-25 Thread Scott Kostyshak
I see a couple of changes in behavior in advanced find that can be reproduced with the Welcome.lyx file (I attached it for convenience). 1. In advanced find, put "a" in the find area and "c" in the replace area and do "Replace all". It takes about 10 seconds with 2.3.0, and about 25 seconds