Re: 1.5.X patch candidate list #5

2007-10-08 Thread Jürgen Spitzmüller
Richard Heck wrote: > > Thanks for the explanation; your change makes sense indeed. However, > > let's wait until 1.5.2 is out. > >   > > That's fine. You can backport and commit these now: > http://www.lyx.org/trac/changeset/20437 - Remove redundant > AlignPossible? lines > http://www.lyx.org/t

Re: 1.5.X patch candidate list #5

2007-10-02 Thread Enrico Forestieri
On Tue, Oct 02, 2007 at 08:08:12AM +0200, Jürgen Spitzmüller wrote: > > http://www.lyx.org/trac/changeset/20527 - Make sure that an empty > > po/POTFILES.in file exists at configure time, > > Probably yes. Enrico? It wouldn't hurt but does not make sense, because POTFILES.in is still distributed

Re: 1.5.X patch candidate list #5

2007-10-02 Thread Richard Heck
Jürgen Spitzmüller wrote: Ah, you are talking about section titles only. Then I agree, they shouldn't be changed. (I thought you were about to remove AlignPossible anywhere -- sorry for not reading more closely). No problem. Thanks for the explanation; your change makes sense indeed. However

Re: 1.5.X patch candidate list #5

2007-10-02 Thread Jürgen Spitzmüller
Richard Heck wrote: > Right. But you don't have to do this now. Simply not having an > AlignPossible is equivalent to allowing only the one thing. I see. > > So if it's broken, we should rather fix it than remove it. Note that I'm > > talking out of the blue, however. > >   > > There was a lot of

Re: 1.5.X patch candidate list #5

2007-10-02 Thread Richard Heck
Jürgen Spitzmüller wrote: Richard Heck wrote: Putting this: Align Left AlignPossible Left now has a different effect than it might once have had. Now, doing this allows left alignment to be set explicitly, over-riding whatever the LaTeX class would do. This is probably not the intenti

Re: 1.5.X patch candidate list #5

2007-10-02 Thread Jürgen Spitzmüller
Richard Heck wrote: > Putting this: >     Align Left >     AlignPossible Left > now has a different effect than it might once have had. Now, doing this > allows left alignment to be set explicitly, over-riding whatever the > LaTeX class would do. This is probably not the intention...and it > doesn'

Re: 1.5.X patch candidate list #5

2007-10-02 Thread Richard Heck
Jürgen Spitzmüller wrote: Richard Heck wrote: http://www.lyx.org/trac/changeset/20437 - Remove redundant AlignPossible? lines http://www.lyx.org/trac/changeset/20438 - Disallow setting of alignment in protected environments, where it is broken. Maybe. Jurgen should have a look.

Re: 1.5.X patch candidate list #5

2007-10-01 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > > already approved. However, there were discussions about the > > implementation, so this was postponed to 1.5.3. > > The only potential problem was Mac. But it appeared that Mac won't let > us catch the exception anyway. So it can go in whenever you want. > > Together wi

Re: 1.5.X patch candidate list #5

2007-10-01 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Michael Gerz wrote: Supported by author --- http://www.lyx.org/trac/changeset/20419 - GuiApplication::notify(): don't crash with abort() but exit gracefully when an exception is caught. try to catch LyX specific exceptions. already approved. However,

Re: 1.5.X patch candidate list #5

2007-10-01 Thread Jürgen Spitzmüller
Michael Gerz wrote: > Supported by author > --- > http://www.lyx.org/trac/changeset/20419 - GuiApplication::notify(): > don't crash with abort() but exit gracefully when an exception is > caught. try to catch LyX specific exceptions. already approved. However, there were discussion

Re: 1.5.X patch candidate list #5

2007-10-01 Thread Jürgen Spitzmüller
Richard Heck wrote: > > http://www.lyx.org/trac/changeset/20437 - Remove redundant > > AlignPossible? lines > > http://www.lyx.org/trac/changeset/20438 - Disallow setting of > > alignment in protected environments, where it is broken. > > Maybe. Jurgen should have a look. Could you explain again w

Re: 1.5.X patch candidate list #5

2007-10-01 Thread Martin Vermeer
On Mon, Oct 01, 2007 at 08:09:39PM +0200, Michael Gerz wrote: > Hi, > > the list has become a bit lengthy. Time to filter out useless entries. > > Regards, Michael > > > > > Patch Candidate List #5 > > Approved by Jürgen > -- > > > Supported by author > ---

Re: 1.5.X patch candidate list #5

2007-10-01 Thread Richard Heck
Michael Gerz wrote: New --- http://www.lyx.org/trac/changeset/20437 - Remove redundant AlignPossible? lines http://www.lyx.org/trac/changeset/20438 - Disallow setting of alignment in protected environments, where it is broken. Maybe. Jurgen should have a look. Richard

1.5.X patch candidate list #5

2007-10-01 Thread Michael Gerz
Hi, the list has become a bit lengthy. Time to filter out useless entries. Regards, Michael Patch Candidate List #5 Approved by Jürgen -- Supported by author --- http://www.lyx.org/trac/changeset/20419 - GuiApplication::notify(): don't crash with abort() b