Re: [PATCH] Trivial patch cleaning up code

2007-05-25 Thread José Matos
On Friday 25 May 2007 14:55:55 Abdelrazak Younes wrote: > OK. +1 > Abdel. -- José Abílio

Re: [PATCH] Trivial patch cleaning up code

2007-05-25 Thread Abdelrazak Younes
Richard Heck wrote: And now, with the actual patch. The attached doesn't do much other than code cleanup, and I've inserted some comments about how to fix bug 3440, which I don't propose to do now. There's no actual change to the logic. Indentation will be fixed. Makes the diff hard to read. Se

[PATCH] Trivial patch cleaning up code

2007-05-24 Thread Richard Heck
And now, with the actual patch. The attached doesn't do much other than code cleanup, and I've inserted some comments about how to fix bug 3440, which I don't propose to do now. There's no actual change to the logic. Indentation will be fixed. Makes the diff hard to read. Seeking OK to commit.

Re: [PATCH] Trivial patch cleaning up code

2007-05-24 Thread Bo Peng
no attachment?

[PATCH] Trivial patch cleaning up code

2007-05-24 Thread Richard Heck
The attached doesn't do much other than code cleanup, and I've inserted some comments about how to fix bug 3440, which I don't propose to do now. There's no actual change to the logic. Seeking OK to commit. Richard -- == Richard G

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
Bo Peng wrote: >> I haven't been able to cause a problem after deleting these lines. The >> reason is that the InsetInclude::latex() routine just ignores the >> options, anyway, if we're not dealing with a listings include. The >> advantage to deleting them turns out to be that if you switch from >

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Bo Peng
Hmm, I see. Let's ask Bo about this, as I think he must have added these calls. I haven't been able to cause a problem after deleting these lines. The reason is that the InsetInclude::latex() routine just ignores the options, anyway, if we're not dealing with a listings include. The advantage t

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
José Matos wrote: > On Thursday 24 May 2007 07:28:40 Richard Heck wrote: > >> The attached removes a few pointless calls from QInclude.cpp that do >> nothing but cause a warning to be written to the console. OK to commit? >> > The purpose of the code seems to be resetting the options, if

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread José Matos
On Thursday 24 May 2007 07:28:40 Richard Heck wrote: > The attached removes a few pointless calls from QInclude.cpp that do > nothing but cause a warning to be written to the console. OK to commit? The purpose of the code seems to be resetting the options, if you are sure that it works without

[PATCH] Trivial patch to fix warning

2007-05-23 Thread Richard Heck
The attached removes a few pointless calls from QInclude.cpp that do nothing but cause a warning to be written to the console. OK to commit? rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu

[patch] trivial

2004-02-20 Thread Andre Poenitz
Just renames a function according to lyxStyle(); Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...) ? .lyxfunc.C.swp ? .lyxfunc.h.swp ? 1.diff ? 2.diff ? 3.diff ? fullredraw.diff ?

Re: [patch] trivial fix

2004-02-03 Thread Andre Poenitz
On Tue, Feb 03, 2004 at 09:22:01AM +0100, Alfredo Braunstein wrote: > On Tuesday 03 February 2004 09:19, Andre Poenitz wrote: > > > That was not my doing, was it? > > Easy: do you feel guilty? ;-) Not really. I mean, I do randomly delete stuff, but swapping parameters would be a new dimension.

Re: [patch] trivial fix

2004-02-03 Thread Alfredo Braunstein
On Tuesday 03 February 2004 09:19, Andre Poenitz wrote: > That was not my doing, was it? Easy: do you feel guilty? ;-) I would blame Angus for starting, but there's no friday nearly! Alfredo

Re: [patch] trivial fix

2004-02-03 Thread Andre Poenitz
On Mon, Feb 02, 2004 at 09:46:24PM +0100, Alfredo Braunstein wrote: > Index: lyxfind.C > === > RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfind.C,v > retrieving revision 1.72 > diff -u -p -u -r1.72 lyxfind.C > --- lyxfind.C 31

[patch] trivial fix

2004-02-02 Thread Alfredo Braunstein
Index: lyxfind.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfind.C,v retrieving revision 1.72 diff -u -p -u -r1.72 lyxfind.C --- lyxfind.C 31 Jan 2004 15:30:21 - 1.72 +++ lyxfind.C 2 Feb 2004 20:40:58 - @@ -

Re: [patch] Trivial lyx2lyx bug

2003-02-06 Thread José Matos
On Thursday 06 February 2003 18:35, Angus Leeming wrote: > Index: lib/lyx2lyx/lyx2lyx > === > RCS file: /usr/local/lyx/cvsroot/lyx-devel/lib/lyx2lyx/lyx2lyx,v > retrieving revision 1.5 > diff -u -p -r1.5 lyx2lyx > --- lib/lyx2lyx/lyx2l

[patch] Trivial lyx2lyx bug

2003-02-06 Thread Angus Leeming
Actually allows you to set the debug level. -- Angus Index: lib/lyx2lyx/lyx2lyx === RCS file: /usr/local/lyx/cvsroot/lyx-devel/lib/lyx2lyx/lyx2lyx,v retrieving revision 1.5 diff -u -p -r1.5 lyx2lyx --- lib/lyx2lyx/lyx2lyx 7 Jan 2003

Re: [PATCH] Trivial stuff (mathed & mouse wheel scrolling)

2003-01-13 Thread Andre Poenitz
On Mon, Jan 13, 2003 at 11:09:11AM +, Angus Leeming wrote: > >2. Make CTRL-Pos1/End behave a little bit more intuitive > > (Patch suggested by Andre) > > I won't commit this but leave it for André. (Insufficient knowledge.) I haven't seen the patch, but if this is 'go left instead o

Re: [PATCH] Trivial stuff (mathed & mouse wheel scrolling)

2003-01-13 Thread Angus Leeming
On Thursday 09 January 2003 7:16 pm, Michael Schmitt wrote: > Dear Lars, Jean-Marc, > > please apply the following two patches: > >1. Change default value and description of mouse wheel jump > (John thinks it is OK) I'll commit this. >2. Make CTRL-Pos1/End behave a little bit more i

[PATCH] Trivial stuff (mathed & mouse wheel scrolling)

2003-01-09 Thread Michael Schmitt
Dear Lars, Jean-Marc, please apply the following two patches: 1. Change default value and description of mouse wheel jump (John thinks it is OK) 2. Make CTRL-Pos1/End behave a little bit more intuitive (Patch suggested by Andre) Michael Index: lyx-devel-1_3_X//src/ChangeLog ==

Re: [PATCH]: trivial fix for bug #415.

2002-07-10 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> On Friday 31 May 2002 2:19 am, John Levon wrote: >> On Tue, May 21, 2002 at 11:12:52AM +0100, Angus Leeming wrote: > >> See attached. >> >> So are you going to apply this to 1.2 branch ? Angus> Nope. I don't have a 1.2 tree at th

Re: [PATCH]: trivial fix for bug #415.

2002-07-10 Thread Angus Leeming
On Friday 31 May 2002 2:19 am, John Levon wrote: > On Tue, May 21, 2002 at 11:12:52AM +0100, Angus Leeming wrote: > > See attached. > > So are you going to apply this to 1.2 branch ? Nope. I don't have a 1.2 tree at the moment. A

Re: [PATCH]: trivial fix for bug #415.

2002-06-03 Thread Allan Rae
On Wed, 29 May 2002, Stephan Witt wrote: [...] > > | Now that libsigc++ is more wide spread (ie. when it was included few > > | major distros had a useful version of it) I want to remove it from the > > | dist -- whether we require it for all signals or just for the gtk > > | stuff. > > > > It see

Re: [PATCH]: trivial fix for bug #415.

2002-05-31 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Tue, May 21, 2002 at 11:12:52AM +0100, Angus Leeming wrote: >> See attached. John> So are you going to apply this to 1.2 branch ? I am doing it. JMarc

Re: [PATCH]: trivial fix for bug #415.

2002-05-30 Thread John Levon
On Tue, May 21, 2002 at 11:12:52AM +0100, Angus Leeming wrote: > See attached. So are you going to apply this to 1.2 branch ? regards john -- "Do you mean to tell me that "The Prince" is not the set textbook for CS1072 Professional Issues ? What on earth do you learn in that course ?"

Re: [PATCH]: trivial fix for bug #415.

2002-05-29 Thread Stephan Witt
Lars Gullik Bjønnes wrote: > Allan Rae <[EMAIL PROTECTED]> writes: > > | On Wed, 22 May 2002, Lars Gullik Bjønnes wrote: > >>>Boost signals however delegates creation of functions objects and >>>binding to two other libs, with sigc++ this is integrated in the >>>signal/slot code. >>> > | Not qu

Re: [PATCH]: trivial fix for bug #415.

2002-05-29 Thread Lars Gullik Bjønnes
Allan Rae <[EMAIL PROTECTED]> writes: | On Wed, 22 May 2002, Lars Gullik Bjønnes wrote: > >> Boost signals however delegates creation of functions objects and >> binding to two other libs, with sigc++ this is integrated in the >> signal/slot code. > | Not quite as nice then. What is not quite as

Re: [PATCH]: trivial fix for bug #415.

2002-05-28 Thread Allan Rae
On Wed, 22 May 2002, Lars Gullik Bjønnes wrote: > Boost signals however delegates creation of functions objects and > binding to two other libs, with sigc++ this is integrated in the > signal/slot code. Not quite as nice then. > Am I correct in beliving that gtkmm cannot exist without sigc++, a

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Michael Koziarski
> >Am I correct in beliving that gtkmm cannot exist without sigc++, and >that if gtkmm is installed then a libsigc++ will also be installed? >(so we won't have to provide sigc++ with lyx as we do now) Yes. Gtkmm uses libsigc++ throughout, it won't build or install without it. So, if you do de

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Lars Gullik Bjønnes
Michael Koziarski <[EMAIL PROTECTED]> writes: >> >>| I'd like to do the following: >>| - upgrade of libsigc version to 1.4/1.3 whatever the release version >>| ends up getting called. >> >>I am a bit ambivalent about this one... it might be easier to just use >>the boost signal/slot library in th

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Michael Koziarski
> >| I'd like to do the following: >| - upgrade of libsigc version to 1.4/1.3 whatever the release version >| ends up getting called. > >I am a bit ambivalent about this one... it might be easier to just use >the boost signal/slot library in the core or lyx, and ... > >| - Gtkmm2 frontend. > >...

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Lars Gullik Bjønnes
Michael Koziarski <[EMAIL PROTECTED]> writes: | At 02:29 PM 5/21/02 +0200, you wrote: >>Andre Poenitz <[EMAIL PROTECTED]> writes: >> >>| On Tue, May 21, 2002 at 01:22:39PM +0100, Angus Leeming wrote: >> >> Why thank you, sir. While you're at it, why don't you give me >> permission to >> >> set up

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Michael Koziarski
At 02:29 PM 5/21/02 +0200, you wrote: >Andre Poenitz <[EMAIL PROTECTED]> writes: > >| On Tue, May 21, 2002 at 01:22:39PM +0100, Angus Leeming wrote: > >> Why thank you, sir. While you're at it, why don't you give me > permission to > >> set up a branch. Let's call it BRANCH_guii. I guess that at

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread John Levon
On Tue, May 21, 2002 at 02:29:42PM +0200, Lars Gullik Bjønnes wrote: > If everybody is off working on his pet branch we will not be able to > do much... OK We've had Andre's list. My list : o GUII o bug fixes Simple eh :) john -- "SirCam: Hi! How are you? Eliza: Why are you

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Angus Leeming
On Tuesday 21 May 2002 1:29 pm, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > | On Tue, May 21, 2002 at 01:22:39PM +0100, Angus Leeming wrote: > >> Why thank you, sir. While you're at it, why don't you give me permission > >> to set up a branch. Let's call it BRANCH_guii

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Juergen Vigna
On 21-May-2002 Lars Gullik Bjønnes wrote: > Let's get that list going. First of all I don't know how much time I will have for LyX in future. Second to tell you the truth for 1.3.0 I plan to ONLY work on GUII complete. IMO that should be our only "real" 1.3.0 worklist so that we can release a 1

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Andre Poenitz
On Tue, May 21, 2002 at 02:29:42PM +0200, Lars Gullik Bjønnes wrote: > Can we please have a run down of what features to work on in 1.3.0CVS > first. > > Let's get that list going. I've posted "my part" already. Andre' -- Those who desire to give up Freedom in order to gain Security, will not

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, May 21, 2002 at 01:22:39PM +0100, Angus Leeming wrote: >> Why thank you, sir. While you're at it, why don't you give me permission to >> set up a branch. Let's call it BRANCH_guii. I guess that at least John and I >> should have permission to

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Andre Poenitz
On Tue, May 21, 2002 at 01:22:39PM +0100, Angus Leeming wrote: > Why thank you, sir. While you're at it, why don't you give me permission to > set up a branch. Let's call it BRANCH_guii. I guess that at least John and I > should have permission to commit. And if you are at it: What about some B

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Angus Leeming
On Tuesday 21 May 2002 1:02 pm, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > | On Tuesday 21 May 2002 11:24 am, Lars Gullik Bjønnes wrote: > >> Angus Leeming <[EMAIL PROTECTED]> writes: > >> | See attached. > >> | Angus > >> > >> Put in 1.3.0CVS, queue for 1.2.1. > | >

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Tuesday 21 May 2002 11:24 am, Lars Gullik Bjønnes wrote: >> Angus Leeming <[EMAIL PROTECTED]> writes: >> | See attached. >> | Angus >> >> Put in 1.3.0CVS, queue for 1.2.1. > | You'll need to give me some karma to commit it. While you're at it, just

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Angus Leeming
On Tuesday 21 May 2002 11:24 am, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > | See attached. > | Angus > > Put in 1.3.0CVS, queue for 1.2.1. You'll need to give me some karma to commit it. While you're at it, just shove it in. Angus

Re: [PATCH]: trivial fix for bug #415.

2002-05-21 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | See attached. | Angus Put in 1.3.0CVS, queue for 1.2.1. -- Lgb

[PATCH]: trivial fix for bug #415.

2002-05-21 Thread Angus Leeming
See attached. Angus Index: src/frontends/controllers/ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/controllers/ChangeLog,v retrieving revision 1.173 diff -u -p -r1.173 ChangeLog --- src/frontends/controllers

Re: [PATCH] trivial mathed patch

2002-01-07 Thread Angus Leeming
On Monday 07 January 2002 3:10 pm, Andre Poenitz wrote: [snip] > Please send me a complete list, otherwise I'll probably get a similar one > from Jean-Marc at some poitn of time ;-} Ok. Recompiling now. I'll post you the (edited) make log privately to save others' bandwidth. Never fear, it won'

Re: [PATCH] trivial mathed patch

2002-01-07 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> Please send me a complete list, otherwise I'll probably get a Andre> similar one from Jean-Marc at some poitn of time ;-} Not soon. I can will only compile on cxx if explicitely requested to, until september. So Angus is probably

Re: [PATCH] trivial mathed patch

2002-01-07 Thread Andre Poenitz
On Mon, Jan 07, 2002 at 12:40:09PM +, Angus Leeming wrote: > André, > > here is a trivial patch for mathed. Applied. > I also get lots and lots of warning messages so: > > cxx: Warning: math_scriptinset.h, line 37: #610-D > "int MathScriptInset::ascent(const MathInset *) const" d

[PATCH] trivial mathed patch

2002-01-07 Thread Angus Leeming
André, here is a trivial patch for mathed. I also get lots and lots of warning messages so: cxx: Warning: math_scriptinset.h, line 37: #610-D "int MathScriptInset::ascent(const MathInset *) const" does not match "MathInset::ascent" -- virtual function override intended?