Jürgen Spitzmüller schrieb:
HSpace("default") works, so you can simplify the above code to...
Done.
- // remove the %-items from the unit choice
- textLayoutModule->skipLengthCO->noPercents();
I think you should do this in a separate step.
Done. This went in as separate file
Uwe Stöhr wrote:
> This is now done in the attached patch.
The patch looks good now, Uwe.
Just some final nitpicks (none of them prevent the patch from being committed,
though, given that you add a file format change and lyx2lyx routine)
> + } else if (token == "\\paragraph_indentation") {
Jürgen Spitzmüller schrieb:
No, you probably misunderstood me. I suggested a HSpace class.
This is now done in the attached patch.
+ // "0" is the case for a new document
Then something is wrong. You have to initialize HSpace to default.
> But if you set up a HSpace class, th
Uwe Stöhr wrote:
> >> My patch is ready to go in I think. The only thing that is missing is
> >> visual feedback for the indentation width. As LyX source code is not
> >
> > you have totally ignored my previous questions, and i'm especially
> > interested in the first one.
>
> What do you mean? Eve
Uwe Stöhr wrote:
> Jürgen Spitzmüller schrieb:
> >> + Length indentation;
> >
> > Why not HSpace indentation?
>
> The last email you suggested to introduce an HspaceKind enum to Length, now
> I should leave Length untouched but introduce an HSpace class.
No, you probably misunderstood me. I
Jürgen Spitzmüller schrieb:
+ Length indentation;
Why not HSpace indentation?
The last email you suggested to introduce an HspaceKind enum to Length, now I should leave Length
untouched but introduce an HSpace class. I don't have time right now to play longer with this issue.
Please t
>> My patch is ready to go in I think. The only thing that is missing is
>> visual feedback for the indentation width. As LyX source code is not
>
> you have totally ignored my previous questions, and i'm especially
> interested in the first one.
What do you mean? Everything you mentioned in
htt
Uwe Stöhr wrote:
> My patch is ready to go in I think. The only thing that is missing is
> visual feedback for the indentation width. As LyX source code is not
you have totally ignored my previous questions, and i'm especially
interested in the first one.
pavel
Uwe Stöhr wrote:
> Index: BufferParams.cpp
> ===
> --- BufferParams.cpp(revision 30639)
> +++ BufferParams.cpp(working copy)
> @@ -289,6 +289,7 @@
> /** This is the amount of space used for paragraph_separation
> "skip"
> AFAICS, you have not defined a default length, but a default unit. This might
> be confused with the already used defaultUnit(), and it doesn't look like a
> clean solution.
>
> The by far best method, I think, would be to setup a HSpace class similar to
> the VSpace class. This class could inhe
Uwe Stöhr wrote:
> > It strikes me wrong to do this in the frontend.
>
> > Probably in Buffer::readHeader(Lexer & lex)?
>
> I don't understand. I should enable widgets and set default values for the
> dialog not in GuiDocument?
No, I suspect this resetting is not necessary if the parameters are c
> The by far best method, I think, would be to setup a HSpace class similar to
> the VSpace class.
OK, I'll try this.
>> + } else if (token == "\\paragraph_indentation") {
>> + lex.next();
>> + string indentation = lex.getString();
>> + if (indenta
Uwe Stöhr wrote:
> Uwe Stöhr schrieb:
>
>> OK, I'll implement this and send a new patch.
>
> Here is the patch.
i hoped that fixing this bug i would be able to set the whole document
paragraph indent to 0. but this didn't happened, when i set 0 it remains
as it was, adding negative number is of no
Uwe Stöhr wrote:
> Here is the patch.
Thanks, it looks better. There are still some things to be considered, though.
> To be able to set a default value, I introduced a new unit for Length. I
> cannot think of another solution because using a real length to mark that
> the user wants the default
Uwe Stöhr schrieb:
OK, I'll implement this and send a new patch.
Here is the patch.
To be able to set a default value, I introduced a new unit for Length. I cannot think of another
solution because using a real length to mark that the user wants the default is not possible, since
every set w
Uwe Stöhr wrote:
> > Uwe, is this connected to http://www.lyx.org/trac/ticket/1655 ?
> > (i was planning to look on that feature).
>
> Yes. I had an unfinished patch since about a year and your recent bug
> comment remind me to finish it.
ok i wait for next patch for testing.
pavel
> Uwe, is this connected to http://www.lyx.org/trac/ticket/1655 ?
> (i was planning to look on that feature).
Yes. I had an unfinished patch since about a year and your recent bug comment
remind me to finish it.
regards Uwe
> Uwe, is this connected to http://www.lyx.org/trac/ticket/1655 ?
> (i was planning to look on that feature).
Yes. I had an unfinished patch since about a year and your recent bug comment
remind me to finish it.
regards Uwe
Am Dienstag 14 Juli 2009 13:37:34 schrieben Sie:
> > But why do you use a VSpace here? The indendation is a horizontal space.
> > As
>
> > long as you do not want to do fancy things, I guess a Length would be
> more > suitable.
>
> Because all other width in GuiDocument also uses VSpace, see for e
Uwe Stöhr wrote:
> The attached patch adds the feature to specify the width of the paragraph
> indentation. This will be a fileformat change.
Uwe, is this connected to http://www.lyx.org/trac/ticket/1655 ?
(i was planning to look on that feature).
pavel
> But why do you use a VSpace here? The indendation is a horizontal space. As
> long as you do not want to do fancy things, I guess a Length would be more
> suitable.
Because all other width in GuiDocument also uses VSpace, see for example the margins. I want to
avoid to introduce new code if no
Uwe Stöhr wrote:
> + string indentation = bp_.getIndentation().asLyXCommand();
> + if (indentation == "defskip")
> + //set LaTeX's default indentation of 30 pt
> + indentation = "30 pt";
>
> I failed to figured out how to set the default val
The attached patch adds the feature to specify the width of the paragraph indentation. This will be
a fileformat change.
Everything works fine so far (tested since a few days), the only thing I don't understand is why I
have to use this hack:
+ string indentation = bp_.getIndentation().asLyXC
23 matches
Mail list logo
