Jürgen Spitzmüller schrieb:
HSpace("default") works, so you can simplify the above code to...
Done.
- // remove the %-items from the unit choice
- textLayoutModule->skipLengthCO->noPercents();
I think you should do this in a separate step.
Done. This went in as separate file format change.
More LyXish style would be...
Done.
+ string indentation = bp_.getIndentation().asLyXCommand();
+ int indent = 0;
+ if (indentation == "default")
+ indent = 0;
the if clause strikes me redundant. indent is already 0. So
+ else {
+ if (indentation != "default") {
Done.
Index: src/TextMetrics.cpp
Your indendation change doesn't conform the coding style...
I reverted this.
The patch is now in.
regards Uwe