Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-29 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: I could do this, I just only wanted to change less as possible. I yesterday had a look at the packages and it indeed shouldn't harm to load color always before babel, as this problem could also occur with other packages that users might load in the preamble, not onl

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-29 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > But why do we use it then for babel? The babel code (language names) > > also contains only ASCII characters? > > It is probably an oversight. right. As I wrote, there may be occurences of from_utf8 where from_ascii is sufficient. But think carefully. Sometimes asc

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-29 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: >> The reason for the two calls is that from_utf8 is rather expensive, so we use >> the much faster from_ascii whereever possible. As soon as a non-ascii >> character is expected, we have to use from_utf8. > > But why do we use it then for babel? The babel cod

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-29 Thread Uwe Stöhr
> The reason for the two calls is that from_utf8 is rather expensive, so we use > the much faster from_ascii whereever possible. As soon as a non-ascii > character is expected, we have to use from_utf8. But why do we use it then for babel? The babel code (language names) also contains only ASCII

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-29 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: >> Why don't you load it always before babel, then? Is there a reason for >> having two cases? > > I could do this, I just only wanted to change less as possible. I > yesterday had a look at the packages and it indeed shouldn't harm to > load color always befor

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-29 Thread Uwe Stöhr
Jean-Marc Lasgouttes schrieb: Why don't you load it always before babel, then? Is there a reason for having two cases? I could do this, I just only wanted to change less as possible. I yesterday had a look at the packages and it indeed shouldn't harm to load color always before babel, as this

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-29 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: > When using hyperref with the option colorlinks (that we support), > hyperref loads the color package \AtBeginDocument. But babel loads it > too \AtBeginDocument, so that is not loaded when babel defined > shorthand characters. Thus document with the language

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-28 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > Do you prefer from_ascii for all calls? No, I prefer from_ascii for all calls where we are sure that no characters beyond the ascii range are involved. The reason for the two calls is that from_utf8 is rather expensive, so we use the much faster from_ascii whereever possible.

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-28 Thread Uwe Stöhr
> Is the from_ascii -> from_utf8 change necessary? Currently we use from_utf8 and from_ascii inconsistently in BufferParams.cpp: when calling babel we use from_utf8 for the other packages from_ascii. But LaTeXFeatures::getPackages(), LaTeXFeatures::getMacros(), and LaTeXFeatures::getBabelOption

Re: [patch] make documents compilable that use hyperref and colorlinks

2008-09-28 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > The attached patch implements this. To be able to do that, I needed to > handle the color packages [x]color and pdfcolmk in a separate routine in > LaTeXParams.cpp. Is the from_ascii -> from_utf8 change necessary? Jürgen

[patch] make documents compilable that use hyperref and colorlinks

2008-09-27 Thread Uwe Stöhr
When using hyperref with the option colorlinks (that we support), hyperref loads the color package \AtBeginDocument. But babel loads it too \AtBeginDocument, so that is not loaded when babel defined shorthand characters. Thus document with the languages Esperanto, Slovak, and some others are not