Re: [patch] gbox

2004-11-22 Thread Andre Poenitz
On Mon, Nov 22, 2004 at 10:56:57AM +0100, Jean-Marc Lasgouttes wrote: > I am not sure about that. It seems to me that the types eventually > resolve to unsigned int: > http://www.gtkmm.org/gtkmm2/docs/reference/html/classGtk_1_1TreeModel.html > http://www.gtkmm.org/gtkmm2/docs/reference/html/classG

Re: [patch] gbox

2004-11-22 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Fri, Nov 19, 2004 at 02:28:25PM +0100, Juergen Spitzmueller Andre> wrote: >> The attached patch shuts up a few compiler warnings. John, please >> have a look. I didn't test this very much. Andre> Please use 'size_t' instead of '

Re: [patch] gbox

2004-11-20 Thread Andre Poenitz
On Fri, Nov 19, 2004 at 02:28:25PM +0100, Juergen Spitzmueller wrote: > The attached patch shuts up a few compiler warnings. John, please > have a look. I didn't test this very much. Please use 'size_t' instead of 'unsigned' for vector postitions. It's the 'proper' type, not only wrt to signednes

Re: [patch] gbox

2004-11-20 Thread John Spray
On Fri, 2004-11-19 at 14:28 +0100, Juergen Spitzmueller wrote: > The attached patch shuts up a few compiler warnings. John, please have a > look. > I didn't test this very much. I've applied this now. John

Re: [patch] gbox

2004-11-19 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> Hmm. Is comparing an "unsigned int" with an "unsigned long int" John> going to screw things up, or will the compiler handle it? I John> don't have any experience of these issues. Well, in practice, I doubt that this really matters. Usin

Re: [patch] gbox

2004-11-19 Thread John Spray
On Fri, 2004-11-19 at 13:49, Jean-Marc Lasgouttes wrote: > >From the gtk-- reference, it seems that the right type is > GTK::ListStore::Children::size_type, but I understand this is wordy. > > Actually, it makes a big difference in the rest of LyX since > std::size_type is not unsigned int on 64b

Re: [patch] gbox

2004-11-19 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> The attached patch shuts up a few compiler warnings. John, Juergen> please have a look. I didn't test this very much. I do not like much lines like: - for (int j = 0; j < heightunitscombo_->get_model()->c

Re: [patch] gbox

2004-11-19 Thread John Spray
On Fri, 2004-11-19 at 13:28, Juergen Spitzmueller wrote: > The attached patch shuts up a few compiler warnings. John, please have a > look. > I didn't test this very much. Looks good to me. Thanks, I was planning to come back to those warnings at some point but now I don't have to :-) John

[patch] gbox

2004-11-19 Thread Juergen Spitzmueller
The attached patch shuts up a few compiler warnings. John, please have a look. I didn't test this very much. Regards, Jürgen Index: GBox.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/gtk/GBox.C,v retrieving revision