>>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:

Juergen> The attached patch shuts up a few compiler warnings. John,
Juergen> please have a look. I didn't test this very much.

I do not like much lines like:

-               for (int j = 0; j < 
heightunitscombo_->get_model()->children().size(); ++j) {
+               for (unsigned int j = 0; j < 
heightunitscombo_->get_model()->children().size(); ++j) {

>From the gtk-- reference, it seems that the right type is
GTK::ListStore::Children::size_type, but I understand this is wordy. 

Actually, it makes a big difference in the rest of LyX since
std::size_type is not unsigned int on 64bits architectures (but
unsigned long int). But since gtk-- uses unsigned int
unconditionally for this type, I guess it's up to you, John.

JMarc

Reply via email to