Re: [patch] fix bug 75

2007-12-09 Thread Jürgen Spitzmüller
Martin Vermeer wrote: > Another question (probably stupid): if " is made an active > character, can one even use it as a quote without escaping? No. However, you can deactivate it with shorthandsoff, so real support can become really complicated. Jürgen

Re: [patch] fix bug 75

2007-12-09 Thread Martin Vermeer
On Sun, Dec 09, 2007 at 06:29:22PM +0100, Jürgen Spitzmüller wrote: > Uwe Stöhr wrote: > > OK, then I retract my patch. Importing " always as ERT is no good solution, > > because in modern documents the "bla commands are rarely used. So I guess > > in 90% of the cases " is a quotation mark. > > Wh

Re: [patch] fix bug 75

2007-12-09 Thread Jean-Marc Lasgouttes
Uwe Stöhr <[EMAIL PROTECTED]> writes: >> I'd like to add that finding a solution without additional global variables >> is *much* preferred. > > This is not possible. The document language is examined in > preamble.cpp an must be used later in text.cpp too. The document language is not really re

Re: [patch] fix bug 75

2007-12-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > OK, then I retract my patch. Importing " always as ERT is no good solution, > because in modern documents the "bla commands are rarely used. So I guess > in 90% of the cases " is a quotation mark. Why do you think so? On the contrary, I think they are very frequently used. Jürg

Re: [patch] fix bug 75

2007-12-09 Thread Uwe Stöhr
Jürgen Spitzmüller schrieb: I see. But then the fix has to be more general, and " has to be imported always as ERT for (n)german. The same problem occurs with all shortcuts: OK, then I retract my patch. Importing " always as ERT is no good solution, because in modern documents the "bla comman

Re: [patch] fix bug 75

2007-12-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > - Take your example file you uploaded to the bug report > - export it to LaTeX (plain) > - import it via tex2lyx > -> You can see that the "= stuff must be imported as ERT to get the same > output as before. Currently it is imported as ''= which prevents the > correct output. I

Re: [patch] fix bug 75

2007-12-09 Thread Uwe Stöhr
> I have just uploaded a testcase that demonstrates why this bug report is > INVALID. The bug is not invalid, but its description was incorrect. - Take your example file you uploaded to the bug report - export it to LaTeX (plain) - import it via tex2lyx -> You can see that the "= stuff must be im

Re: [patch] fix bug 75

2007-12-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > I haven't said that it is converted to \-, but to - > Look at http://bugzilla.lyx.org/show_bug.cgi?id=75 I have just uploaded a testcase that demonstrates why this bug report is INVALID. Jürgen

Re: [patch] fix bug 75

2007-12-09 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > This is wrong. "= and \- are not equivalent. Sorry, I mean: "= and '-' are not equivalent. Jürgen

Re: [patch] fix bug 75

2007-12-09 Thread Uwe Stöhr
Jürgen Spitzmüller schrieb: To a hyphenation "-". Bug 75 explains that this is only valid for German. This is wrong. "= and \- are not equivalent. I haven't said that it is converted to \-, but to - Look at http://bugzilla.lyx.org/show_bug.cgi?id=75 regards Uwe

Re: [patch] fix bug 75

2007-12-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > To a hyphenation "-". Bug 75 explains that this is only valid for German. This is wrong. "= and \- are not equivalent. Jürgen

Re: [patch] fix bug 75

2007-12-09 Thread Uwe Stöhr
> Shouldn't global variables be declared in tex2lyx.h and defined in tex2lyx.cpp? I used the existing infrastructure. I discussed this topic with Jürgen and he pointed me to the existing extern varaibles. There is for example another variable declared and filled in preamble.cpp that is used in

Re: [patch] fix bug 75

2007-12-09 Thread Uwe Stöhr
> To what is this command transferred? To a hyphenation "-". Bug 75 explains that this is only valid for German. The patch is trivial, so also OK for branch? regards Uwe

Re: [patch] fix bug 75

2007-12-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > The attached patch adds support for the German babel hyphenation command: > "= To what is this command transferred? Jürgen

Re: [patch] fix bug 75

2007-12-08 Thread Abdelrazak Younes
Angus Leeming wrote: Uwe Stöhr wrote: take this attached correct patch. regards Uwe Shouldn't global variables be declared in tex2lyx.h and defined in tex2lyx.cpp? I'd like to add that finding a solution without additional global variables is *much* preferred. Abdel.

Re: [patch] fix bug 75

2007-12-08 Thread Angus Leeming
Uwe Stöhr wrote: take this attached correct patch. regards Uwe Shouldn't global variables be declared in tex2lyx.h and defined in tex2lyx.cpp? Angus

Re: [patch] fix bug 75

2007-12-08 Thread Uwe Stöhr
take this attached correct patch. regards Uwe Index: preamble.cpp === --- preamble.cpp (revision 22027) +++ preamble.cpp (working copy) @@ -48,6 +48,9 @@ // special columntypes extern std::map special_columns; +// store the docum

[patch] fix bug 75

2007-12-08 Thread Uwe Stöhr
The attached patch adds support for the German babel hyphenation command: "= regards Uwe Index: preamble.cpp === --- preamble.cpp (revision 22027) +++ preamble.cpp (working copy) @@ -48,6 +48,9 @@ // special columntypes extern std: