Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread José Matos
On Monday 04 June 2007 16:00:50 Jürgen Spitzmüller wrote: > José? > > Jürgen OK. -- José Abílio

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread Michael Gerz
Jürgen Spitzmüller schrieb: BTW, why to we have a 'Type' label below the float type selector?? This should be removed, the more so as it breaks shortcuts in the main window. Shall I do it? Yes, please remove it. Michael

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > >> BTW, why to we have a 'Type' label below the float type selector?? > > Jürgen> This should be removed, the more so as it breaks shortcuts in > Jürgen> the main window. Shall I do it? > > Yes please. José? Jürgen

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Monday 04 June 2007 10:19:11 Jean-Marc Lasgouttes wrote: >> Another OK someone? José> +1 Done. JMarc

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread José Matos
On Monday 04 June 2007 10:19:11 Jean-Marc Lasgouttes wrote: > Another OK someone? +1 -- José Abílio

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Jean-Marc Lasgouttes wrote: >> The real fix is in TocWidget.cpp, where we are trying to translate >> a string that is already translated. >> >> The change in ControlToc.h makes sure that we never call >> getGUIName. >> >> T

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > The real fix is in TocWidget.cpp, where we are trying to translate a > string that is already translated. > > The change in ControlToc.h makes sure that we never call getGUIName. > > The change in ControlToc.cpp uses properly Floating::listName instead > of Floating::n

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-04 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Jean-Marc Lasgouttes wrote: >> No, I think the right fix is to use this instead in the caller: Jürgen> I don't understand. OK, my guess was not right. Patch attached. The real fix is in TocWidget.cpp, where we are trying

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-03 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > No, I think the right fix is to use this instead in the caller: I don't understand. Jürgen

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-03 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> http://bugzilla.lyx.org/show_bug.cgi?id=3793 This crash only Jürgen> happens when you use a language that has non-ascii chars in a Jürgen> message (such as fr_FR: "Table des Matières" in the reported Jürgen> case) Jürgen> Th

Re: [patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-03 Thread Richard Heck
Jürgen Spitzmüller wrote: http://bugzilla.lyx.org/show_bug.cgi?id=3793 This crash only happens when you use a language that has non-ascii chars in a message (such as fr_FR: "Table des Matières" in the reported case) The fix seems straightforward to me. And to me. OK to apply? So far

[patch] fix bug 3793: Lyx-1.5.0rc1 seg fault when clicking on toc from help

2007-06-03 Thread Jürgen Spitzmüller
http://bugzilla.lyx.org/show_bug.cgi?id=3793 This crash only happens when you use a language that has non-ascii chars in a message (such as fr_FR: "Table des Matières" in the reported case) The fix seems straightforward to me. OK to apply? Jürgen Index: src/Messages.cpp ===