Re: [patch] fix bug 2637

2006-08-13 Thread Georg Baum
Am Sonntag, 13. August 2006 19:49 schrieb Jean-Marc Lasgouttes: > I like the principle of the patch, and refactoring is good. Go for it. Done. > You forgot to update the comment on top of build_script > > @@ -136,7 +136,7 @@ namespace { > /** Build the conversion script, returning true if abl

Re: [patch] fix bug 2637

2006-08-13 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I came up with the attached patch instead. It does not look Georg> well either, but most of the changes are only code refactoring Georg> (see log). Georg> This works for me and is going in tomorrow if nobody objects. I like the princ

Re: [patch] fix bug 2637

2006-08-13 Thread Georg Baum
Am Samstag, 12. August 2006 15:23 schrieb Jean-Marc Lasgouttes: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> My idea is to move all special casing for convertDefault.py to > Georg> Converters::getPath. Converters::getPath would then get an > Georg> additional bool argument

Re: [patch] fix bug 2637

2006-08-12 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> My idea is to move all special casing for convertDefault.py to Georg> Converters::getPath. Converters::getPath would then get an Georg> additional bool argument try_default (like Converters::convert Georg> already has). convertDefault.

Re: [patch] fix bug 2637

2006-08-12 Thread Georg Baum
Am Samstag, 12. August 2006 00:46 schrieb Jean-Marc Lasgouttes: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> Here comes my long promised fix for bug 2637 (graphics files > Georg> with ' in the name can't be previewed). > > Georg, do you think this should go to 1.4? Yes. T

Re: [patch] fix bug 2637

2006-08-11 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Here comes my long promised fix for bug 2637 (graphics files Georg> with ' in the name can't be previewed). Georg> My first idea was to copy the graphics file to the buffer temp Georg> dir, using the same mangled name that will be use

[patch] fix bug 2637

2006-07-12 Thread Georg Baum
Here comes my long promised fix for bug 2637 (graphics files with ' in the name can't be previewed). My first idea was to copy the graphics file to the buffer temp dir, using the same mangled name that will be used when running latex, and then running the conversion chain on that file. The advanta