>>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:

Georg> I came up with the attached patch instead. It does not look
Georg> well either, but most of the changes are only code refactoring
Georg> (see log).

Georg> This works for me and is going in tomorrow if nobody objects.

I like the principle of the patch, and refactoring is good. Go for it.

You forgot to update the comment on top of build_script

@@ -136,7 +136,7 @@ namespace {
 /** Build the conversion script, returning true if able to build it.
  *  The script is output to the ostringstream 'script'.
  */
-bool build_script(string const & from_file, string const & to_file_base,
+void build_script(string const & from_file, string const & to_file_base,

JMarc

Reply via email to