Re: [patch] fix bug 1520 and 2268

2007-10-22 Thread Uwe Stöhr
Andre Poenitz schrieb: -namespace lyx { +namespace lyx { No need for extra whitespace at the end of the line. This went in by accident, fixed in the meantime. -void PDFOptions::writeLaTeX(odocstringstream &os) const +void PDFOptions::writeLaTeX(odocstringstream &os, bool hyper) const

Re: [patch] fix bug 1520 and 2268

2007-10-15 Thread Andre Poenitz
On Sat, Oct 13, 2007 at 05:40:50AM +0200, Uwe Stöhr wrote: > Attached is a patch that gets rid of the ancient docbook "htmlurl" type > (bug 1520). > With the patch the checkbox in the URL-dialog uses now \href, so people can > now switch between a printed URL and a hyperlinked URL (bug 2268). >

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Uwe Stöhr
The bug is still in LyX: - open the German Intro manual, or the LateXConfig manual -> Crash: Assertion triggered in __thiscall lyx::InsetCommandParams::InsetCommandParams(co nst class std::basic_string,class std::alloca tor > &) by failing check "info_" in file D:\LyXSVN\lyx-devel\src\insets\I

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Richard Heck
Uwe Stöhr wrote: It would help me very much if you could do this part. I committed my patch in the way you wanted to have it now. Al that needs to be done now is to correct the lyx2lyx function "convert_htmlurl". OK. The crash you got was due to a missed change elsewhere. Thanks for fixing t

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Uwe Stöhr
Richard Heck schrieb: obviously, and lyx2lyx written to convert the old URL insets into URL charstyles for LaTeX documents only. >> How would this be? > I can do this part if you like. It shouldn't be too bad. It would help me very much if you could do this part. I committed my patch in th

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Richard Heck
Uwe Stöhr wrote: Richard Heck schrieb: There's a different solution for this now. First of all, URL now exists as a charstyle, importable via the URL module. But what LaTeX-code does it use? \url{whatever's in the inset}. So support for \url is no longer needed as an inset, and it really sho

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Uwe Stöhr
Richard Heck schrieb: There's a different solution for this now. First of all, URL now exists as a charstyle, importable via the URL module. But what LaTeX-code does it use? So support for \url is no longer needed as an inset, and it really shouldn't be an inset. It's semantic markup. The U

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Richard Heck
Uwe Stöhr wrote: > Well, I'm not sure José's gonna love you for simply killing docbook here (and > also for attributing docbook "ancient"). > > Seriously, why do you touch docbook at all? Oops, yes indeed I mixed this up with the removal of linuxdoc/sgml. Richard also havent't touched docbook

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Pavel Sanda
> - if (hyperlinkCB->isChecked()) > - params_.setCmdName("htmlurl"); > + if (hyperlinkCB->checkState() == Qt::Checked) > + params_.setCmdName("href"); more question than objection - whats the reason for checkState() == Qt::Checked instead isChecked() ? pavel

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Uwe Stöhr
> Well, I'm not sure José's gonna love you for simply killing docbook here (and > also for attributing docbook "ancient"). > > Seriously, why do you touch docbook at all? Oops, yes indeed I mixed this up with the removal of linuxdoc/sgml. Richard also havent't touched docbook in his patch for bu

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > Attached is a patch that gets rid of the ancient docbook "htmlurl" type > (bug 1520). With the patch the checkbox in the URL-dialog uses now \href, > so people can now switch between a printed URL and a hyperlinked URL (bug > 2268). Well, I'm not sure José's gonna love you for s

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Uwe Stöhr
Pavel Sanda schrieb: Attached is a patch that gets rid of the ancient docbook "htmlurl" type i know nothing of docbook, but i remember Jose has been working on something, so i would ask whether this deletion doesnt break something of docbook support in the future ? We got rid of it some time

Re: [patch] fix bug 1520 and 2268

2007-10-13 Thread Pavel Sanda
> Attached is a patch that gets rid of the ancient docbook "htmlurl" type i know nothing of docbook, but i remember Jose has been working on something, so i would ask whether this deletion doesnt break something of docbook support in the future ? > (bug 1520). > With the patch the checkbox in th

[patch] fix bug 1520 and 2268

2007-10-12 Thread Uwe Stöhr
Attached is a patch that gets rid of the ancient docbook "htmlurl" type (bug 1520). With the patch the checkbox in the URL-dialog uses now \href, so people can now switch between a printed URL and a hyperlinked URL (bug 2268). regards Uwe Index: development/FORMAT =