> Attached is a patch that gets rid of the ancient docbook "htmlurl" type 

i know nothing of docbook, but i remember Jose has been working on something,
so i would ask whether this deletion doesnt break something of docbook
support in the future ?

> (bug 1520).
> With the patch the checkbox in the URL-dialog uses now \href, so people can 
> now switch between a printed URL and a hyperlinked URL (bug 2268).

does it mean we finally get rid of the "\IfFileExists{url.sty}" which breaks
latex2html ?

>       odocstringstream oss;
> -     pdfoptions().writeLaTeX(oss);
> +     // use hyperref explicitely when it is required
> +     if (features.isRequired("hyperref"))
> +             pdfoptions().writeLaTeX(oss, true);
> +     else
> +             pdfoptions().writeLaTeX(oss, false);

why not
pdfoptions().writeLaTeX(oss, features.isRequired("hyperref"));

> Index: src/PDFOptions.h
> ===================================================================
> --- src/PDFOptions.h  (revision 20931)
> +++ src/PDFOptions.h  (working copy)
> @@ -28,7 +28,7 @@
>       /// output to lyx header
>       void writeFile(std::ostream &) const;
>       /// output to tex header
> -     void writeLaTeX(odocstringstream &) const;
> +     void writeLaTeX(odocstringstream &, bool hyper) const;

bool hyper_required or bool url_used or something like this, which would give 
the 
idea why this parameter without reading context of calling.


thanks for work on this.
pavel

Reply via email to