Re: [patch] dispatch-5.diff - beware

2003-10-30 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | why not rename val() as status()? > | if (dispatch.status() == FINISHED) { > > later patch. Sure ;-) Keep up the good work! -- Angus

Re: [patch] dispatch-5.diff - beware

2003-10-29 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> This patch introduces the DispatchResult::dispatched() function and >> removes DISPATCHED, UNDISPATCHED from dispatch_result_t, and changes >> DISPATCHED_NOUPDATE to NOUPDATE in dispatch_reuslt_t, > | The comment in dispat

Re: [patch] dispatch-5.diff - beware

2003-10-29 Thread Kuba Ober
> As dispatched() now returns a bool, why not rename it as success()? > The code above is then very elegant. [...] > Staying on the subject of names: > if (result.val() == FINISHED) { > > why not rename val() as status()? > if (dispatch.status() == FINISHED) { Just by looking at the proposed chang

Re: [patch] dispatch-5.diff - beware

2003-10-29 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > This patch introduces the DispatchResult::dispatched() function and > removes DISPATCHED, UNDISPATCHED from dispatch_result_t, and changes > DISPATCHED_NOUPDATE to NOUPDATE in dispatch_reuslt_t, The comment in dispatchresult.h still refers to DISPATCHED_NOUPDATE. Do