Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-07-05 Thread Jean-Marc Lasgouttes
> "Pavel" == Pavel Sanda <[EMAIL PROTECTED]> writes: >> 1) Is it correct to use a static object? In particular, there are >> no modifications of the locale in LyX initialization? 2) Would it >> make sense to have it as a non-static member of the class, or is it >> expensive to build? Pavel> i

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-06-24 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: >> other suggestions ? Alfredo> I think this patch is safe, OK from me. Yes, it is OK. I'll commit tomorrow if nobody objects. JMarc

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-06-23 Thread Alfredo Braunstein
Pavel Sanda wrote: >> 1) Is it correct to use a static object? In particular, there are no >> modifications of the locale in LyX initialization? >> 2) Would it make sense to have it as a non-static member of the class, or >> is it expensive to build? > > its easy to make it nonstatic member and i

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-06-12 Thread Pavel Sanda
> 1) Is it correct to use a static object? In particular, there are no > modifications of the locale in LyX initialization? > 2) Would it make sense to have it as a non-static member of the class, or is > it expensive to build? its easy to make it nonstatic member and i dont think its expensive. s

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-06-11 Thread Alfredo Braunstein
Pavel Sanda wrote: >> Whatever you do to solve your bug, please make sure that you don't set >> any new locale (at least not permanently, temporarily is OK). > > this patch should not interfere with other locale code. it only creates > locale object, which is set to current environment locale and

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-06-04 Thread Pavel Sanda
> Whatever you do to solve your bug, please make sure that you don't set any > new locale (at least not permanently, temporarily is OK). this patch should not interfere with other locale code. it only creates locale object, which is set to current environment locale and then is this object used as

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-06-01 Thread Georg Baum
Pavel Sanda wrote: > Up to now I havent found locale-sensitive sorting. If you have > any idea, where else in GUI we need to sort things in this way, > I'll investigate. > > There seems to be some locale code in docstring.cpp and docstream.cpp, > but dont know whether it could be used. (Georg ?)

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-05-31 Thread Pavel Sanda
> Actually, I do not think that I like it much, in particular since we > do not use std::locale at other places? $ grep -r std::locale * |wc -l 55 > Isn't it possible to do the same with setlocale? I didn't get what you mean. How can I collate two strings using setlocale ? Or you mean to rewr

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-05-31 Thread Jean-Marc Lasgouttes
> "Pavel" == Pavel Sanda <[EMAIL PROTECTED]> writes: >> the following patch fixes for me bug >> http://bugzilla.lyx.org/show_bug.cgi?id=2738 . >> >> std::locale loc(""); line should be placed somewhere else, but as >> i'm not much Pavel> ok, i made loc member of Sorter object. if there are n

Re: [patch] bug 2738: Wrong sorting of languages in Document dialog

2007-05-31 Thread Pavel Sanda
> the following patch fixes for me bug > http://bugzilla.lyx.org/show_bug.cgi?id=2738 . > > std::locale loc(""); line should be placed somewhere else, but as i'm not much ok, i made loc member of Sorter object. if there are no suggestion or comments i'm seeking two OK's and one commiter :) pav

[patch] bug 2738: Wrong sorting of languages in Document dialog

2007-05-29 Thread Pavel Sanda
Hello, the following patch fixes for me bug http://bugzilla.lyx.org/show_bug.cgi?id=2738 . std::locale loc(""); line should be placed somewhere else, but as i'm not much familiar with the code structure, i dont know where will be the best place for it. Pavel --- work/lyx-1.5.0beta3/src/fronten