Pavel Sanda wrote: >> 1) Is it correct to use a static object? In particular, there are no >> modifications of the locale in LyX initialization? >> 2) Would it make sense to have it as a non-static member of the class, or >> is it expensive to build? > > its easy to make it nonstatic member and i dont think its expensive. > see modified patch. > >> 3) We have a std::locale object in the Messages class, would it make >> sense to use that instead of building a new one? > > this object as well as the code using <locale> is inside #if 0 > > other suggestions ?
I think this patch is safe, OK from me. A/