Re: [patch] bug 1820 --- footnotes in different language

2007-07-13 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 03:05:39AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a \sele

Re: [patch] bug 1820 --- footnotes in different language

2007-07-13 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 03:21:42AM +0300, Dov Feldstern wrote: Dov Feldstern wrote: Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Enrico Forestieri
On Fri, Jul 13, 2007 at 03:21:42AM +0300, Dov Feldstern wrote: > Dov Feldstern wrote: > > Enrico Forestieri wrote: > >> On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: > >>> Enrico Forestieri wrote: > > With your patch applied, when I mark as english the footnote > > content

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Enrico Forestieri
On Fri, Jul 13, 2007 at 03:05:39AM +0300, Dov Feldstern wrote: > Enrico Forestieri wrote: > > On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: > >> Enrico Forestieri wrote: > With your patch applied, when I mark as english the footnote content > I correctly see a \selectlan

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Dov Feldstern wrote: Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a \selectlanguage{english} inserted before "bla bla bla". But I also see t

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Enrico Forestieri wrote: On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a \selectlanguage{english} inserted before "bla bla bla". But I also see that the whole footnote

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Enrico Forestieri
On Fri, Jul 13, 2007 at 02:31:05AM +0300, Dov Feldstern wrote: > Enrico Forestieri wrote: > >> With your patch applied, when I mark as english the footnote content > >> I correctly see a \selectlanguage{english} inserted before "bla bla bla". > >> But I also see that the whole footnote inset is ma

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Enrico Forestieri wrote: With your patch applied, when I mark as english the footnote content I correctly see a \selectlanguage{english} inserted before "bla bla bla". But I also see that the whole footnote inset is marked as foreign, so I select the whole of it and mark it as english. Now it is

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Enrico Forestieri
On Fri, Jul 13, 2007 at 12:47:20AM +0200, Enrico Forestieri wrote: > On Fri, Jul 13, 2007 at 01:27:09AM +0300, Dov Feldstern wrote: > > > > > > Enrico Forestieri wrote: > > > > > > > Writing again "bla bla bla", I got: > > > > > > (Point 3a) > > > bla bla bla \foreignlanguage{italian}{BLA BLA

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Enrico Forestieri
On Fri, Jul 13, 2007 at 01:27:09AM +0300, Dov Feldstern wrote: > > > Enrico Forestieri wrote: > > > > Writing again "bla bla bla", I got: > > > > (Point 3a) > > bla bla bla \foreignlanguage{italian}{BLA BLA BLA}% > > \footnote{bla bla bla% > > } > > > > which lacks the \selectlanguage command

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Enrico Forestieri wrote: Dov, Hi Enrico! Thanks for taking a look at this... :) this is what I did. Without your patch applied, I started a new document, so the language is english, and then activated "View Source". I wrote "bla bla bla ", then switched the language to italian and wrote "BL

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Enrico Forestieri
On Thu, Jul 12, 2007 at 09:19:15PM +0300, Dov Feldstern wrote: > What the patch is trying to fix is the case where a language switch was > being missed, for example in the following situation: > > document language is english > \lang english > bla bla bla > \lang hebrew > BLA BLA BLA > \footnote

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Peter Kümmel wrote: Dov Feldstern wrote: OK, here's my original patch for bug 1820 (without the second part, identical to what I originally sent in). It solves most cases, as far as I can determine is safe (I tried it on my documents with complex bidi / encoding / language transitions), and it

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
Dov Feldstern wrote: encoding / language transitions), and it does not constitute a format change, IMO. I'm not sure this is true, I think even just this patch is a format change... anyone care to take a look?

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Peter Kümmel
Dov Feldstern wrote: > OK, here's my original patch for bug 1820 (without the second part, > identical to what I originally sent in). It solves most cases, as far as > I can determine is safe (I tried it on my documents with complex bidi / > encoding / language transitions), and it does not constit

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread José Matos
On Thursday 12 July 2007 18:30:16 Dov Feldstern wrote: > Finally, there's the issue of bug 3613. It is due to some format change > from long ago which never had an accompanying lyx2lyx made for it (I > have nothing to do with that... ;) ). If possible, we should fix this > (i.e., create a lyx2lyx f

Re: [patch] bug 1820 --- footnotes in different language

2007-07-12 Thread Dov Feldstern
OK, here's my original patch for bug 1820 (without the second part, identical to what I originally sent in). It solves most cases, as far as I can determine is safe (I tried it on my documents with complex bidi / encoding / language transitions), and it does not constitute a format change, IMO.

Re: [patch] bug 1820 --- footnotes in different language

2007-07-11 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern writes: Dov> Do you know why this whole font-change mechanism was originally Dov> added? Consider a footnote with several paragraphs and assume it is typeset in \emph like this: \emph{Some text\footnote{and and explanation on several par

Re: [patch] bug 1820 --- footnotes in different language

2007-07-11 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Do you know why this whole font-change mechanism was originally Dov> added? Consider a footnote with several paragraphs and assume it is typeset in \emph like this: \emph{Some text\footnote{and and explanation on several paragraphs}

Re: [patch] bug 1820 --- footnotes in different language

2007-07-10 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: So, to sum up: the patch attached at http://permalink.gmane.org/gmane.editors.lyx.devel/89376 together with the patch attached here solve bug 1820 completely. Index: src/insets/In

Re: [patch] bug 1820 --- footnotes in different language

2007-07-09 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: are attached in bugzilla (though I'm having trouble downloading attachments from bugzilla, at the moment, anyone know anything about this?) Dov I was able to download the attachments from bugzilla now, and I see there's one case which still isn't

Re: [patch] bug 1820 --- footnotes in different language

2007-07-08 Thread Abdelrazak Younes
Dov Feldstern wrote: Hi! Attached find a patch for bug 1820, which has resisted solution for a long time. After a lot of work done by others to tidy up the output_latex code in the past few months, the infrastructure was now in place so that finally we can provide a solution. It would be good

Re: [patch] bug 1820 --- footnotes in different language

2007-07-08 Thread Dov Feldstern
Dov Feldstern wrote: are attached in bugzilla (though I'm having trouble downloading attachments from bugzilla, at the moment, anyone know anything about this?) Dov I was able to download the attachments from bugzilla now, and I see there's one case which still isn't solved. I'll try to tak

[patch] bug 1820 --- footnotes in different language

2007-07-08 Thread Dov Feldstern
Hi! Attached find a patch for bug 1820, which has resisted solution for a long time. After a lot of work done by others to tidy up the output_latex code in the past few months, the infrastructure was now in place so that finally we can provide a solution. It would be good if this could still