Dov Feldstern wrote: > OK, here's my original patch for bug 1820 (without the second part, > identical to what I originally sent in). It solves most cases, as far as > I can determine is safe (I tried it on my documents with complex bidi / > encoding / language transitions), and it does not constitute a format > change, IMO. > > If possible, it would be nice if this could go in to 1.5.0, preferably > after some other developers test it (no real active testing needed --- > just apply and make sure it doesn't break anything, specifically in > terms of language / encoding transitions). If not, I guess it's not the > end of the world, because since it doesn't constitute a format change, > we can apply it in 1.5.1.
OK, it compiles at least with msvc, and I could open, scroll, and build the german user guide (pdf), but is this enough? > > Regarding the remaining test case which this doesn't solve: it's really > part of a separate problem, that of *nested* language transitions. I'm > still working on it, I'm close to some sort of patch, I hope to send it > in soon. However, this part *is* a format change, so an accompanying > lyx2lyx would be necessary, and I haven't gotten to that yet. So if I am > able to get this all in on-time, great. But don't hold up the release > for this --- at the worst, I have a workaround for this test case using > ERT... > > Finally, there's the issue of bug 3613. It is due to some format change >> from long ago which never had an accompanying lyx2lyx made for it (I > have nothing to do with that... ;) ). If possible, we should fix this > (i.e., create a lyx2lyx fix) before 1.5.0. I can provide more details if > necessary, if anyone thinks they can help... > > Thanks! > Dov > > have a patch for that in the works, which I just want to touch up, and > hopefully send in later tonight >
