Re: [patch] Buffer* -> shared_pr

Lars Gullik Bjønnes wrote: > This patch does not compile... but it shows some stuff I worked on > some year ago... > > Is it a worthy goal? Sure. There are life time issues with the raw pointer that you address with a shared_ptr. Could you explain the rationale behind storing a weak_ptr in Buffe

[patch] Buffer* -> shared_pr

This patch does not compile... but it shows some stuff I worked on some year ago... Is it a worthy goal? ? Config ? buffer-1.diff ? work-1.diff Index: boost/boost/shared_ptr.hpp === RCS file: /usr/local/lyx/cvsroot/lyx-devel/boost/b

Re: [patch] Buffer::text -> Buffer::InsetText

Andre Poenitz wrote: > - replace the LyXText member in the Buffer pimpl by an InsetText. > This means we can drop a lot of special casing for the access > to the toplevel text as in This seems a great move. > [- rename BufferView::buffer to BufferView::setBuffer. Better for 'grep'.] > > [

[patch] buffer ref take 3

Unless I get objections I will apply this later this evening. bufferref-3.diff.gz Description: GNU Zip compressed data -- Lgb

Re: [Devel] [patch] buffer refs

On Tuesday 19 August 2003 7:50 am, Lars Gullik Bjønnes wrote: > Are the list sick? Maybe. As for the patch: man, you've been busy! It would appear that the only place expecting a Buffer * is the BufferView. Pretty well everywhere else expects a Buffer &. Things suddenly feel a lot nicer. That

[patch] buffer refs

Are the list sick? bufferref.diff.gz Description: GNU Zip compressed data -- Lgb

Re: [patch] buffer (fwd)

On Sun, Jul 27, 2003 at 10:54:38PM +0200, Braunstein Alfredo wrote: > Can we just consider these inconsistencies as bugs? Really, I think that > they all mean the same (cannot open file for writing). Am I right? Hmm, indeed, sorry john

Re: [patch] buffer (fwd)

too much beer really -- Forwarded message -- Date: Sun, 27 Jul 2003 22:52:43 +0200 (CEST) From: Braunstein Alfredo <[EMAIL PROTECTED]> To: John Levon <[EMAIL PROTECTED]> Subject: Re: [patch] buffer Today John Levon wrote: >On Sat, Jul 26, 2003 at 09:58:50PM +0

Re: [patch] buffer

On Sat, Jul 26, 2003 at 09:58:50PM +0200, Braunstein Alfredo wrote: > supposing it sucessfully finishes compiling, can I apply this? Too much beer ! > + string text = bformat(_("Could not open the specified " > + "document\n%1$s."), file); open >

Re: [patch] buffer

Braunstein Alfredo <[EMAIL PROTECTED]> writes: | supposing it sucessfully finishes compiling, can I apply this? yes. -- Lgb

[patch] buffer

supposing it sucessfully finishes compiling, can I apply this? Index: buffer.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/buffer.C,v retrieving revision 1.496 diff -u -r1.496 buffer.C --- buffer.C25 Jul 2003 21:20:04 -

Re: Patch: buffer selection in FormRef

On Fri, 7 Sep 2001, Dekel Tsur wrote: > On Fri, Sep 07, 2001 at 02:36:26PM +0100, Angus Leeming wrote: > > Perhaps you should do the same for citations? > > No. What we need is a mechanism that allows to specify that a document is > a part of a larger document, so when you insert a citation in th

Re: Patch: buffer selection in FormRef

On Fri, Sep 07, 2001 at 02:36:26PM +0100, Angus Leeming wrote: > Perhaps you should do the same for citations? No. What we need is a mechanism that allows to specify that a document is a part of a larger document, so when you insert a citation in the former, you get the keys of the latter. Actua

Re: Patch: buffer selection in FormRef

On Friday 07 September 2001 14:08, Dekel Tsur wrote: > The following patch adds a buffer button to FormRef which allows the user > to show the labels of any open buffer. > Is this a good idea ? Yes! It says in the documentation somewhere that we expect the user to be intelligent but posibly la

Patch: buffer selection in FormRef

The following patch adds a buffer button to FormRef which allows the user to show the labels of any open buffer. Is this a good idea ? Can I apply this patch (it doesn't change the kernel). patch.gz