Re: [patch] Window close menu item is always enabled

2008-09-04 Thread Jean-Marc Lasgouttes
rgheck <[EMAIL PROTECTED]> writes: > On Linux, anyway, I do have a File>Close Window, bound to C-S-W, as > well as a Close Tab, IF there is more than one tab open. Indeed. I missed it... > The Firefox behavior seems to me sensible: Why have two menu items > that do the same thing? But I don't kn

Re: [patch] Window close menu item is always enabled

2008-09-04 Thread rgheck
Jean-Marc Lasgouttes wrote: "Vincent van Ravesteijn - TNW" <[EMAIL PROTECTED]> writes: I would like to state that Mac users and Windows users all have the same point of view in this. To see this, realize that the motivation for the current implementation of the item is to enable Mac users to

Re: [patch] Window close menu item is always enabled

2008-09-04 Thread Jean-Marc Lasgouttes
"Vincent van Ravesteijn - TNW" <[EMAIL PROTECTED]> writes: > Although you might object fiercely, Fiercely is probably an overstatement :) > I would like to state that Mac users and Windows users all have the > same point of view in this. To see this, realize that the motivation > for the current

Re: [patch] Window close menu item is always enabled

2008-09-03 Thread Abdelrazak Younes
Konrad Hofbauer wrote: Abdelrazak Younes wrote: The File->Close Window menu item is always enabled, even when there is only 1 window. This is because 'enable = d->views_.size() > 0' in GuiApplication.cpp:741 will always be true. The attached patch changes the 0 into 1. Is this also ok for Ma

Re: [patch] Window close menu item is always enabled

2008-09-03 Thread Konrad Hofbauer
Abdelrazak Younes wrote: The File->Close Window menu item is always enabled, even when there is only 1 window. This is because 'enable = d->views_.size() > 0' in GuiApplication.cpp:741 will always be true. The attached patch changes the 0 into 1. Is this also ok for Mac ? I guess not as it is

RE: [patch] Window close menu item is always enabled

2008-09-03 Thread Vincent van Ravesteijn - TNW
>Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> If there is no other choice yes, it is possible at last resort. But >> why is this annoying? Why would you want to forbid current window >> closing even if there is only one window? Under Windows platform the >> app quits when the last window is clo

Re: [patch] Window close menu item is always enabled

2008-09-03 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > If there is no other choice yes, it is possible at last resort. But > why is this annoying? Why would you want to forbid current window > closing even if there is only one window? Under Windows platform the > app quits when the last window is close.

Re: [patch] Window close menu item is always enabled

2008-09-03 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: Vincent van Ravesteijn - TNW wrote: Hi, The File->Close Window menu item is always enabled, even when there is only 1 window. This is because 'enable = d->views_.size()> 0' in GuiApplication.cpp:741 will always be true. The attached patch

RE: [patch] Window close menu item is always enabled

2008-09-03 Thread Vincent van Ravesteijn - TNW
>Vincent van Ravesteijn - TNW wrote: >> Hi, >> The File->Close Window menu item is always enabled, even when there is >> only 1 window. This is because 'enable = d->views_.size() > 0' in >> GuiApplication.cpp:741 will always be true. The attached patch changes >> the 0 into 1. Is this also ok fo

Re: [patch] Window close menu item is always enabled

2008-09-03 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: Hi, The File->Close Window menu item is always enabled, even when there is only 1 window. This is because 'enable = d->views_.size() > 0' in GuiApplication.cpp:741 will always be true. The attached patch changes the 0 into 1. Is this also ok for Mac ? I gu

[patch] Window close menu item is always enabled

2008-09-03 Thread Vincent van Ravesteijn - TNW
Hi, The File->Close Window menu item is always enabled, even when there is only 1 window. This is because 'enable = d->views_.size() > 0' in GuiApplication.cpp:741 will always be true. The attached patch changes the 0 into 1. Is this also ok for Mac ? P.S. bug 5191 can be resolved after applyi